Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-14 Thread Alan Bateman
On Wed, 15 May 2024 00:54:43 GMT, David Holmes wrote: >> src/hotspot/share/runtime/arguments.cpp line 2271: >> >>> 2269: } else if (match_option(option, "--illegal-native-access=", >>> &tail)) { >>> 2270: if (!create_module_property("jdk.module.illegal.native.access", >>> tail, Inter

Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF

2024-05-14 Thread Abhishek Kumar
On Fri, 10 May 2024 07:05:11 GMT, Abhishek Kumar wrote: > JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua > L&F. JTabbedPane's content area and tab background color are not as expected > when tabbedpane opacity is set to true or false. Fix is to handle the opacity

Re: RFR: 8332103: Add missing `@since` tags to `java.desktop` [v2]

2024-05-14 Thread Nizar Benalla
> If you're currently reviewing this PR, thank you! > Most fixes here are according to the reports by the since checker tool in > #18934 and are pretty simple. > > To make reviewing easier > - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a > long time so the default

Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF

2024-05-14 Thread Alisen Chung
On Tue, 14 May 2024 23:57:20 GMT, Damon Nguyen wrote: >> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in >> Aqua L&F. JTabbedPane's content area and tab background color are not as >> expected when tabbedpane opacity is set to true or false. Fix is to handle >> the opa

Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF

2024-05-14 Thread Alisen Chung
On Fri, 10 May 2024 07:05:11 GMT, Abhishek Kumar wrote: > JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua > L&F. JTabbedPane's content area and tab background color are not as expected > when tabbedpane opacity is set to true or false. Fix is to handle the opacity

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-14 Thread David Holmes
On Mon, 13 May 2024 15:32:27 GMT, Alan Bateman wrote: >> Maurizio Cimadamore has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix another typo >> - Fix typo >> - Add more comments > > src/hotspot/share/runtime/arguments.cpp line 227

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v4]

2024-05-14 Thread David Holmes
On Tue, 14 May 2024 18:10:28 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF

2024-05-14 Thread Damon Nguyen
On Fri, 10 May 2024 07:05:11 GMT, Abhishek Kumar wrote: > JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua > L&F. JTabbedPane's content area and tab background color are not as expected > when tabbedpane opacity is set to true or false. Fix is to handle the opacity

Re: RFR: 8332103: Add missing `@since` tags to `java.desktop`

2024-05-14 Thread Nizar Benalla
On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla wrote: > If you're currently reviewing this PR, thank you! > Most fixes here are according to the reports by the since checker tool in > #18934 and are pretty simple. > > To make reviewing easier > - `BasicSliderUI` has the constructor `public Bas

Re: RFR: 8332103: Add missing `@since` tags to `java.desktop`

2024-05-14 Thread Nizar Benalla
On Tue, 14 May 2024 21:53:24 GMT, Phil Race wrote: >> If you're currently reviewing this PR, thank you! >> Most fixes here are according to the reports by the since checker tool in >> #18934 and are pretty simple. >> >> To make reviewing easier >> - `BasicSliderUI` has the constructor `public B

Re: RFR: 8332103: Add missing `@since` tags to `java.desktop`

2024-05-14 Thread Phil Race
On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla wrote: > If you're currently reviewing this PR, thank you! > Most fixes here are according to the reports by the since checker tool in > #18934 and are pretty simple. > > To make reviewing easier > - `BasicSliderUI` has the constructor `public Bas

Re: RFR: 8332103: Add missing `@since` tags to `java.desktop`

2024-05-14 Thread Phil Race
On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla wrote: > If you're currently reviewing this PR, thank you! > Most fixes here are according to the reports by the since checker tool in > #18934 and are pretty simple. > > To make reviewing easier > - `BasicSliderUI` has the constructor `public Bas

Re: RFR: 8331746: Create a test to verify that the cmm id is not ignored [v2]

2024-05-14 Thread Sergey Bylokhov
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and > verify that the cmm id of the icc profile is properly reported. Before > JDK-8321489 we always report 'lcms' as a cmm id. Sergey Bylokhov has updated the pull request incrementally with one additional commit since the

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v4]

2024-05-14 Thread Maurizio Cimadamore
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods > * binding a JNI `native` metho

Re: RFR: 8332103: Add missing `@since` tags to `java.desktop`

2024-05-14 Thread Tejesh R
On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla wrote: > If you're currently reviewing this PR, thank you! > Most fixes here are according to the reports by the since checker tool in > #18934 and are pretty simple. > > To make reviewing easier > - `BasicSliderUI` has the constructor `public Bas