Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v3]

2024-05-31 Thread Alexey Ivanov
On Fri, 31 May 2024 04:39:24 GMT, Abhishek Kumar wrote: >> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 136: >> >>> 134: if (refimg.getWidth() != testimg.getWidth() || >>> 135: refimg.getHeight() != testimg.getHeight()) >>> 136: {

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v3]

2024-05-31 Thread Alexey Ivanov
On Fri, 31 May 2024 05:02:16 GMT, Abhishek Kumar wrote: >> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 70: >> >>> 68: Class >>> type) >>> 69: throws Throwable >>> 70: { >> >> I think formatting here looks a little odd, could probab

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v4]

2024-05-31 Thread Alexey Ivanov
On Thu, 30 May 2024 07:30:10 GMT, Abhishek Kumar wrote: >> Yeah, true.. > > Tested in CI and there is no failure for multiple run. Removed this method. > But as I told before this may not impact the result of the test, it is just > to add extra delay to provide visual verification. In this cas

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-31 Thread Alexander Scherbatiy
On Fri, 31 May 2024 06:41:26 GMT, Prasanta Sadhukhan wrote: >> It is easy to add new constants to a public API but there is no way to >> remove them. >> OutpuBin constants work only if they are listed among the supported output >> bins. >> There is always a way to lookup `tray-n` output bin th

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v2]

2024-05-31 Thread Alexey Ivanov
On Fri, 31 May 2024 12:24:42 GMT, Prasanta Sadhukhan wrote: >> Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is >> resized from the lower right corner, then the Menu / JPopupmenu stays open >> unlike in native osx apps like Notes, Mail etc.. >> >> This is because wh

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v2]

2024-05-31 Thread Alexander Zvegintsev
On Fri, 31 May 2024 12:24:42 GMT, Prasanta Sadhukhan wrote: >> Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is >> resized from the lower right corner, then the Menu / JPopupmenu stays open >> unlike in native osx apps like Notes, Mail etc.. >> >> This is because wh

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v2]

2024-05-31 Thread Prasanta Sadhukhan
On Fri, 31 May 2024 10:51:29 GMT, Abhishek Kumar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Non-client aread edge area modified, test format > > test/jdk/javax/swing/JMenu/TestUngrab.java line 81: > >>

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v2]

2024-05-31 Thread Prasanta Sadhukhan
On Fri, 31 May 2024 09:55:37 GMT, Alexander Zvegintsev wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Non-client aread edge area modified, test format > > src/java.desktop/macosx/native/libawt_lwawt/awt/AWT

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v2]

2024-05-31 Thread Prasanta Sadhukhan
> Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is > resized from the lower right corner, then the Menu / JPopupmenu stays open > unlike in native osx apps like Notes, Mail etc.. > > This is because when LMouseButton is pressed on non-client area, the window > should

Re: RFR: 8280990: [XWayland] XTest emulated mouse click does not bring window to front

2024-05-31 Thread Alexander Zvegintsev
On Fri, 31 May 2024 12:01:22 GMT, Prasanta Sadhukhan wrote: > WIll it be a problem if we use toFront for the frame anyways? We have seen > and done tofront() for many tests where the frame gets obscured by some other > window so mouseclicks was not on desired area For this set of tests, yes,

Re: RFR: 8280990: [XWayland] XTest emulated mouse click does not bring window to front

2024-05-31 Thread Prasanta Sadhukhan
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev wrote: > Some of the modal tests fail in X11 compatibility mode on Wayland, because a > mouse click emulated with XTEST does not not cause the windows to be > reordered. > > This is a known limitation because these click events do not lea

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized

2024-05-31 Thread Abhishek Kumar
On Thu, 30 May 2024 12:05:25 GMT, Prasanta Sadhukhan wrote: > Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is > resized from the lower right corner, then the Menu / JPopupmenu stays open > unlike in native osx apps like Notes, Mail etc.. > > This is because when LM

Re: RFR: 8280990: [XWayland] XTest emulated mouse click does not bring window to front

2024-05-31 Thread Alexander Zvegintsev
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev wrote: > Some of the modal tests fail in X11 compatibility mode on Wayland, because a > mouse click emulated with XTEST does not not cause the windows to be > reordered. > > This is a known limitation because these click events do not lea

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized

2024-05-31 Thread Alexander Zvegintsev
On Thu, 30 May 2024 12:05:25 GMT, Prasanta Sadhukhan wrote: > Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is > resized from the lower right corner, then the Menu / JPopupmenu stays open > unlike in native osx apps like Notes, Mail etc.. > > This is because when LM

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v4]

2024-05-31 Thread Abhishek Kumar
On Thu, 30 May 2024 20:08:15 GMT, Alisen Chung wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> condition check update > > src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java > line 769:

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v5]

2024-05-31 Thread Abhishek Kumar
> In GTK LAF, the menu mnemonics are always displayed which is different from > the native behavior. In native application **(tested with gedit**), the menu > mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially > and then toggles between show/hide on `ALT` press. > Propo