On Tue, 4 Jun 2024 15:37:00 GMT, Abhishek Kumar wrote:
>> bug6492108.java test always fails in GTK L&F in single as well as dual
>> screen linux machines. Since this test was not marked as "_headful_" in it's
>> initial version, it never failed but after the fix of
>> [JDK-8287051](https://bug
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
> 17
On Tue, 4 Jun 2024 15:37:00 GMT, Abhishek Kumar wrote:
>> bug6492108.java test always fails in GTK L&F in single as well as dual
>> screen linux machines. Since this test was not marked as "_headful_" in it's
>> initial version, it never failed but after the fix of
>> [JDK-8287051](https://bug
On Mon, 3 Jun 2024 23:33:53 GMT, Nizar Benalla wrote:
> method: void java.awt.geom.Path2D.Double.trimToSize(): `@since` version is 9
> instead of 10
> method: void java.awt.geom.Path2D.Float.trimToSize(): `@since` version is 9
> instead of 10
In JDK 10, a new method `trimToSize` was added to P
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor `publ
On Tue, 4 Jun 2024 00:02:56 GMT, Nizar Benalla wrote:
>> It seems that BasicSliderUI() was added by the mistake? it was not mentioned
>> in the bug report...Seems it is too late to delete it?
>
> I'm sorry but `method: void javax.swing.plaf.basic.BasicSliderUI.()`
> refers to the constructor,
On Tue, 4 Jun 2024 15:37:00 GMT, Abhishek Kumar wrote:
>> bug6492108.java test always fails in GTK L&F in single as well as dual
>> screen linux machines. Since this test was not marked as "_headful_" in it's
>> initial version, it never failed but after the fix of
>> [JDK-8287051](https://bug
On Tue, 4 Jun 2024 15:21:30 GMT, Alexey Ivanov wrote:
>> Updated.
>
> I can't see it in the PR. Didn't push?
Oh my bad, I missed to add that changes. Pushed now.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1626228348
> bug6492108.java test always fails in GTK L&F in single as well as dual screen
> linux machines. Since this test was not marked as "_headful_" in it's initial
> version, it never failed but after the fix of
> [JDK-8287051](https://bugs.openjdk.org/browse/JDK-8287051) this test was
> problem li
On Tue, 4 Jun 2024 14:46:37 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
>> line 1:
>>
>>> 1: /*
>>
>> You should update the copyright year.
>
> Updated.
I can't see it in the PR. Didn't push?
>> test/jdk/com/sun/java/swing/plaf/gtk/b
On Tue, 4 Jun 2024 13:45:44 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code formatting update
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line
> 1:
>
>>
> bug6492108.java test always fails in GTK L&F in single as well as dual screen
> linux machines. Since this test was not marked as "_headful_" in it's initial
> version, it never failed but after the fix of
> [JDK-8287051](https://bugs.openjdk.org/browse/JDK-8287051) this test was
> problem li
On Mon, 3 Jun 2024 05:48:18 GMT, Abhishek Kumar wrote:
>> Previous formatting was less confusing and aligned with Java Coding Style
>> Guidelines.
>>
>> The parameters to the method are aligned to the opening parenthesis; the
>> `throws` clause is not part of the parameters and it's placed on
On Mon, 3 Jun 2024 05:52:31 GMT, Abhishek Kumar wrote:
>> bug6492108.java test always fails in GTK L&F in single as well as dual
>> screen linux machines. Since this test was not marked as "_headful_" in it's
>> initial version, it never failed but after the fix of
>> [JDK-8287051](https://bug
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
Marked as reviewed by aivanov (Reviewer).
-
PR Review: ht
Hi Reviewers,
I have updated the test case with passing float value for evaluation and a
typo. Please review and let me know your suggestions if any.
-
Commit messages:
- JDK-860 : PrintNullString.java doesn't use float arguments
Changes: https://git.openjdk.org/jdk/pull/19540/
On Mon, 3 Jun 2024 06:07:37 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 1031:
>>
>>> 1029: (p.x >= (frame.origin.x + contentRect.size.width -
>>> 3)) ||
>>> 1030: (fabs(frame.origin.x - p.x) < 3) ||
>>> 1031
17 matches
Mail list logo
