Re: RFR: 8333403: Write a test to check various components events are triggered properly [v2]

2024-06-05 Thread Tejesh R
On Wed, 5 Jun 2024 08:29:11 GMT, Ravi Gupta wrote: >> This testcase checks for the following assertions for Component events: >> >> 1. When components are resized, moved, hidden and shown the respective >> events are triggered. >> 2. When the components are hidden/disabled also,the component

Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v2]

2024-06-05 Thread Alisen Chung
> Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup Alisen Chung has updated the pull request with a new target base due to a

Re: RFR: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location [v2]

2024-06-05 Thread Abhishek Kumar
On Wed, 5 Jun 2024 22:27:43 GMT, Alisen Chung wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> copyright year update > > src/java.desktop/share/classes/javax/swing/table/JTableHeader.java line 1368: > >> 1366:

Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup

2024-06-05 Thread Harshitha Onkar
On Wed, 5 Jun 2024 23:33:21 GMT, Alisen Chung wrote: > Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup Fix works as

RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup

2024-06-05 Thread Alisen Chung
Issue is a mouse drag will trigger a popup in macos, but not in linux or windows. The solution is to add a check for a mouse pressed event to show popup and prevent mouse entered events from triggering the popup - Commit messages: - fix trailing whitespace in instructions string

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v5]

2024-06-05 Thread Alisen Chung
On Fri, 31 May 2024 08:49:17 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit**), the menu >> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v11]

2024-06-05 Thread 柳鲲鹏
On Sun, 5 May 2024 10:17:40 GMT, 柳鲲鹏 wrote: >> Candidat box can moving with caret on windows version. Someone must wrote >> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. >> Why it doesn't work, is the key problem. >> >> 1, I wrote a example for linux: >>

Re: RFR: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location [v2]

2024-06-05 Thread Alisen Chung
On Wed, 5 Jun 2024 16:14:11 GMT, Abhishek Kumar wrote: >> "java.awt.IllegalComponentStateException: component must be showing on the >> screen to determine its location" is thrown when getLocationOnScreen method >> is invoked for JTableHeader while testing JFileChooser demo. It seems that >>

Re: RFR: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location [v2]

2024-06-05 Thread Abhishek Kumar
> "java.awt.IllegalComponentStateException: component must be showing on the > screen to determine its location" is thrown when getLocationOnScreen method > is invoked for JTableHeader while testing JFileChooser demo. It seems that in > getLocationOfScreen method we are trying to access the

Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments

2024-06-05 Thread Abhishek Kumar
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > I have updated the test case with passing float value for evaluation and a > typo. Please review and let me know your suggestions if any. Ran the updated test and looks good to me. - Marked as

Integrated: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L

2024-06-05 Thread Abhishek Kumar
On Fri, 24 May 2024 06:44:06 GMT, Abhishek Kumar wrote: > bug6492108.java test always fails in GTK L in single as well as dual screen > linux machines. Since this test was not marked as "_headful_" in it's initial > version, it never failed but after the fix of >

Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments

2024-06-05 Thread Abhishek Kumar
On Wed, 5 Jun 2024 12:20:00 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172: >> >>> 170: >>> 171: try { >>> 172: g2d.drawString(emptyIterator, 20.0f, 180.0f); >> >> Does the line below also need to change ? >>

Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments

2024-06-05 Thread Alexey Ivanov
On Wed, 5 Jun 2024 04:53:56 GMT, Abhishek Kumar wrote: >> Hi Reviewers, >> I have updated the test case with passing float value for evaluation and a >> typo. Please review and let me know your suggestions if any. > > test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172: > >> 170:

Re: RFR: 8333403: Write a test to check various components events are triggered properly [v2]

2024-06-05 Thread lawrence . andrews
On Wed, 5 Jun 2024 08:29:11 GMT, Ravi Gupta wrote: >> This testcase checks for the following assertions for Component events: >> >> 1. When components are resized, moved, hidden and shown the respective >> events are triggered. >> 2. When the components are hidden/disabled also,the component

Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua LAF

2024-06-05 Thread Abhishek Kumar
On Fri, 10 May 2024 17:33:53 GMT, Sergey Bylokhov wrote: >> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in >> Aqua L JTabbedPane's content area and tab background color are not as >> expected when tabbedpane opacity is set to true or false. Fix is to handle >> the

Re: RFR: 8333403: Write a test to check various components events are triggered properly [v2]

2024-06-05 Thread Vanitha B P
On Wed, 5 Jun 2024 08:26:45 GMT, Ravi Gupta wrote: >> This testcase checks for the following assertions for Component events: >> >> 1. When components are resized, moved, hidden and shown the respective >> events are triggered. >> 2. When the components are hidden/disabled also,the component

Re: RFR: 8333403: Write a test to check various components events are triggered properly [v2]

2024-06-05 Thread Ravi Gupta
> This testcase checks for the following assertions for Component events: > > 1. When components are resized, moved, hidden and shown the respective events > are triggered. > 2. When the components are hidden/disabled also,the component events like > resized/moved are triggered. > 3. When a