RFR: 8334509: Cancelling PageDialog does not return the same PageFormat object

2024-06-18 Thread Prasanta Sadhukhan
On cancelling PageDialog, same PageFormat object should be returned which stopped working after [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160). Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that correct value is returned from PageDialog.show action.. An automated

Re: RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-18 Thread Alisen Chung
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote: > Migrate font code from jdk.internal.misc.Unsafe to using FFM. > This reduces the coupling between the java.desktop module and the internals > of the java.base module. > > The code being changed here is not particularly performance sensitive,

Re: RFR: 8297191 : [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

2024-06-18 Thread Alisen Chung
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > This fix will resolve page range not printing proper pages if the rage begin > from 2 or above on Mac machines. > I have verified the manual range related tests like PageRanges.java, > ClippedImages.java

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-18 Thread Alisen Chung
On Mon, 17 Jun 2024 07:29:45 GMT, Tejesh R wrote: >> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER >> functionalities to disable navigation within JTable of FilePane in >> DetailsView. This is causing the issue mentioned in the bug where on >> invoking DetailsView the

Integrated: 8291472: [macos] jawt 1.4 lock/unlock not supported

2024-06-18 Thread Alisen Chung
On Mon, 10 Jun 2024 21:09:35 GMT, Alisen Chung wrote: > Removing if check for unsupported jawt versions This pull request has now been integrated. Changeset: 2ce85d96 Author:Alisen Chung URL: https://git.openjdk.org/jdk/commit/2ce85d96352cef4910cb6a5c2d9b174ca9d8a4e4 Stats: 10

RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation

2024-06-18 Thread Phil Race
Migrate font code from jdk.internal.misc.Unsafe to using FFM. This reduces the coupling between the java.desktop module and the internals of the java.base module. The code being changed here is not particularly performance sensitive, and it is not executed in the most common cases. The main

Re: RFR: 8333268: Fixes for static build [v2]

2024-06-18 Thread Magnus Ihse Bursie
On Tue, 18 Jun 2024 16:19:39 GMT, Magnus Ihse Bursie wrote: >> This patch contains a set of changes to improve static builds. They will >> pave the way for implementing a full static-only java launcher. The changes >> here will: >> >> 1) Make sure non-exported symbols are made local in the

Re: RFR: 8333268: Fixes for static build

2024-06-18 Thread Magnus Ihse Bursie
On Thu, 30 May 2024 19:35:44 GMT, Magnus Ihse Bursie wrote: > Do os::lookup_function need to be implemented on Windows too, for symmetry, > even if it is only used on Unix platforms? @AlanBateman suggested to add `lookup_function` to os_windows.cpp as well, but just let it contain

Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v2]

2024-06-18 Thread Alexey Ivanov
On Wed, 12 Jun 2024 20:55:51 GMT, Sergey Bylokhov wrote: > > How do we remove this constructor? Can it be removed right away? Should it > > be deprecated for several releases before it's removed? > > Just delete it in all versions of 17+? Now it is part of Java 17 and 21. It can't be removed

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

2024-06-18 Thread Alexey Ivanov
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit**), the menu >> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

2024-06-18 Thread Alexey Ivanov
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit**), the menu >> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially

Re: RFR: 8333268: Fixes for static build [v2]

2024-06-18 Thread Magnus Ihse Bursie
> This patch contains a set of changes to improve static builds. They will pave > the way for implementing a full static-only java launcher. The changes here > will: > > 1) Make sure non-exported symbols are made local in the static libraries. > This means that the risk of symbol conflict is

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

2024-06-18 Thread Abhishek Kumar
On Tue, 18 Jun 2024 12:50:42 GMT, Abhishek Kumar wrote: >> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java >> line 1056: >> >>> 1054: * @param hide true if mnemonics should be hidden >>> 1055: * @since 23 >>> 1056: */ >> >> Hmm. So .. new public API

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

2024-06-18 Thread Abhishek Kumar
On Tue, 18 Jun 2024 12:51:34 GMT, Abhishek Kumar wrote: >> since this method should be recursing through all of a component's >> subcomponents, shouldn't there not even be an if check here? > >> JComponent extends Container .. so this will traverse everything in the >> Swing UI. > Is there any

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

2024-06-18 Thread Abhishek Kumar
On Fri, 14 Jun 2024 20:28:11 GMT, Phil Race wrote: > Hmm. So .. new public API ? Is this absolutely necessary ? I don't see why an app would need to call this directly. `setMnemonicHidden` can be changed to a `protected` member as you pointed out it may not be required by an app to call this

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

2024-06-18 Thread Abhishek Kumar
On Sat, 15 Jun 2024 00:23:07 GMT, Alisen Chung wrote: >> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java >> line 785: >> >>> 783: } >>> 784: >>> 785: if (c instanceof Container) { >> >> JComponent extends Container .. so this will

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

2024-06-18 Thread Abhishek Kumar
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit**), the menu >> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially

Re: RFR: 5021949: JSplitPane setEnabled(false) shouldn't be partially functional [v3]

2024-06-18 Thread Alexey Ivanov
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan wrote: >> Issue is seen in that if we call setEnabled(false) over JSplitPane than it >> can't be dragged via its divider, But if SplitPane have one touch expandable >> true than user can click those buttons and change the divider position.

Re: RFR: 5021949: JSplitPane setEnabled(false) shouldn't be partially functional [v3]

2024-06-18 Thread Alexey Ivanov
On Mon, 17 Jun 2024 05:08:29 GMT, Prasanta Sadhukhan wrote: > All L including Aqua extends BasicSplitPaneUI so it's ok...The existing > test iterates through all L without any issue.. That is true, yet it is still possible to set a L that doesn't extend `BasicSplitPaneUI` and the updated

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-18 Thread Tejesh R
On Tue, 18 Jun 2024 05:13:14 GMT, Tejesh R wrote: >> src/java.desktop/share/classes/sun/swing/FilePane.java line 1320: >> >>> 1318: } >>> 1319: >>> 1320: >>> detailsTable.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS, >> >> If I have this right, JTable