8334580: Deprecate no-arg constructor BasicSliderUI() for removal
-
Commit messages:
- Backport e527e1c32fcc7b2560cec540bcde930075ac284a
Changes: https://git.openjdk.org/jdk/pull/19874/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19874&range=00
Issue: https://bugs.open
On Fri, 21 Jun 2024 03:31:50 GMT, Prasanta Sadhukhan
wrote:
> The no-arg constructor BasicSliderUI() was added under
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
> constructor should be deprecated for removal in future release
This pull request has now been in
On Thu, 6 Jun 2024 23:28:07 GMT, Alisen Chung wrote:
> Add a check for previous focused window on modal unblocking. If the owner of
> a closing dialog was the last focused window, then the owner of the dialog
> should regain focus.
This pull request has now been integrated.
Changeset: 3a26bbc
On Fri, 14 Jun 2024 04:44:24 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component e
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote:
>> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
>> This reduces the coupling between the java.desktop module and the internals
>> of the java.base module.
>>
>> The code being changed here is not particularly performance sensit
On Fri, 7 Jun 2024 20:34:23 GMT, Alisen Chung wrote:
>> Add a check for previous focused window on modal unblocking. If the owner of
>> a closing dialog was the last focused window, then the owner of the dialog
>> should regain focus.
>
> Alisen Chung has updated the pull request incrementally
> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
> This reduces the coupling between the java.desktop module and the internals
> of the java.base module.
>
> The code being changed here is not particularly performance sensitive, and it
> is not executed in the most common cases.
>
On Thu, 20 Jun 2024 08:29:39 GMT, Julian Waters wrote:
> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a
> memmove decay bug by rewriting a sizeof on an array to an explicit size of
> 256, but this is a bit of a band aid fix. It's come to my attention that in
> C++, one
On Mon, 24 Jun 2024 19:32:15 GMT, Nizar Benalla wrote:
> Let me add a new commit to remove the sponsor label
Thank you!
-
PR Comment: https://git.openjdk.org/jdk/pull/19192#issuecomment-2187363695
This is somewhat a continuation for
[JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
[JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
The former removed the `doIt` flag in #18584, but it introduced a regression.
The regression is resolved by the latter in #19786, and i
> If you're currently reviewing this PR, thank you!
> Most fixes here are according to the reports by the since checker tool in
> #18934 and are pretty simple.
>
> To make reviewing easier
> - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a
> long time so the default
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor `publ
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor `publ
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote:
> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
> This reduces the coupling between the java.desktop module and the internals
> of the java.base module.
>
> The code being changed here is not particularly performance sensitive,
On Mon, 24 Jun 2024 18:07:11 GMT, Maurizio Cimadamore
wrote:
>> src/java.desktop/share/classes/sun/font/StrikeCache.java line 151:
>>
>>> 149:
>>> 150: @SuppressWarnings("restricted")
>>> 151: static final float getGlyphXAdvance(long ptr) {
>>
>> now, I'm not an expert of this code, b
On Mon, 24 Jun 2024 18:04:38 GMT, Maurizio Cimadamore
wrote:
>> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
>> This reduces the coupling between the java.desktop module and the internals
>> of the java.base module.
>>
>> The code being changed here is not particularly perform
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote:
> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
> This reduces the coupling between the java.desktop module and the internals
> of the java.base module.
>
> The code being changed here is not particularly performance sensitive,
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Mon, 24 Jun 2024 16:33:56 GMT, Prasanta Sadhukhan
wrote:
> 8334509: Cancelling PageDialog does not return the same PageFormat object
This pull request has now been integrated.
Changeset: fbcf6d9c
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/fbcf6d9c4f751ca4b
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Mon, 24 Jun 2024 16:33:56 GMT, Prasanta Sadhukhan
wrote:
> 8334509: Cancelling PageDialog does not return the same PageFormat object
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19865#pullrequestreview-2136352506
8334509: Cancelling PageDialog does not return the same PageFormat object
-
Commit messages:
- Backport 689cee3d0950e15e88a1f6738bfded00655dca9c
Changes: https://git.openjdk.org/jdk/pull/19865/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19865&range=00
Issue: https://b
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
> The no-arg constructor BasicSliderUI() was added under
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
> constructor should be deprecated for removal in future release
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since
On Fri, 21 Jun 2024 15:51:29 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so tha
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor `publ
On Mon, 24 Jun 2024 05:50:40 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Mon, 24 Jun 2024 05:50:40 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Mon, 24 Jun 2024 07:17:19 GMT, Abhishek Kumar wrote:
>>> Wouldn't it be easier to install altProcessor always in
>>> SynthLookAndFeel.initialize and to uninstall it in
>>> SynthLookAndFeel.uninitialize like it's done in WindowsLookAndFeel:
>> https://github.com/openjdk/jdk/blob/master/src/ja
On Mon, 24 Jun 2024 06:21:51 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java
>> line 45:
>>
>>> 43: private SynthStyle style;
>>> 44: static final AltProcessor altProcessor = new AltProcessor();
>>> 45: static boolean altProce
On Fri, 21 Jun 2024 20:14:28 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove access modifier from method declaration
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphi
31 matches
Mail list logo
