Re: RFR: 8337237: Use FFM instead of Unsafe for Java 2D RenderBuffer class

2024-07-25 Thread Per Minborg
On Thu, 25 Jul 2024 22:53:36 GMT, Phil Race wrote: > Migrate from using Unsafe to FFM's MemorySegment API for allocating and > setting native memory. > This code is used by Metal, OpenGL and D3D, so I manually tested SwingSet2 > and J2Demo as well as running all the usual tests. > I also did so

Re: RFR: 8337237: Use FFM instead of Unsafe for Java 2D RenderBuffer class

2024-07-25 Thread Per Minborg
On Thu, 25 Jul 2024 22:53:36 GMT, Phil Race wrote: > Migrate from using Unsafe to FFM's MemorySegment API for allocating and > setting native memory. > This code is used by Metal, OpenGL and D3D, so I manually tested SwingSet2 > and J2Demo as well as running all the usual tests. > I also did so

Integrated: 8216471: GTK LnF: Frame is clipped and does not show JTable,Tooltip and JTree demo in SwingSet2 demo

2024-07-25 Thread Abhishek Kumar
On Fri, 5 Jul 2024 11:20:47 GMT, Abhishek Kumar wrote: > The issue is due to the preferred width of the toggle button in GTK L&F for > GTK3 only. > Comparing the preferred width of toggle button with GTK2 or other LAF, it is > much higher in GTK3. The difference is due to the insets value in GT

Integrated: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground

2024-07-25 Thread Abhishek Kumar
On Wed, 24 Jul 2024 05:12:17 GMT, Abhishek Kumar wrote: > In GTKPainter.paintPopupMenuBackground method, `img != null` condition will > always be true, because it's only checked after `img.getRGB` method is called > and that means img can't be `null`. So, the null check condition is removed.

Re: RFR: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground [v3]

2024-07-25 Thread Tejesh R
On Thu, 25 Jul 2024 12:35:05 GMT, Abhishek Kumar wrote: >> In GTKPainter.paintPopupMenuBackground method, `img != null` condition will >> always be true, because it's only checked after `img.getRGB` method is >> called and that means img can't be `null`. So, the null check condition is >> rem

RFR: 6318027: BasicScrollBarUI does not disable timer when enclosing frame is disabled.

2024-07-25 Thread Prasanta Sadhukhan
Issue is BasicScrollBarUI.ArrowButtonListener starts a timer in mousePressed(), and stops it in mouseReleased(). If the frame containing the scrollbar is disabled between the MOUSE_PRESSED and the MOUSE_RELEASED events, the mouseReleased() method is never called. If the frame is then re-enabled,

Re: RFR: 8337237: Use FFM instead of Unsafe for Java 2D RenderBuffer class

2024-07-25 Thread Phil Race
On Thu, 25 Jul 2024 23:32:02 GMT, Jorn Vernee wrote: >> Migrate from using Unsafe to FFM's MemorySegment API for allocating and >> setting native memory. >> This code is used by Metal, OpenGL and D3D, so I manually tested SwingSet2 >> and J2Demo as well as running all the usual tests. >> I also

Re: RFR: 8337237: Use FFM instead of Unsafe for Java 2D RenderBuffer class

2024-07-25 Thread Jorn Vernee
On Thu, 25 Jul 2024 23:36:46 GMT, Jorn Vernee wrote: >> Migrate from using Unsafe to FFM's MemorySegment API for allocating and >> setting native memory. >> This code is used by Metal, OpenGL and D3D, so I manually tested SwingSet2 >> and J2Demo as well as running all the usual tests. >> I also

Re: RFR: 8337237: Use FFM instead of Unsafe for Java 2D RenderBuffer class

2024-07-25 Thread Jorn Vernee
On Thu, 25 Jul 2024 22:53:36 GMT, Phil Race wrote: > Migrate from using Unsafe to FFM's MemorySegment API for allocating and > setting native memory. > This code is used by Metal, OpenGL and D3D, so I manually tested SwingSet2 > and J2Demo as well as running all the usual tests. > I also did so

Re: RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags [v2]

2024-07-25 Thread Phil Race
On Thu, 25 Jul 2024 09:18:50 GMT, Alexey Ivanov wrote: >> After I integrated >> [JDK-8326734](https://bugs.openjdk.org/browse/JDK-8326734), there's no way >> to remove text decoration from an HTML element. The most common HTML element >> is `` which is usually rendered _underlined_. You could

RFR: 8337237: Use FFM instead of Unsafe for Java 2D RenderBuffer class

2024-07-25 Thread Phil Race
Migrate from using Unsafe to FFM's MemorySegment API for allocating and setting native memory. This code is used by Metal, OpenGL and D3D, so I manually tested SwingSet2 and J2Demo as well as running all the usual tests. I also did some micro-benchmarking on the performance of Unsafe vs MemorySe

Re: RFR: 8335267: [XWayland] move screencast tokens from .awt to .java folder

2024-07-25 Thread Phil Race
On Thu, 25 Jul 2024 15:39:53 GMT, Alexander Zvegintsev wrote: >> src/java.desktop/unix/classes/sun/awt/screencast/TokenStorage.java line 113: >> >>> 111: Path secondaryPath = Path.of(userHome, REL_NAME_SECONDARY); >>> 112: >>> 113: Path path = Files.isWritable(secondaryPath) &&

Re: RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags [v2]

2024-07-25 Thread Harshitha Onkar
On Thu, 25 Jul 2024 09:18:50 GMT, Alexey Ivanov wrote: >> After I integrated >> [JDK-8326734](https://bugs.openjdk.org/browse/JDK-8326734), there's no way >> to remove text decoration from an HTML element. The most common HTML element >> is `` which is usually rendered _underlined_. You could

Re: RFR: 7188058: Background of TextComponents are not changing colors to the default disabled color when set to uneditable

2024-07-25 Thread Alisen Chung
On Thu, 4 Jul 2024 00:17:48 GMT, Harshitha Onkar wrote: >> Currently the bug described in the issue is that the colors of the >> TextComponents do not change when setting TextComponents to uneditable. The >> default uneditable color (SystemColor.control) happens to be the same as the >> defaul

Re: RFR: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F [v6]

2024-07-25 Thread Damon Nguyen
On Thu, 25 Jul 2024 17:03:05 GMT, Abhishek Kumar wrote: >> This test was modified under >> [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the >> applet usage. Test modification includes the instruction change as well >> which says that `Check that there is a panel wit

Re: RFR: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F [v6]

2024-07-25 Thread Abhishek Kumar
> This test was modified under > [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the > applet usage. Test modification includes the instruction change as well which > says that `Check that there is a panel with "Text Preview Panel" text and > with title "Preview" in the

Re: RFR: 8335267: [XWayland] move screencast tokens from .awt to .java folder

2024-07-25 Thread Alexey Ushakov
On Thu, 18 Jul 2024 14:08:35 GMT, Alexander Zvegintsev wrote: > Trivial fix to move the screencast token storage file from > `~/.awt/robot/screencast-tokens.properties` to > `~/.java/robot/screencast-tokens.properties`, where it should be. > Old location is still valid and will only be used if

Re: RFR: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F [v5]

2024-07-25 Thread Damon Nguyen
On Wed, 24 Jul 2024 09:17:47 GMT, Abhishek Kumar wrote: >> This test was modified under >> [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the >> applet usage. Test modification includes the instruction change as well >> which says that `Check that there is a panel wit

Re: RFR: 8216471: GTK LnF: Frame is clipped and does not show JTable,Tooltip and JTree demo in SwingSet2 demo [v5]

2024-07-25 Thread Prasanta Sadhukhan
On Wed, 17 Jul 2024 07:24:07 GMT, Abhishek Kumar wrote: >> The issue is due to the preferred width of the toggle button in GTK L&F for >> GTK3 only. >> Comparing the preferred width of toggle button with GTK2 or other LAF, it is >> much higher in GTK3. The difference is due to the insets value

Re: RFR: 8216471: GTK LnF: Frame is clipped and does not show JTable,Tooltip and JTree demo in SwingSet2 demo

2024-07-25 Thread Abhishek Kumar
On Thu, 11 Jul 2024 14:09:43 GMT, Prasanta Sadhukhan wrote: >>> > Also, is it possible to change the width only when GTK is loaded and not >>> > irrespectively? >>> >>> Tried changing the frame width in >>> [updateThisSwingSet](https://github.com/openjdk/jdk/blob/0e0dfca21f64ecfcb3e5ed7cdc2a1

Re: RFR: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground [v3]

2024-07-25 Thread Prasanta Sadhukhan
On Thu, 25 Jul 2024 12:35:05 GMT, Abhishek Kumar wrote: >> In GTKPainter.paintPopupMenuBackground method, `img != null` condition will >> always be true, because it's only checked after `img.getRGB` method is >> called and that means img can't be `null`. So, the null check condition is >> rem

Re: RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work

2024-07-25 Thread Abhishek Kumar
On Thu, 25 Jul 2024 14:04:32 GMT, Tejesh R wrote: > Mismatch in key combinations, I have taken native macos Numbers application > as reference to verify. Have added `Ctrl-Shift Left/Right` action keys > similar to `Ctrl-Shift UP/DOWN` which would be expected functionality. I've > removed those

RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work

2024-07-25 Thread Tejesh R
Mismatch in key combinations, I have taken native macos Numbers application as reference to verify. Have added `Ctrl-Shift Left/Right` action keys similar to `Ctrl-Shift UP/DOWN` which would be expected functionality. I've removed those test instructions which are not applicable/implemented/not

Re: RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work

2024-07-25 Thread Tejesh R
On Thu, 25 Jul 2024 15:53:39 GMT, Abhishek Kumar wrote: > @TejeshR13 Looks like the bug is not accessible. Update the bug, PR should sync with the updates. - PR Comment: https://git.openjdk.org/jdk/pull/20331#issuecomment-2250825972

Re: RFR: 8335267: [XWayland] move screencast tokens from .awt to .java folder

2024-07-25 Thread Alexander Zvegintsev
On Thu, 25 Jul 2024 14:43:27 GMT, Alexey Ushakov wrote: >> Trivial fix to move the screencast token storage file from >> `~/.awt/robot/screencast-tokens.properties` to >> `~/.java/robot/screencast-tokens.properties`, where it should be. >> Old location is still valid and will only be used if th

Re: RFR: 8335267: [XWayland] move screencast tokens from .awt to .java folder

2024-07-25 Thread Alexey Ushakov
On Thu, 18 Jul 2024 14:08:35 GMT, Alexander Zvegintsev wrote: > Trivial fix to move the screencast token storage file from > `~/.awt/robot/screencast-tokens.properties` to > `~/.java/robot/screencast-tokens.properties`, where it should be. > Old location is still valid and will only be used if

Re: RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags [v2]

2024-07-25 Thread Dmitry Markov
On Thu, 25 Jul 2024 09:18:50 GMT, Alexey Ivanov wrote: >> After I integrated >> [JDK-8326734](https://bugs.openjdk.org/browse/JDK-8326734), there's no way >> to remove text decoration from an HTML element. The most common HTML element >> is `` which is usually rendered _underlined_. You could

Re: RFR: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground [v2]

2024-07-25 Thread Abhishek Kumar
On Thu, 25 Jul 2024 12:21:54 GMT, Prasanta Sadhukhan wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comment fix > > Marked as reviewed by psadhukhan (Reviewer). @prsadhuk Please re-review due to recent

Re: RFR: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground [v3]

2024-07-25 Thread Abhishek Kumar
> In GTKPainter.paintPopupMenuBackground method, `img != null` condition will > always be true, because it's only checked after `img.getRGB` method is called > and that means img can't be `null`. So, the null check condition is removed. > CI testing is ok. Abhishek Kumar has updated the pull r

Re: RFR: 8336873: BasicSplitPaneDivider:oneTouchExpandableChanged() should mention that implementation depends on SplitPane.supportsOneTouchButtons property [v2]

2024-07-25 Thread Abhishek Kumar
On Tue, 23 Jul 2024 08:18:07 GMT, Prasanta Sadhukhan wrote: >> BasicSplitPaneDivider:oneTouchExpandableChanged() spec doesn't mention that >> it will create left/right button only if L&F supports >> SplitPane.supportsOneTouchButtons which is now added in javadoc.. > > Prasanta Sadhukhan has up

Re: RFR: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground [v2]

2024-07-25 Thread Prasanta Sadhukhan
On Thu, 25 Jul 2024 04:01:03 GMT, Abhishek Kumar wrote: >> In GTKPainter.paintPopupMenuBackground method, `img != null` condition will >> always be true, because it's only checked after `img.getRGB` method is >> called and that means img can't be `null`. So, the null check condition is >> rem

Re: RFR: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F [v5]

2024-07-25 Thread Prasanta Sadhukhan
On Wed, 24 Jul 2024 09:17:47 GMT, Abhishek Kumar wrote: >> This test was modified under >> [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the >> applet usage. Test modification includes the instruction change as well >> which says that `Check that there is a panel wit

Re: RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags [v2]

2024-07-25 Thread Abhishek Kumar
On Thu, 25 Jul 2024 09:18:50 GMT, Alexey Ivanov wrote: >> After I integrated >> [JDK-8326734](https://bugs.openjdk.org/browse/JDK-8326734), there's no way >> to remove text decoration from an HTML element. The most common HTML element >> is `` which is usually rendered _underlined_. You could

Re: RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags [v2]

2024-07-25 Thread Alexey Ivanov
On Thu, 25 Jul 2024 08:15:03 GMT, Abhishek Kumar wrote: >> Alexey Ivanov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Amend the bugid and summary in the test > > test/jdk/javax/swing/text/html/HTMLDocument/HTMLTextDecorationNone.java

Re: RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags [v2]

2024-07-25 Thread Alexey Ivanov
> After I integrated > [JDK-8326734](https://bugs.openjdk.org/browse/JDK-8326734), there's no way to > remove text decoration from an HTML element. The most common HTML element is > `` which is usually rendered _underlined_. You could add an inline style > or apply a rule with `text-decoration:

Re: RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags

2024-07-25 Thread Abhishek Kumar
On Wed, 24 Jul 2024 17:09:22 GMT, Alexey Ivanov wrote: > After I integrated > [JDK-8326734](https://bugs.openjdk.org/browse/JDK-8326734), there's no way to > remove text decoration from an HTML element. The most common HTML element is > `` which is usually rendered _underlined_. You could add