On Mon, 19 Aug 2024 05:16:09 GMT, Abhishek Kumar wrote:
> > Adding a test for this fix would be better, I guess...
>
> I don't think it is required as we have SwingSet2 demo to test.
It might be required to map a fix to a test, else only the fix exists...
-
PR Comment: htt
On Fri, 16 Aug 2024 11:53:15 GMT, Tejesh R wrote:
> open/test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java is failing
> intermittently on Linux (https://bugs.openjdk.org/browse/JDK-8338153). As
> part of analysis I've updated the test with image writing on failure
> condition.
This p
On Mon, 19 Aug 2024 06:20:13 GMT, Abhishek Kumar wrote:
>> mnemonics if gtk dialog were updated by the
>> https://bugs.openjdk.org/browse/JDK-8080628, the save button was not changes
>> since it is a default button in that dialog.
>
>> mnemonics if gtk dialog were updated by the
>> https://bug
On Fri, 16 Aug 2024 23:25:32 GMT, Sergey Bylokhov wrote:
> mnemonics if gtk dialog were updated by the
> https://bugs.openjdk.org/browse/JDK-8080628, the save button was not changes
> since it is a default button in that dialog.
Seems like the fix is to remove mnemonics for Metal Look and Feel
On Fri, 16 Aug 2024 12:15:44 GMT, Tejesh R wrote:
> Adding a test for this fix would be better, I guess...
I don't think it is required as we have SwingSet2 demo to test.
-
PR Comment: https://git.openjdk.org/jdk/pull/20612#issuecomment-2295687349
On Fri, 16 Aug 2024 10:00:22 GMT, Renjith Kannath Pariyangad
wrote:
>> Documentation updated
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Updated import
@Renjithkannath
Your change (at version 097976f04b
On Fri, 16 Aug 2024 23:36:46 GMT, Sergey Bylokhov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Stop the timer if frame is disabled
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI
> Issue is
> BasicScrollBarUI.ArrowButtonListener starts a timer in mousePressed(), and
> stops it in mouseReleased(). If the frame containing the scrollbar is
> disabled between the MOUSE_PRESSED and the MOUSE_RELEASED events, the
> mouseReleased() method is never called. If the frame is then r
On Sat, 17 Aug 2024 00:55:50 GMT, Sergey Bylokhov wrote:
>> ok..fixed..
>
> Look like is not fixed yet?
Spelling mistake "Tocuh" is fixed...Do you see more?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20289#discussion_r1721137908
On Fri, 16 Aug 2024 11:43:05 GMT, Alexey Ivanov wrote:
>> toshiogata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move jtreg tags and expand wildcard imports
>
> I suggest not to edit the files and only *rename them* as it was in the
On Fri, 16 Aug 2024 01:02:17 GMT, toshiogata wrote:
>> test/langtools/tools/javac/warnings/Serial/Serial.java line 1:
>>
>>> 1: /*
>>
>> move jtreg tags below imports and add copyrights
>
> The copyright has been intentionally omitted as explained in
> https://bugs.openjdk.org/browse/JDK-82585
On Fri, 16 Aug 2024 11:40:20 GMT, Alexey Ivanov wrote:
>> As you mentioned, it's a good time to make a minor improvement, so I
>> modified the test.
>
> I propose not to edit the renamed files.
>
> First of all, the purpose of this PR is to *rename tests* to workaround a
> _misfeature_ of jtre
> Rename the tests to prevent unexpected deletion of result files when
> `-retain` jtreg option is specified.
> Testing: modified tests
toshiogata has updated the pull request incrementally with one additional
commit since the last revision:
Revert "Move jtreg tags and expand wildcard imports
13 matches
Mail list logo
