On Mon, 19 Aug 2024 06:20:13 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> mnemonics if gtk dialog were updated by the >> https://bugs.openjdk.org/browse/JDK-8080628, the save button was not changes >> since it is a default button in that dialog. > >> mnemonics if gtk dialog were updated by the >> https://bugs.openjdk.org/browse/JDK-8080628, the save button was not changes >> since it is a default button in that dialog. > > Seems like the fix is to remove mnemonics for Metal Look and Feel. > Mnemonics for Open, Save and Cancel buttons are present on native side > (checked with gedit application on ubuntu 22.04). So, I think mnemonics for > Save button should also be there in GTK L&F. > Hmm, the `&S` is already used by > > ``` > FileChooser.pathLabel.textAndMnemonic=&Selection: > ``` > > It looks like that `&S` is more common for the save action, so probably we > might want to change the `&Selection:` to something else, e.g. `S&election:` > Any thoughts? Checked in native side and `&S` is the mnemonics for Save button. So, I think it's right to have `&S` as mnemonics for `Save` and as you suggested `&e` for `Selection`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20612#discussion_r1721265040
