On Fri, 30 Aug 2024 04:37:55 GMT, Alan Bateman wrote:
> I wonder if there should be JBS issues for the specific source files/warnings
> so they can be looked at more closely (or maybe you've looked at them all
> already). Just wondering about the maintainability of DISABLED_WARNINGS_xxx
> valu
On Thu, 29 Aug 2024 23:14:29 GMT, Sergey Bylokhov wrote:
> Have you checked what is the root cause? Are the pixels drawn incorrectly in
> the frame, or is the robot distorting the colors when it grabs the pixels?
The issue occurs intermittently/might be even host specific. It occurs when
Robot
On Thu, 29 Aug 2024 12:42:49 GMT, Alexey Ivanov wrote:
>>> > One slight concern is that, does GTKStockIcon has any role to play with
>>> > synchronized block?
>>>
>>> Sorry, I didn't understand what do you mean.
>>
>> I meant, since `ICONS_MAP` stores `GTKStockIcon` as value, I was wondering
> `static final Map ICONS_MAP` is modified only in
> `static` block. Then
> [com.sun.java.swing.plaf.gtk.GTKStyle#get](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java#L892)
> method read fr
On Thu, 29 Aug 2024 12:58:11 GMT, Alexey Ivanov wrote:
> I wonder whether the tolerance wouldn't be required if
> `Robot.createMultiResolutionScreenCapture` was used to create the screenshot
> and then analysing the original image which didn't go through down-scaling in
> High DPI environment.
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
On Thu, 29 Aug 2024 04:38:29 GMT, Tejesh R wrote:
> On analysis of captured image, it is observed that there are few pixels which
> vary slightly w.r.t to expected color. Hence tolerance is included in color
> comparison.
> Tested in mach5 multiple time and its green.
Have you checked what is
On Thu, 29 Aug 2024 21:34:18 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/ApplicationDelegate.m line
>> 128:
>>
>>> 126: [ThreadUtilities setApplicationOwner:NO];
>>> 127: return nil;
>>> 128: }
>>
>> If you flip the default, then you need
On Wed, 28 Aug 2024 16:43:49 GMT, Kevin Rushforth wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reattach thread if AWT is the owner of NSApplication
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/Appli
On Thu, 29 Aug 2024 18:44:22 GMT, Kim Barrett wrote:
>> Currently, we issue -Wno-unused for all files in clang, which is a rather
>> big sledgehammer to get rid of some warnings that proliferate in a few areas
>> of the build.
>>
>> We should instead leave -Wunused turned on (as done by -Wall)
This is a highly intermittent failure, it failed only once in CI on a
particular windows machine and passed on all other runs.
Failure reason:
When the button was displayed for the first time, the focus rectangle drawn on
the button text(Button A) was not seen(failure images attached in the bug
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
Filed [JDK-8339271](https://bugs.openjdk.org/browse/JDK-8339271)
-
PR Comment: https://git.openjdk.org/jdk/pull/18985#issuecomment-2318449266
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
I'm looking at this in backporting to 8u and this change seems odd:
~~~
-https://sourceforge.net/p/giflib/code/ci/master/tree/openbsd-reallocarray.c
+tree/README
~~~
Is it reall
On Wed, 28 Aug 2024 18:22:03 GMT, Sergey Bylokhov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reattach thread if AWT is the owner of NSApplication
>
> src/java.desktop/macosx/native/libosxapp/ThreadUtilit
On Thu, 29 Aug 2024 06:24:49 GMT, Prasanta Sadhukhan
wrote:
>> The testcase calls Platform.exit before the dialog is made visible but
>> on macOS, JavaFX takes over the AppKit thread and uses that as the FX
>> application thread. As part of the FX platform shutdown process, it detaches
>> that
On Thu, 29 Aug 2024 08:26:16 GMT, Magnus Ihse Bursie wrote:
> Okay. Unless I misunderstand something, there were no additional authors to
> be credited for these two commits.
That's correct for these.
-
PR Comment: https://git.openjdk.org/jdk/pull/20666#issuecomment-2317982354
Currently, we issue -Wno-unused for all files in clang, which is a rather big
sledgehammer to get rid of some warnings that proliferate in a few areas of the
build.
We should instead leave -Wunused turned on (as done by -Wall) and use a much
more fine-grained approach to disabling specific warn
On Thu, 29 Aug 2024 04:38:29 GMT, Tejesh R wrote:
> On analysis of captured image, it is observed that there are few pixels which
> vary slightly w.r.t to expected color. Hence tolerance is included in color
> comparison.
> Tested in mach5 multiple time and its green.
I wonder whether the tol
On Wed, 28 Aug 2024 08:54:39 GMT, Abhishek Kumar wrote:
> `static final Map ICONS_MAP` is modified only in
> `static` block. Then
> [com.sun.java.swing.plaf.gtk.GTKStyle#get](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/com/sun
On Thu, 29 Aug 2024 05:20:20 GMT, Tejesh R wrote:
> > > One slight concern is that, does GTKStockIcon has any role to play with
> > > synchronized block?
> >
> >
> > Sorry, I didn't understand what do you mean.
>
> I meant, since `ICONS_MAP` stores `GTKStockIcon` as value, I was wondering
>
On Thu, 29 Aug 2024 04:09:18 GMT, Abhishek Kumar wrote:
> > What's the benefit of removing synchronized from the get call?
>
> As I mentioned earlier, `ICONS_MAP` are initialized only in **static block**
> and after that it is just referenced to access the value out of it. Even
> though `ICONS
On Thu, 29 Aug 2024 05:26:47 GMT, Abhishek Kumar wrote:
> FWIW, Running tests on linux environment will test it on default MetalL&F
> which will not test this GTK path unless you specify GTK L&F in
> `swing.defaultlaf` to it
@prsadhuk Ran the tests with GTK Look and Feel option in CI and the t
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote:
>> As a preparation for Hermetic Java, we need to have a way to look up during
>> runtime if we are using a statically linked library or not.
>>
>> This change will be the first step needed towards compiling the object files
>> only o
On Thu, 29 Aug 2024 05:20:20 GMT, Tejesh R wrote:
> I meant, since `ICONS_MAP` stores `GTKStockIcon` as value, I was wondering
> does that make any difference or need for the map to be synchronized? I also
> came across Immutable Maps which are inherently thread safe. If ICONS_MAP are
> immuta
On Tue, 27 Aug 2024 20:04:21 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in gcc, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wall)
27 matches
Mail list logo
