On Sat, 31 May 2025 04:21:41 GMT, Sergey Bylokhov wrote:
>> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several
>> new methods to the ICC_Profile class:
>> - getProfileClass(byte[])
>> - getColorSpaceType(byte[])
>> - getPCSType(byte[])
>> - checkRenderingIntent(byte[
> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several
> new methods to the ICC_Profile class:
> - getProfileClass(byte[])
> - getColorSpaceType(byte[])
> - getPCSType(byte[])
> - checkRenderingIntent(byte[])
>
> These new methods extract data directly from the provided
On Wed, 28 May 2025 03:21:08 GMT, Prasanta Sadhukhan
wrote:
>> But we can read/save orientation, then call super, then make a check?
>> I am not sure how important to always call
>> super.setComponentOrientation(orientation);
>> can we miss some notification fired from that method?
>
> OK. Cur
Per discussion in JBS, adds the following chars to the list of ignorable
whitespace chars: U+000B (Vertical Tab), U+000C (Form Feed), U+0085 (Next
Line), U+2028 (Line Separator), U+2029 (Paragraph Separator).
Adds the necessary testing in pre-existing automated test class
`test/jdk/java/awt/fon
> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several
> new methods to the ICC_Profile class:
> - getProfileClass(byte[])
> - getColorSpaceType(byte[])
> - getPCSType(byte[])
> - checkRenderingIntent(byte[])
>
> These new methods extract data directly from the provided
On Fri, 30 May 2025 23:56:35 GMT, Harshitha Onkar wrote:
>I hadn't noticed it earlier but icAbsoluteColorimetric and
>icICCAbsoluteColorimetric point to the same intent. Is it good to unify them
>into a single constant in src code during clean up (separate issue)?
At some point, that constants
On Fri, 30 May 2025 00:31:55 GMT, Harshitha Onkar wrote:
> Added back Toolkit.sync() and canvas capture to paint method. Although I'm
> not sure if I understood _"each render frame"_ correctly. Can you please
> explain?
The paint method may be invoked multiple times after the frame becomes vis
On Fri, 30 May 2025 11:20:39 GMT, Roman Marchenko
wrote:
>> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
>> `Introspector.addMethod()` working properly when filtering methods out.
>>
>> Also, after PR discussion, added the approptiate test cases with
>> corresponding fixes
On Fri, 30 May 2025 04:11:36 GMT, Sergey Bylokhov wrote:
> The patch for [JDK-8357299](https://bugs.openjdk.org/browse/JDK-8357299) does
> not completely fix the regression it was intended to address. Instead of
> bailing out on overflow, it introduces additional logic around src and clip,
> w
On Thu, 29 May 2025 10:22:39 GMT, Sergey Bylokhov wrote:
> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several
> new methods to the ICC_Profile class:
> - getProfileClass(byte[])
> - getColorSpaceType(byte[])
> - getPCSType(byte[])
> - checkRenderingIntent(byte[])
>
On Sat, 17 May 2025 07:42:59 GMT, Andrey Turbanov wrote:
> Instead of separate List.get+List.remove calls we can use single
> `removeFirst`. It's clearer.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25283#pullrequestreview-2881430115
On Thu, 22 May 2025 20:44:30 GMT, Nikita Gubarkov wrote:
>> J2dTrace macros have multiple overloads specifying number of arguments,
>> making it less convent to change number of arguments. There were cases when
>> existing macros were not enough and people had to add new variants with even
>>
On Fri, 30 May 2025 10:59:17 GMT, Volkan Yazici wrote:
> Passes the `Charset` read from the `stdin.encoding` system property while
> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>
> `stdin.encoding` is a recently added property for Java 25 in
> [JDK-8350703](https://bug
On Fri, 30 May 2025 00:40:11 GMT, Harshitha Onkar wrote:
>> CopyAreaOOB.java was failing intermittently on some platforms on CI but
>> recently it started to fail more frequently on macos-aarch64 when the entire
>> test suite runs.
>>
>> Test failure is not reproducible when the test is run in
On Thu, 3 Apr 2025 11:23:42 GMT, Daniel Gredler wrote:
> It looks like this regression actually fits into a longer series of fixes /
> regressions in this area:
>
> - [JDK-4517298](https://bugs.openjdk.org/browse/JDK-4517298) fixed metrics
> for zero-width characters, but broke some ligatures
On Thu, 29 May 2025 11:10:38 GMT, Daniel Gredler wrote:
>> It looks like this regression actually fits into a longer series of fixes /
>> regressions in this area:
>>
>> - [JDK-4517298](https://bugs.openjdk.org/browse/JDK-4517298) fixed metrics
>> for zero-width characters, but broke some liga
On Fri, 9 May 2025 13:05:40 GMT, Khalid Boulanouare wrote:
>> Fixes issue in which the test fails when run on multi-screen machine.
>>
>> Tested on Ubuntu 24.04, MacOS 15 and Windows 11
>>
>> JTREG
>>
>> runner starting test: java/awt/Frame/MultiScreenTest.java
>> runner finished test: java/aw
On Thu, 29 May 2025 11:10:38 GMT, Daniel Gredler wrote:
>> It looks like this regression actually fits into a longer series of fixes /
>> regressions in this area:
>>
>> - [JDK-4517298](https://bugs.openjdk.org/browse/JDK-4517298) fixed metrics
>> for zero-width characters, but broke some liga
On Tue, 27 May 2025 17:35:17 GMT, Alisen Chung wrote:
>> Currently on macOS when mouseMove is given an offscreen coordinate to move
>> the mouse to, mouseMove will physically clamp to the edge of the screen, but
>> if you try to grab the mouse location immediately after by using
>> MouseInfo.g
On Fri, 30 May 2025 16:49:46 GMT, Harshitha Onkar wrote:
>> @prrace This is ready for review again. I've updated the code to combine
>> nicely with the recent whitespace fixes. The `test/jdk/java/awt/font`,
>> `test/jdk/java/awt/print` and `test/jdk/java/awt/Graphics2D/DrawString`
>> tests all
> Make sure AquaTextPasswordFieldUI can't use selectWordAction.
>
> The core problem here was we could call selectWordAction in the Aqua LAF on a
> JPasswordField. This problem was already solved in the BasicPasswordFieldUI,
> but the AquaTextPasswordFieldUI (and SynthPasswordFieldUI) do NOT ext
On Fri, 30 May 2025 10:03:56 GMT, Tejesh R wrote:
> Since the fix has been made in Basic, we should not restrict the test to Aqua
> L&F alone. It should be tested for all L&F. (For fix and for regression)
OK, this is updated.
Since this is now meant to cover/discuss Basic L&F, I updated the te
> Make sure AquaTextPasswordFieldUI can't use selectWordAction.
>
> The core problem here was we could call selectWordAction in the Aqua LAF on a
> JPasswordField. This problem was already solved in the BasicPasswordFieldUI,
> but the AquaTextPasswordFieldUI (and SynthPasswordFieldUI) do NOT ext
On Wed, 28 May 2025 20:25:23 GMT, Daniel Gredler wrote:
>>> @prrace Please don't approve yet. I was able to fix the code conflicts
>>> caused by PR #23665, but it looks like the logic does not layer nicely as
>>> there is now a test failure on macOS after the merge. I'm having a look and
>>> w
> Make sure AquaTextPasswordFieldUI can't use selectWordAction.
>
> The core problem here was we could call selectWordAction in the Aqua LAF on a
> JPasswordField. This problem was already solved in the BasicPasswordFieldUI,
> but the AquaTextPasswordFieldUI (and SynthPasswordFieldUI) do NOT ext
On Wed, 28 May 2025 10:29:17 GMT, GennadiyKrivoshein wrote:
> The fix for the https://bugs.openjdk.org/browse/JDK-8251928.
>
> **Description**.
> This PR contains changes to be able to print with DPI higher than 72 on
> macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob.
>
> As
> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
> `Introspector.addMethod()` working properly when filtering methods out.
>
> Also, after PR discussion, added the approptiate test cases with
> corresponding fixes in MethodInfo.java and PropertyInfo.java.
>
> -
> `getMe
On Fri, 30 May 2025 06:40:40 GMT, Prasanta Sadhukhan
wrote:
>> The fix for the https://bugs.openjdk.org/browse/JDK-8251928.
>>
>> **Description**.
>> This PR contains changes to be able to print with DPI higher than 72 on
>> macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob.
>
On Mon, 26 May 2025 16:38:21 GMT, Alexey Ivanov wrote:
> Currently, the default headless message ends with a comma instead of full
> stop and has an additional line break.
>
>
> Exception in thread "AWT-EventQueue-0" java.awt.HeadlessException:
> No X11 DISPLAY variable was set,
> or no headfu
> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
> `Introspector.addMethod()` working properly when filtering methods out.
>
> Also, after PR discussion, added the approptiate test cases with
> corresponding fixes in MethodInfo.java and PropertyInfo.java.
>
> -
> `getMe
On Mon, 14 Apr 2025 13:28:09 GMT, Alexey Ivanov wrote:
>> I ran this changes through CI testing, and the results are good.
>
>> I do not have any other comments, @aivanov-jdk please take a look.
>>
>> @aivanov-jdk …\
>> Could you review the PR, please?
>
> I'm currently busy, I'll get to look a
Passes the `Charset` read from the `stdin.encoding` system property while
creating `InputStreamReader` or `Scanner` instances for `System.in`.
`stdin.encoding` is a recently added property for Java 25 in
[JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it
throughout the ent
On Tue, 27 May 2025 17:38:32 GMT, Sergey Bylokhov wrote:
>> The issue was found here:
>> https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502
>>
>> AWTEventListener and AWTEventListenerProxy are public classes and there's no
>> assertion that EventListenerProxy.getListener() will a
On Fri, 30 May 2025 09:52:21 GMT, Tejesh R wrote:
>> Sergey Bylokhov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update
>> test/jdk/java/awt/Toolkit/AWTEventListenerProxyTest/AWTEventListenerProxyTest.java
>>
>> Co-authored-by:
On Mon, 26 May 2025 16:51:11 GMT, Jeremy Wood wrote:
>> Make sure AquaTextPasswordFieldUI can't use selectWordAction.
>>
>> The core problem here was we could call selectWordAction in the Aqua LAF on
>> a JPasswordField. This problem was already solved in the
>> BasicPasswordFieldUI, but the A
On Mon, 26 May 2025 16:51:11 GMT, Jeremy Wood wrote:
>> Make sure AquaTextPasswordFieldUI can't use selectWordAction.
>>
>> The core problem here was we could call selectWordAction in the Aqua LAF on
>> a JPasswordField. This problem was already solved in the
>> BasicPasswordFieldUI, but the A
On Tue, 27 May 2025 17:38:32 GMT, Sergey Bylokhov wrote:
>> The issue was found here:
>> https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502
>>
>> AWTEventListener and AWTEventListenerProxy are public classes and there's no
>> assertion that EventListenerProxy.getListener() will a
On Tue, 27 May 2025 17:38:32 GMT, Sergey Bylokhov wrote:
>> The issue was found here:
>> https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502
>>
>> AWTEventListener and AWTEventListenerProxy are public classes and there's no
>> assertion that EventListenerProxy.getListener() will a
38 matches
Mail list logo
