Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v9]

2025-06-05 Thread Jeremy Wood
On Fri, 6 Jun 2025 03:20:19 GMT, Prasanta Sadhukhan wrote: >> Jeremy Wood has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/JDK-8354646' into JDK-8354646 >> - 8354646: make UnsupportedLookAndFeelExc

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v8]

2025-06-05 Thread Jeremy Wood
On Fri, 6 Jun 2025 03:18:15 GMT, Prasanta Sadhukhan wrote: >> This is updated. (I have no preference on the behavior regarding >> UnsupportedLookAndFeelExceptions; this was copied and pasted from other test >> files.) > > I guess I am for not treating UnsupportedLookAndFeelException as an erro

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v10]

2025-06-05 Thread Jeremy Wood
On Fri, 6 Jun 2025 03:25:20 GMT, Prasanta Sadhukhan wrote: >> Jeremy Wood has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - 8354646: skip L&F for UnsupportedLookAndFeelException >> >>This is in response to: >>https://githu

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v9]

2025-06-05 Thread Jeremy Wood
On Fri, 6 Jun 2025 03:21:47 GMT, Prasanta Sadhukhan wrote: >> Jeremy Wood has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/JDK-8354646' into JDK-8354646 >> - 8354646: make UnsupportedLookAndFeelExc

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v10]

2025-06-05 Thread Jeremy Wood
> Make sure AquaTextPasswordFieldUI can't use selectWordAction. > > The core problem here was we could call selectWordAction in the Aqua LAF on a > JPasswordField. This problem was already solved in the BasicPasswordFieldUI > and SynthPasswordFieldUI, but the AquaTextPasswordFieldUI does NOT ext

Re: RFR: 8358623: Avoid unnecessary data copying in ICC_Profile

2025-06-05 Thread Sergey Bylokhov
On Wed, 4 Jun 2025 23:39:05 GMT, Sergey Bylokhov wrote: > This PR simplifies several aspects of the ICC_Profile class: > > - [Change > 1](https://github.com/openjdk/jdk/pull/25650/commits/426a608b1df9e39e221d05e7374a3fecf6e6cf30): > The ICC_Profile.getInstance(byte[] data) method used to co

Re: RFR: 8358623: Avoid unnecessary data copying in ICC_Profile

2025-06-05 Thread Sergey Bylokhov
On Thu, 5 Jun 2025 23:44:18 GMT, Sergey Bylokhov wrote: >> This PR simplifies several aspects of the ICC_Profile class: >> >> - [Change >> 1](https://github.com/openjdk/jdk/pull/25650/commits/426a608b1df9e39e221d05e7374a3fecf6e6cf30): >> The ICC_Profile.getInstance(byte[] data) method used

RFR: 8358623: Avoid unnecessary data copying in ICC_Profile

2025-06-05 Thread Sergey Bylokhov
This PR simplifies several aspects of the ICC_Profile class: - [Change 1](https://github.com/openjdk/jdk/pull/25650/commits/426a608b1df9e39e221d05e7374a3fecf6e6cf30): The ICC_Profile.getInstance(byte[] data) method used to copy the profile header for validation. This copy appears redundant,

Re: RFR: 8353950: Clipboard interaction on Windows is unstable [v6]

2025-06-05 Thread Abhishek Kumar
On Wed, 4 Jun 2025 17:14:15 GMT, Matthias Bläsing wrote: >> - Introduce a lock into WClipboard that protects the code between >> openClipboard/closeClipboard invocations. >> The native side does not allow to open the clipboard multiple >> times or share the opened clipboard between multiple

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v9]

2025-06-05 Thread Prasanta Sadhukhan
On Thu, 5 Jun 2025 16:56:50 GMT, Jeremy Wood wrote: >> Make sure AquaTextPasswordFieldUI can't use selectWordAction. >> >> The core problem here was we could call selectWordAction in the Aqua LAF on >> a JPasswordField. This problem was already solved in the >> BasicPasswordFieldUI and SynthPa

RFR: 8055461: getNextID in ImageIcon class can lead to overflow

2025-06-05 Thread Prasanta Sadhukhan
ImageIcon.getNextID uses `mediaTrackerID ` which do not detect overflow. Theoretically there is a possibility that there can be overflow in the long time run or for large number of created "imageIcon" Made sure there is no overflow and treat that loadImage as ABORTED No regression testcase as i

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v9]

2025-06-05 Thread Prasanta Sadhukhan
On Thu, 5 Jun 2025 16:56:50 GMT, Jeremy Wood wrote: >> Make sure AquaTextPasswordFieldUI can't use selectWordAction. >> >> The core problem here was we could call selectWordAction in the Aqua LAF on >> a JPasswordField. This problem was already solved in the >> BasicPasswordFieldUI and SynthPa

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v8]

2025-06-05 Thread Prasanta Sadhukhan
On Thu, 5 Jun 2025 16:53:37 GMT, Jeremy Wood wrote: >> Many tests do this kind of thing… the worse thing that happen is that the >> test code is run again where it's not required. >> >> I'm pretty sure `UnsupportedLookAndFeelException` is a rare situation, and >> it shouldn't happen for Look a

Re: Security Concern: JPasswordField Revealing Passwords in Memory

2025-06-05 Thread Jeremy Wood
Should this be written up at https://bugreport.java.com/bugreport/ , or does it deserve special treatment as a security vulnerability (and if so, what is that protocol)? I was unable to review the document without an ibm account, so I can’t comment further on the problem or any potential resol

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java fails: Window list is empty [v11]

2025-06-05 Thread Alexey Ivanov
On Thu, 5 Jun 2025 22:42:52 GMT, Alexey Ivanov wrote: >> Khalid Boulanouare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adds extra blank lines > > test/jdk/java/awt/Frame/MultiScreenTest.java line 499: > >> 497: } >> 498: } >> 4

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java fails: Window list is empty [v11]

2025-06-05 Thread Alexey Ivanov
On Thu, 5 Jun 2025 17:23:09 GMT, Khalid Boulanouare wrote: >> Fixes issue in which the test fails when run on multi-screen machine. >> >> Tested on Ubuntu 24.04, MacOS 15 and Windows 11 >> >> JTREG >> >> runner starting test: java/awt/Frame/MultiScreenTest.java >> runner finished test: java/aw

Re: RFR: 8355904: Use variadic macros for J2dTrace [v6]

2025-06-05 Thread Alexey Ivanov
On Thu, 22 May 2025 20:44:30 GMT, Nikita Gubarkov wrote: >> J2dTrace macros have multiple overloads specifying number of arguments, >> making it less convent to change number of arguments. There were cases when >> existing macros were not enough and people had to add new variants with even >>

Integrated: 8357688: Remove unnecessary List.get before remove in PopupFactory

2025-06-05 Thread Andrey Turbanov
On Sat, 17 May 2025 07:42:59 GMT, Andrey Turbanov wrote: > Instead of separate List.get+List.remove calls we can use single > `removeFirst`. It's clearer. This pull request has now been integrated. Changeset: 15178aa2 Author:Andrey Turbanov URL: https://git.openjdk.org/jdk/commit/1

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java fails: Window list is empty [v11]

2025-06-05 Thread Khalid Boulanouare
> Fixes issue in which the test fails when run on multi-screen machine. > > Tested on Ubuntu 24.04, MacOS 15 and Windows 11 > > JTREG > > runner starting test: java/awt/Frame/MultiScreenTest.java > runner finished test: java/awt/Frame/MultiScreenTest.java > Passed. Execution successful Khalid B

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java fails: Window list is empty [v10]

2025-06-05 Thread Khalid Boulanouare
On Thu, 5 Jun 2025 17:05:34 GMT, Alexey Ivanov wrote: >> Khalid Boulanouare has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Nests classes inside test class >> - Cleans up code > > test/jdk/java/awt/Frame/MultiScreenTest.java line 134:

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java fails: Window list is empty [v10]

2025-06-05 Thread Khalid Boulanouare
On Thu, 5 Jun 2025 09:35:16 GMT, Khalid Boulanouare wrote: >> Fixes issue in which the test fails when run on multi-screen machine. >> >> Tested on Ubuntu 24.04, MacOS 15 and Windows 11 >> >> JTREG >> >> runner starting test: java/awt/Frame/MultiScreenTest.java >> runner finished test: java/aw

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v10]

2025-06-05 Thread Alexey Ivanov
On Thu, 5 Jun 2025 09:35:16 GMT, Khalid Boulanouare wrote: >> Fixes issue in which the test fails when run on multi-screen machine. >> >> Tested on Ubuntu 24.04, MacOS 15 and Windows 11 >> >> JTREG >> >> runner starting test: java/awt/Frame/MultiScreenTest.java >> runner finished test: java/aw

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v8]

2025-06-05 Thread Jeremy Wood
On Thu, 5 Jun 2025 12:53:01 GMT, Alexey Ivanov wrote: >> test/jdk/javax/swing/plaf/basic/BasicPasswordFieldUI/PasswordSelectionWordTest.java >> line 52: >> >>> 50: UIManager.getInstalledLookAndFeels()) { >>> 51: System.out.println("Testing LAF: " + laf.getClassName()

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v9]

2025-06-05 Thread Jeremy Wood
> Make sure AquaTextPasswordFieldUI can't use selectWordAction. > > The core problem here was we could call selectWordAction in the Aqua LAF on a > JPasswordField. This problem was already solved in the BasicPasswordFieldUI > and SynthPasswordFieldUI, but the AquaTextPasswordFieldUI does NOT ext

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v8]

2025-06-05 Thread Alexey Ivanov
On Thu, 5 Jun 2025 12:46:01 GMT, Prasanta Sadhukhan wrote: >> Jeremy Wood has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update >> test/jdk/javax/swing/plaf/basic/BasicPasswordFieldUI/PasswordSelectionWordTest.java >> >> Co-autho

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v8]

2025-06-05 Thread Prasanta Sadhukhan
On Wed, 4 Jun 2025 21:09:37 GMT, Jeremy Wood wrote: >> Make sure AquaTextPasswordFieldUI can't use selectWordAction. >> >> The core problem here was we could call selectWordAction in the Aqua LAF on >> a JPasswordField. This problem was already solved in the >> BasicPasswordFieldUI and SynthPa

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v2]

2025-06-05 Thread Khalid Boulanouare
On Wed, 30 Apr 2025 17:21:21 GMT, Alexey Ivanov wrote: >>> #21942 >> >> Thanks @aivanov-jdk for suggesting the correct route. >> >> @kboulanou Please modify the test to run for all platforms and you can limit >> the number of graphics configuration to 10 for linux. > >> @kumarabhi006 I am awar

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v10]

2025-06-05 Thread Khalid Boulanouare
> Fixes issue in which the test fails when run on multi-screen machine. > > Tested on Ubuntu 24.04, MacOS 15 and Windows 11 > > JTREG > > runner starting test: java/awt/Frame/MultiScreenTest.java > runner finished test: java/awt/Frame/MultiScreenTest.java > Passed. Execution successful Khalid B

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v8]

2025-06-05 Thread Khalid Boulanouare
On Wed, 4 Jun 2025 18:43:14 GMT, Alexey Ivanov wrote: >> Khalid Boulanouare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removes unnecessary lines and keep consistent code format > > test/jdk/java/awt/Frame/MultiScreenTest.java line 1

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v8]

2025-06-05 Thread Khalid Boulanouare
On Wed, 4 Jun 2025 19:06:57 GMT, Alexey Ivanov wrote: >> Khalid Boulanouare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removes unnecessary lines and keep consistent code format > > test/jdk/java/awt/Frame/MultiScreenTest.java line 9

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v8]

2025-06-05 Thread Khalid Boulanouare
On Wed, 4 Jun 2025 18:37:02 GMT, Alexey Ivanov wrote: >> Khalid Boulanouare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removes unnecessary lines and keep consistent code format > > test/jdk/java/awt/Frame/MultiScreenTest.java line 1

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v9]

2025-06-05 Thread Khalid Boulanouare
> Fixes issue in which the test fails when run on multi-screen machine. > > Tested on Ubuntu 24.04, MacOS 15 and Windows 11 > > JTREG > > runner starting test: java/awt/Frame/MultiScreenTest.java > runner finished test: java/awt/Frame/MultiScreenTest.java > Passed. Execution successful Khalid B