On Thu, 5 Jun 2025 16:53:37 GMT, Jeremy Wood <d...@openjdk.org> wrote:
>> Many tests do this kind of thing… the worse thing that happen is that the >> test code is run again where it's not required. >> >> I'm pretty sure `UnsupportedLookAndFeelException` is a rare situation, and >> it shouldn't happen for Look and Feels provided by JDK. >> >> Shall we treat `UnsupportedLookAndFeelException` as an error and see how it >> goes? This will makes the code simpler. If it's ever encountered and proved >> to be a common case, the test will need updating. Otherwise, I'm for keeping >> it as simple as possible. > > This is updated. (I have no preference on the behavior regarding > UnsupportedLookAndFeelExceptions; this was copied and pasted from other test > files.) I guess I am for not treating UnsupportedLookAndFeelException as an error. It will cause the test to stop executing the next L&F if there is one in the list after the unsupported L&F. I have seen this exception in CI testing for GTK L&F but I guess it's for headless environment so I agree it's rare and will not happen in normal case..I was just thinking why to cause unnecessary execution..It maynot matter much for this test but for tests which uses Robot and has delay/waitForIdle executing already run L&F because of UnsupportedException will cause additional cycle. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25443#discussion_r2131429289
