On Mon, 30 Jun 2025 13:21:24 GMT, Alexey Ivanov wrote:
>> As I said, I didn't look deeply into the details.
>>
>> The menu layout already implements a 5-column layout — this is what I expect
>> because both Metal and Nimbus look exactly like a 5-column layout. Yet
>> Windows L&F is still off,
> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is
> shown without radiobutton in WIndowsLookAndFeel as there was no provision of
> drawing the radiobutton alongside icon.
> If icon is not there, the radiobutton is drawn. Added provision of drawing
> the radiobutton win
On Thu, 3 Jul 2025 22:11:09 GMT, Phil Race wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update javadoc
>> - Update javadoc
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line
> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording
> "Due to an unfortunate set of historical events this method is
> inappropriately named".
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Update ja
On Thu, 3 Jul 2025 21:50:40 GMT, Phil Race wrote:
> Current javac doesn't support 7 as a target so it seems reasonable to me.
That's why the makefile was parameterized, to easily set the target and source
options based on the currently used minimal supported version of javac. But we
may change
> This PR simplifies several aspects of the ICC_Profile class:
>
> - [Change
> 1](https://github.com/openjdk/jdk/pull/25650/commits/426a608b1df9e39e221d05e7374a3fecf6e6cf30):
> The ICC_Profile.getInstance(byte[] data) method used to copy the profile
> header for validation. This copy appears
On Tue, 17 Jun 2025 16:47:05 GMT, Harshitha Onkar wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove ER from remaining modal test
>
> test/jdk/java/awt/TrayIcon/TrayIconPopup/TrayIconPopupTest.java line 56:
>
On Thu, 3 Jul 2025 15:55:23 GMT, Alisen Chung wrote:
>> Some useful methods in ExtendedRobot should be migrated into Robot itself so
>> that ExtendedRobot can be removed in the future. The tests using
>> ExtendedRobot for these migrated methods are changed to use only Robot
>> (removing unnece
On Thu, 3 Jul 2025 22:27:24 GMT, Phil Race wrote:
>> Sergey Bylokhov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> theHeader -> data
>
> This looks OK to me. I see @honkar-jdk says CI testing has already been done.
@prrace
> I see @
On Fri, 13 Jun 2025 20:24:49 GMT, Sergey Bylokhov wrote:
>> This PR simplifies several aspects of the ICC_Profile class:
>>
>> - [Change
>> 1](https://github.com/openjdk/jdk/pull/25650/commits/426a608b1df9e39e221d05e7374a3fecf6e6cf30):
>> The ICC_Profile.getInstance(byte[] data) method used
On Tue, 1 Jul 2025 04:57:05 GMT, Manukumar V S wrote:
> Issue:
> javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of
> RuntimeException whenever a test failure occurs.
> This causes unnecessary extra attention in CI systems and triggers task
> failures as throwing an Err
On Fri, 13 Jun 2025 20:24:49 GMT, Sergey Bylokhov wrote:
>> This PR simplifies several aspects of the ICC_Profile class:
>>
>> - [Change
>> 1](https://github.com/openjdk/jdk/pull/25650/commits/426a608b1df9e39e221d05e7374a3fecf6e6cf30):
>> The ICC_Profile.getInstance(byte[] data) method used
On Wed, 25 Jun 2025 12:15:54 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording
>> "Due to an unfortunate set of historical events this method is
>> inappropriately named".
>
> Prasanta Sadhukhan has updated the pull request incrementa
On Wed, 25 Jun 2025 07:03:33 GMT, Dmitry Kulikov wrote:
>> Added an on-demand installation of the native OpenURL event handler to the
>> `Application.setOpenURIHandler()`.
>>
>> This does not break the specification for the affected API, since the
>> requirement of the application being bundle
On Thu, 3 Jul 2025 21:09:54 GMT, Sergey Bylokhov wrote:
> I think we can just drop ant and leave the makefile as it is. The
> source/target settings are set to that low level to indicate that the source
> code should be compatible with older versions of the JDK. Currently, JDK 1.4
> compatibil
On Thu, 3 Jul 2025 19:59:26 GMT, Eric Caspole wrote:
>> src/demo/share/java2d/J2DBench/build.xml line 42:
>>
>>> 40:
>>> 41:
>>> 42:
>>
>> This would be inconsistent with the Make target. It doesn't seem right to
>> update just the ant-based target.
>
> Yes I realized that yesterday, I
On Tue, 24 Jun 2025 12:11:52 GMT, Prasanta Sadhukhan
wrote:
>> There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead
>> in Aqua LAF which updates
>> [LEAD_SELECTION_PATH_PROPERTY](https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/swing/JTree.html#LEAD_
On Thu, 3 Jul 2025 19:30:40 GMT, Phil Race wrote:
>> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a
>> different javac from the PATH.
>
> src/demo/share/java2d/J2DBench/build.xml line 42:
>
>> 40:
>> 41:
>> 42:
>
> This would be inconsistent with the Make targe
On Tue, 1 Jul 2025 17:38:35 GMT, Eric Caspole wrote:
> As mentioned in the bug, I think it would be better to always emit the score
> as decimal instead of sometimes decimal, sometimes scientific notation.
This pull request has now been integrated.
Changeset: dcc7254a
Author:Eric Caspole
On Tue, 1 Jul 2025 04:57:05 GMT, Manukumar V S wrote:
> Issue:
> javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of
> RuntimeException whenever a test failure occurs.
> This causes unnecessary extra attention in CI systems and triggers task
> failures as throwing an Err
On Tue, 1 Jul 2025 04:57:05 GMT, Manukumar V S wrote:
> Issue:
> javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of
> RuntimeException whenever a test failure occurs.
> This causes unnecessary extra attention in CI systems and triggers task
> failures as throwing an Err
On Wed, 2 Jul 2025 18:56:33 GMT, Eric Caspole wrote:
>> As mentioned in the bug, I think it would be better to always emit the score
>> as decimal instead of sometimes decimal, sometimes scientific notation.
>
> Eric Caspole has updated the pull request incrementally with one additional
> commi
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote:
> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a
> different javac from the PATH.
src/demo/share/java2d/J2DBench/build.xml line 42:
> 40:
> 41:
> 42:
This would be inconsistent with the Make target. It doesn
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote:
> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a
> different javac from the PATH.
and don't get confused about the ant and make stuff. The JDK build does not and
is not expected to build j2dbench
It is built directl
On Thu, 3 Jul 2025 16:02:05 GMT, Magnus Ihse Bursie wrote:
> They have not been updated since jdk8 and are unlikely to be.
not true. They are updated regularly and I expect an enhancement to add some
new feature testing some time in the next year.
-
PR Comment: https://git.openjdk
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote:
> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a
> different javac from the PATH.
It isn't a demo and it isn't a jtreg test.
Everything under src/share/demo is client related which may be why it is there.
But the ri
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote:
> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a
> different javac from the PATH.
Could we move J2DBench under test next to micro/ ? It's not a demo, it's a
benchmark but somehow it ended up under demos. It should r
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote:
> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a
> different javac from the PATH.
The long-term goal is to remove demos from mainline. Most have already been
removed. The few that remains was used for client testing
> Some useful methods in ExtendedRobot should be migrated into Robot itself so
> that ExtendedRobot can be removed in the future. The tests using
> ExtendedRobot for these migrated methods are changed to use only Robot
> (removing unnecessary building of ExtendedRobot).
Alisen Chung has updated
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote:
> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a
> different javac from the PATH.
I dont know the history of J2DBench or how its build was developed. It looks
like J2DBench is not included in the JDK demos build. My
On Fri, 27 Jun 2025 18:11:46 GMT, Rajat Mahajan wrote:
> Modified the code to account for border thickness correctly and updated the
> related tests to make sure we are testing the new change.
>
> Testing done.
This pull request has now been integrated.
Changeset: 24117c6e
Author:Rajat Ma
On Fri, 27 Jun 2025 19:46:56 GMT, Rajat Mahajan wrote:
>> Modified the code to account for border thickness correctly and updated the
>> related tests to make sure we are testing the new change.
>>
>> Testing done.
>
> Rajat Mahajan has updated the pull request incrementally with one additional
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote:
> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a
> different javac from the PATH.
Where, how and why are this antscript or the
`src/demo/share/java2d/J2DBench/Makefile` used?
The JDK build system builds the demos
On Thu, 3 Jul 2025 06:46:25 GMT, Prasanta Sadhukhan
wrote:
> > Both image and description are two independent fields of ImageIcon object,
> > each has its own getter and setter, and each can be changed independently.
> > We should not enforce the order of calls: if an app developer wants to se
On Thu, 3 Jul 2025 08:38:51 GMT, ExE Boss wrote:
> Yes, but it complicates backports.
Yes, it complicates backports, but this implies backports are possible. If the
specification is updated, the backports will likely be impossible.
-
PR Review Comment: https://git.openjdk.org/jdk/
On Fri, 20 Jun 2025 11:55:35 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove resetting description from constructor as it is already null
>
> src/java.desktop/share/classes/javax/swi
On Wed, 2 Jul 2025 19:38:11 GMT, Alexey Ivanov wrote:
>> I haven't done my due diligence to verify whether this feature can be used.
>> Even if this particular way can't be used, it's still a viable option, just
>> move the code above into a helper method.
>>
>>
>> public ImageIcon(Image
37 matches
Mail list logo
