> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
instruction string change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18316/files
- new: ht
> Removing applet usage from manual JFileChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
change to automatic test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18415/files
- new: ht
On Mon, 18 Mar 2024 20:07:50 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: 78d1b904
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/78d1b9046830198cd61c505f04f245a430878a5b
St
> Removing applet usage from manual JFileChooser tests
> The original test is failing (nothing shows up in the JFileChooser), but this
> change does replace the applet usage with PassFailJFrame
Alisen Chung has updated the pull request incrementally with one additional
commit since
> Removing applet usage from manual JFileChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
force fail
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18415/files
- new: https://git.openjdk.org/
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
test instructions
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18369/files
- new: https://git.openjdk.
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fix line length and frame title
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18359/files
- new: ht
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
change font
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18316/files
- new: https://git.openjdk.org/
On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen wrote:
>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to
>> main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
On Thu, 21 Mar 2024 16:11:44 GMT, Damon Nguyen wrote:
>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
>> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
>> no longer an applet. Added test instructions related to the linked JBS issue.
>
> D
Removing applet usage from manual JFileChooser tests
The original test is failing (nothing shows up in the JFileChooser), but this
change does replace the applet usage with PassFailJFrame
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18456/files
Webre
On Thu, 21 Mar 2024 20:17:46 GMT, Harshitha Onkar wrote:
>> Following test is converted from applet to main using PassFailJFrame.
>>
>> The original test had ignore tag - **The fix for this problem was backed out
>> for 5057184. Remove this "ignore" tag when it is fixed again.**
>> I believe t
On Thu, 21 Mar 2024 18:15:23 GMT, Alisen Chung wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove .html from the @test clause
>
> test/jdk/java/awt/FileDialog/FileDialogRetur
On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev wrote:
>> Convert test to a main method based;
>> Move test to an apropriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove .html fro
On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev wrote:
>> Convert test to a main method based;
>> Move test to an apropriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove .html fro
On Thu, 21 Mar 2024 17:52:34 GMT, Harshitha Onkar wrote:
>> Following test is converted from applet to main using PassFailJFrame.
>>
>> The original test had ignore tag - **The fix for this problem was backed out
>> for 5057184. Remove this "ignore" tag when it is fixed again.**
>> I believe t
Removing applet usage from manual JFileChooser tests
-
Commit messages:
- remove extra dialog
- init commit
Changes: https://git.openjdk.org/jdk/pull/18415/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328648
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
spacing
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18369/files
- new: https://git.openjdk.org/jdk/p
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
text block instructions
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18316/files
- new: ht
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18369/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328403
Stats: 57 lines in 2
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- remove html
- init commit
Changes: https://git.openjdk.org/jdk/pull/18359/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18359&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328380
Stats:
On Fri, 1 Mar 2024 22:49:25 GMT, Alisen Chung wrote:
> Introduce delays in test to stabilize. Test passes 50x after fix.
This pull request has now been integrated.
Changeset: 3f2e849c
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/com
On Fri, 15 Mar 2024 00:41:21 GMT, Harshitha Onkar wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove middle copyright year, update spacings and jtreg summary
>
> test/jdk/javax/s
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove middle copyright year, update spacings and jtreg summary
-
Changes:
- all: https://git.openjdk.org/
On Thu, 14 Mar 2024 23:36:13 GMT, Alisen Chung wrote:
> Adding comma to copyright years
This pull request has now been integrated.
Changeset: e8d1ba33
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/e8d1ba33b48dc8e6b937258c3765b91426c5b6f1
Stats: 4 lines in 4 fi
> Adding comma to copyright years
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove middle copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18317/files
- new: https://git.openjdk.org/jdk/p
Adding comma to copyright years
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18317/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18317&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328228
Stats: 4 lines in 4 files changed: 0 ins; 0
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18316/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328227
Stats: 66 lines in 2
On Wed, 13 Mar 2024 20:57:42 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: be1dd275
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/be1dd275a4b4fcae00e4c3c48b3e8e4b1d84ba2b
St
On Wed, 13 Mar 2024 19:26:15 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: fab0edc9
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/fab0edc9e636c69d7012e476e97661ddae993a03
St
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove jframe import
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18286/files
- new: ht
On Mon, 11 Mar 2024 23:57:17 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: 7c6fd337
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/7c6fd337d00d4bdeaac724a6ea26fac3654846e0
St
On Tue, 12 Mar 2024 00:24:38 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: 89fb0f83
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/89fb0f837b7dbeed581f5db79d915cf405afda31
St
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
update instructions string, remove extra frame
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18286/fi
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
use old instructions string, give frame title
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18288/fi
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
use old instructions string
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18210/files
- new: ht
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
absolute path jtreg tag
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18210/files
- new: ht
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
absolute path jtreg tag
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18288/files
- new: ht
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
relative path
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18209/files
- new: https://git.openjdk.org/
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
absolute path jtreg tag
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18286/files
- new: ht
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- move jtreg tag above class
- fix jtreg tag, move instructions string outside
-
Changes:
- all: ht
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fix jtreg tag
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18286/files
- new: https://git.openjdk.org/
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
move instructions string outside
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18209/files
- new: ht
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fix jtreg tag, spacing, frame title
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18210/files
- new: ht
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- fix spacing
- fix instructions, add frame title, jtreg tag fix, spacing fix, add to frame
without contentp
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- remove html file
- init commit
Changes: https://git.openjdk.org/jdk/pull/18288/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18288&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328130
S
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18286/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328121
Stats: 61 lines in 2
On Tue, 12 Mar 2024 00:24:11 GMT, Phil Race wrote:
>> Alisen Chung has updated the pull request incrementally with five additional
>> commits since the last revision:
>>
>> - fix pfjframe builder styling and jtreg manual tag
>> - revert spacing
>>
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with five additional
commits since the last revision:
- fix pfjframe builder styling and jtreg manual tag
- revert spacing
- revert files
- restore file
- revert f
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fix pfjframe builder styling and jtreg manual tag
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18210/fi
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18210/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8327859
Stats: 104 lines in 2
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- delete html
- init commit
Changes: https://git.openjdk.org/jdk/pull/18209/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8327857
Stats:
On Tue, 13 Feb 2024 21:34:09 GMT, Alisen Chung wrote:
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
This pull request has now been integrated.
Changeset: 53628f
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
up
> Introduce delays in test to stabilize. Test passes 50x after fix.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
update copyright, fix jtreg formatting, update frame title, expand imports
-
Changes:
- all: ht
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
move
On Thu, 7 Mar 2024 17:40:32 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java
>> line 1:
>>
>>> 1: /*
>>
>> Does it make sense to remove the tray icon in this test as well when the
>> test exits?
>
> How is this resolved? You haven't update
On Thu, 7 Mar 2024 15:04:36 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java
>> line 67:
>>
>>> 65:" something is wrong the corresponding message
>>> is displayed below.\n" +
>>> 66:"
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- remove
On Thu, 7 Mar 2024 16:37:25 GMT, Alexey Ivanov wrote:
>> On windows you need to left click twice, on macos you need to right click
>> once
>
> [I did suggest clearer
> instructions](https://github.com/openjdk/jdk/pull/17838#discussion_r1506056726):
>
> clickInstruction
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with four additional
commits since the last revision:
- ins
On Thu, 7 Mar 2024 14:53:22 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> null check for system tray before remove
>
> test/jdk/java/awt/Tra
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
null
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
im
Introduce delays in test to stabilize. Test passes 50x after fix.
-
Commit messages:
- added delays to stabilize test
Changes: https://git.openjdk.org/jdk/pull/18091/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18091&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
update
On Tue, 27 Feb 2024 11:05:20 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove system property set
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remo
On Thu, 15 Feb 2024 23:25:41 GMT, Alisen Chung wrote:
>> I updated and ran the test changes. The instructions seem unclear. I double
>> right click the icon in the icon tray and the icon temporarily disappears,
>> then reappears. I think that's the correct behavior a
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with three additional
commits since the last revision
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
update
On Thu, 22 Feb 2024 16:55:17 GMT, Alexander Zuev wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test strings and newlines, remove else
>
> test/jdk/java/awt/Tra
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
up
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove u
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
th
On Tue, 13 Feb 2024 23:19:15 GMT, Damon Nguyen wrote:
> I updated and ran the test changes. The instructions seem unclear. I double
> right click the icon in the icon tray and the icon temporarily disappears,
> then reappears. I think that's the correct behavior according to "After each
> acti
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fixed te
Root cause of the test failure was fixed with
https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other
fix also included a test update.
-
Commit messages:
- update test to remove applet
Changes: https://git.openjdk.org/jdk/pull/17838/files
Webrev: https://w
On Tue, 9 Jan 2024 21:06:50 GMT, Alisen Chung wrote:
> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
> the TrayIcon was already removed by the test, causing an error. The fix is to
> make SunToolkit skip posting the event if appContext is null. The test i
ssFailJFrame instead.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
copyright year to 2024
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17329/files
- new: https://git.openjdk.org/jdk/pull/17329/files/139f5b
ssFailJFrame instead.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
added final to target
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17329/files
- new: https://git.openjdk.org/jdk/pull/17329/files/ac2b79
On Thu, 1 Feb 2024 11:44:27 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know y
On Thu, 1 Feb 2024 07:09:00 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know y
On Thu, 1 Feb 2024 10:06:21 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know y
ssFailJFrame instead.
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- remove change in SunToolkit
- correct null change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17329/files
- new: https://git.openjdk.org/jd
ssFailJFrame instead.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove comment, remove null check in updateNativeImage
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17329/files
- new: https://git.openjdk.
On Tue, 30 Jan 2024 09:17:46 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Tue, 30 Jan 2024 06:30:00 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Tue, 30 Jan 2024 07:02:36 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Sat, 27 Jan 2024 05:57:51 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is
On Tue, 30 Jan 2024 09:17:46 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Tue, 30 Jan 2024 07:02:36 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Tue, 30 Jan 2024 06:30:00 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
ssFailJFrame instead.
Alisen Chung has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 10 additional commits since the
last revision:
- Merge branch '
ssFailJFrame instead.
Alisen Chung has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains ten additional commits since the
last revision:
- remove null check i
On Fri, 19 Jan 2024 01:52:47 GMT, Sergey Bylokhov wrote:
>> Note that it does not fail with NPE but instead this code trigger the bug:
>>
>> AppContext eventContext = targetToAppContext(event.getSource());
>> if (eventContext != null && !eventContext.equals(appContext)) {
>>
On Thu, 18 Jan 2024 08:47:40 GMT, Sergey Bylokhov wrote:
>> if the SunToolkit.executeOnEventHandlerThread is removed, then the test
>> doesn't throw an exception, but the icon doesn't disappear (test fails)
>
> then it should be checked what is going on there. The context should not just
> beco
On Wed, 17 Jan 2024 18:49:06 GMT, Alisen Chung wrote:
>> So what is the root cause of null context here?
>
> I'm checking to see if removing executeOnEventHandlerThread solves the issue.
> In this test the source of the appcontext (trayIcon) is deleted via an
> actio
On Wed, 17 Jan 2024 00:26:20 GMT, Sergey Bylokhov wrote:
>> Or maybe it is a lack of synchronization?
>
> So what is the root cause of null context here?
I'm checking to see if removing executeOnEventHandlerThread solves the issue.
In this test the source of the appcontext (trayIcon) is deleted
ssFailJFrame instead.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
added suggested changes, moved test back into folder
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17329/files
- new: https://git.openjdk.org/jd
201 - 300 of 495 matches
Mail list logo
