Re: RFR: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location

2024-05-27 Thread Artem Semenov
On Fri, 24 May 2024 11:38:30 GMT, Abhishek Kumar wrote: > "java.awt.IllegalComponentStateException: component must be showing on the > screen to determine its location" is thrown when getLocationOnScreen method > is invoked for JTableHeader while testing JFileChooser demo. It seems that in >

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-24 Thread Artem Semenov
On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-23 Thread Artem Semenov
On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v3]

2024-05-20 Thread Artem Semenov
On Mon, 20 May 2024 08:20:11 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v2]

2024-05-20 Thread Artem Semenov
On Mon, 20 May 2024 05:17:23 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771

2024-05-18 Thread Artem Semenov
On Thu, 16 May 2024 01:28:37 GMT, Alexander Zuev wrote: > Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer

Re: RFR: 8323965: modify fix for 8317771 to remove reflection instantiation of the inner class

2024-04-23 Thread Artem Semenov
On Tue, 23 Apr 2024 02:25:57 GMT, Alexander Zuev wrote: >> I replaced reflection with using an accessor >> @azuev-java please review > > The problem with this fix is that on the test example attached to the bug any > attempt of navigation trough the items of JTree whole voice over is enabled >

Re: RFR: 8323965: modify fix for 8317771 to remove reflection instantiation of the inner class

2024-04-22 Thread Artem Semenov
On Fri, 19 Apr 2024 20:24:38 GMT, Chen Liang wrote: >> I replaced reflection with using an accessor >> @azuev-java please review > > src/java.desktop/share/classes/sun/swing/SwingAccessor.java line 331: > >> 329: var access = accessibleJTreeNodeCreateAccessor; >> 330: if (access

RFR: 8323965: modify fix for 8317771 to remove reflection instantiation of the inner class

2024-04-19 Thread Artem Semenov
I replaced reflection with using an accessor @azuev-java please review - Commit messages: - 8323965 modify fix for 8317771 to remove reflection instantiation of the inner class Changes: https://git.openjdk.org/jdk/pull/18867/files Webrev:

Re: RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane

2024-02-07 Thread Artem Semenov
On Tue, 6 Feb 2024 20:13:01 GMT, Alexander Zuev wrote: > Add null check for the Aqua LnF situation when tab is hidden die to the tabs > overflow. LGTM - Marked as reviewed by asemenov (Committer). PR Review: https://git.openjdk.org/jdk/pull/17736#pullrequestreview-1867250733

Integrated: 8317771 [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma

2024-01-17 Thread Artem Semenov
On Wed, 20 Dec 2023 09:28:47 GMT, Artem Semenov wrote: > NSAccessibility Outline is an accessibility representation of trees. > This representation requires that the visible children be represented as a > flat array. > The child linearization algorit

Re: RFR: 8317771 [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma

2024-01-17 Thread Artem Semenov
On Wed, 20 Dec 2023 09:28:47 GMT, Artem Semenov wrote: > NSAccessibility Outline is an accessibility representation of trees. > This representation requires that the visible children be represented as a > flat array. > The child linearization algorit

Re: RFR: 8317771 [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma

2023-12-25 Thread Artem Semenov
On Thu, 21 Dec 2023 21:13:14 GMT, Alexander Zuev wrote: >> NSAccessibility Outline is an accessibility representation of trees. >> This representation requires that the visible children be represented as a >> flat array. >> The child linearization algorithm available in >>

RFR: 8317771 [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma

2023-12-20 Thread Artem Semenov
NSAccessibility Outline is an accessibility representation of trees. This representation requires that the visible children be represented as a flat array. The child linearization algorithm available in ```CAccessibility.getChildrenAndRolesRecursive()``` is universal, i.e. suitable for any

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v5]

2023-08-22 Thread Artem Semenov
On Thu, 17 Aug 2023 18:49:11 GMT, Phil Race wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > There's a really tree of JBS issues related to this topic and I see a &

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v5]

2023-08-11 Thread Artem Semenov
On Tue, 16 May 2023 17:56:04 GMT, Artem Semenov wrote: >> This enhancement covers basic API and shared code that should be implemented >> for the Accessibility Announcement feature. >> >> CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 >> &quo

Re: RFR: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem

2023-08-02 Thread Artem Semenov
On Tue, 1 Aug 2023 05:43:52 GMT, Abhishek Kumar wrote: > VoiceOver doesn't announce anything for JRadioButtonMenuItem and > JCheckBoxMenuItem when navigated with down arrow key. JRadioButtonMenuItem > and JCheckBoxMenuItem are having an accessible role of RadioButton and > CheckBox

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v5]

2023-07-13 Thread Artem Semenov
On Tue, 16 May 2023 17:56:04 GMT, Artem Semenov wrote: >> This enhancement covers basic API and shared code that should be implemented >> for the Accessibility Announcement feature. >> >> CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 >> &quo

Integrated: 8308286 Fix clang warnings in linux code

2023-06-29 Thread Artem Semenov
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote: > When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. This pull request has now been integrated. Changeset: 98a954ee Author:

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-23 Thread Artem Semenov
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. >

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

2023-06-23 Thread Artem Semenov
On Fri, 23 Jun 2023 06:19:31 GMT, Daniel Jeliński wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241: >> >>> 239: DISABLED_WARNINGS_gcc_OGLPaints.c := >>> format-nonliteral, \ >>> 240: DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c >>>

Re: RFR: 8308286 Fix clang warnings in linux code [v8]

2023-06-23 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v2]

2023-06-22 Thread Artem Semenov
On Mon, 19 Jun 2023 08:41:48 GMT, Abhishek Kumar wrote: >> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line >> 162: >> >>> 160: AccessibleContext ac = this.getAccessibleContext(); >>> 161: if (ac != null && (comboBox.getSelectedItem() != null))

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v2]

2023-06-22 Thread Artem Semenov
On Mon, 19 Jun 2023 09:27:01 GMT, Abhishek Kumar wrote: >> The issue exist only for non-editable combobox and the root cause is >> accessible object is not created due to incorrect index returned from >> component class which results in no a11y API invoked. >> >> Proposed solution is to

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

2023-06-22 Thread Artem Semenov
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. >

Re: RFR: 8308286 Fix clang warnings in linux code [v7]

2023-06-22 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

2023-06-22 Thread Artem Semenov
On Thu, 22 Jun 2023 09:58:49 GMT, Daniel Jeliński wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > make/modules/java.desktop/lib/Awt2dLib

Re: RFR: 8308286 Fix clang warnings in linux code [v5]

2023-06-22 Thread Artem Semenov
On Wed, 21 Jun 2023 07:35:16 GMT, Daniel Jeliński wrote: >> Artem Semenov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains five commits: >> >> - update >> - update >> - update >>

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

2023-06-22 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox

2023-06-16 Thread Artem Semenov
On Thu, 15 Jun 2023 15:58:18 GMT, Abhishek Kumar wrote: > The issue exist only for non-editable combobox and the root cause is > accessible object is not created due to incorrect index returned from > component class which results in no a11y API invoked. > > Proposed solution is to return the

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v5]

2023-06-14 Thread Artem Semenov
On Tue, 16 May 2023 17:56:04 GMT, Artem Semenov wrote: >> This enhancement covers basic API and shared code that should be implemented >> for the Accessibility Announcement feature. >> >> CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 >> &quo

Re: RFR: 8308286 Fix clang warnings in linux code [v5]

2023-06-11 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-06-11 Thread Artem Semenov
On Tue, 6 Jun 2023 17:47:02 GMT, Weijun Wang wrote: >> This is rarely used in the code and is not the essence of the current >> changes. >> If you introduce such changes, then throughout the code. >> Moreover, this can lead to problems, such as, for example, here: >>

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-06-06 Thread Artem Semenov
On Thu, 1 Jun 2023 15:04:09 GMT, Weijun Wang wrote: >> done > > I didn't ask to revert the change. It's `s/TARGET_OS_MAC/defined(__APPLE__)/`. This is rarely used in the code and is not the essence of the current changes. If you introduce such changes, then throughout the code. Moreover, this

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-06-01 Thread Artem Semenov
On Wed, 31 May 2023 13:52:39 GMT, Weijun Wang wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > src/java.security.jgss/share/native/libj2gss/gssapi.h line 47: > >&

Re: RFR: 8308286 Fix clang warnings in linux code [v4]

2023-06-01 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update

Re: RFR: 8308286 Fix clang warnings in linux code [v2]

2023-05-31 Thread Artem Semenov
On Tue, 30 May 2023 08:14:59 GMT, Alexey Ushakov wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 655: >

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-05-31 Thread Artem Semenov
On Sun, 28 May 2023 03:57:40 GMT, Kim Barrett wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 1163: >

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-05-31 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update

Re: RFR: 8308286 Fix clang warnings in linux code [v2]

2023-05-29 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update

RFR: 8308286 Fix clang warnings in linux code

2023-05-17 Thread Artem Semenov
When using the clang compiler to build OpenJDk on Linux, we encounter various "warnings as errors". They can be fixed with small changes. - Commit messages: - 8308286 Fix clang warnings in linux code Changes: https://git.openjdk.org/jdk/pull/14033/files Webrev:

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v5]

2023-05-16 Thread Artem Semenov
> This enhancement covers basic API and shared code that should be implemented > for the Accessibility Announcement feature. > > CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 > "bugs.openjdk.org") > > @mrserb @prrace @azuev-java please review Art

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v4]

2023-05-09 Thread Artem Semenov
> This enhancement covers basic API and shared code that should be implemented > for the Accessibility Announcement feature. > > CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 > "bugs.openjdk.org") > > @mrserb @prrace @azuev-java please review Art

Re: RFR: 8307145: windowsaccessbridge.dll is missing 4 critical methods in its C API

2023-05-03 Thread Artem Semenov
On Wed, 3 May 2023 17:27:53 GMT, Phil Race wrote: >> In windowsaccessbridge(-64).dll the following methods are exported in a def >> file to C API which in turn call their real implementation, which are >> instance methods of the class WinAccessBridge: >> >> addJavaEventNotification >>

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v2]

2023-04-17 Thread Artem Semenov
On Mon, 17 Apr 2023 00:45:54 GMT, Alexander Zuev wrote: >> Artem Semenov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update >> - I suppose that adding @Native to AccessibleAnnouncer constants would

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v3]

2023-04-17 Thread Artem Semenov
> This enhancement covers basic API and shared code that should be implemented > for the Accessibility Announcement feature. > > CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 > "bugs.openjdk.org") > > @mrserb @prrace @azuev-java please review Art

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v2]

2023-04-16 Thread Artem Semenov
On Fri, 17 Mar 2023 19:41:42 GMT, Artem Semenov wrote: >> This enhancement covers basic API and shared code that should be implemented >> for the Accessibility Announcement feature. >> >> CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 >> &quo

Re: RFR: 7124527: [macosx] SwingSet2, label is not read by VoiceOver when focus is on textfield for Internalframe and Table demo.

2023-04-03 Thread Artem Semenov
On Fri, 31 Mar 2023 11:54:40 GMT, Abhishek Kumar wrote: > In SwingSet2, few label components are not set for textfield component in > InternalFrame and Table demo and due to this VoiceOver doesn't announce the > label along with the textfield value. Added a fix for that and verified in >

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v2]

2023-03-17 Thread Artem Semenov
On Fri, 17 Mar 2023 08:51:50 GMT, Andrey Turbanov wrote: >> Artem Semenov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update >> - I suppose that adding @Native to AccessibleAnnouncer constants would

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature [v2]

2023-03-17 Thread Artem Semenov
> This enhancement covers basic API and shared code that should be implemented > for the Accessibility Announcement feature. Artem Semenov has updated the pull request incrementally with two additional commits since the last revision: - update - I suppose that adding @

Re: RFR: 8283400: [macos] a11y : Screen magnifier does not reflect JRadioButton value change [v2]

2023-03-15 Thread Artem Semenov
On Tue, 14 Mar 2023 10:12:15 GMT, Abhishek Kumar wrote: >> Screen magnifier doesn't reflect the JRadiobutton checked/unchecked state. >> After selecting JRadioButton, the screen magnifier does not show that >> JRadioButton is selected. When mouse is moved away and moved back on the >>

Re: RFR: 8283400: [macos] a11y : Screen magnifier does not reflect JRadioButton value change [v2]

2023-03-15 Thread Artem Semenov
On Tue, 14 Mar 2023 07:43:28 GMT, Abhishek Kumar wrote: >> src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java line 191: >> >>> 189: if (thisRole == AccessibleRole.RADIO_BUTTON) { >>> 190: valueChanged(ptr); >>> 191:

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature

2023-03-13 Thread Artem Semenov
On Mon, 13 Mar 2023 16:46:10 GMT, Artem Semenov wrote: > This enhancement covers basic API and shared code that should be implemented > for the Accessibility Announcement feature. CSR [JDK-8304085](https://bugs.openjdk.org/browse/JDK-8304085 "bugs.openjdk.org")

Re: RFR: 8283400: [macos] a11y : Screen magnifier does not reflect JRadioButton value change

2023-03-13 Thread Artem Semenov
On Fri, 10 Mar 2023 11:59:07 GMT, Abhishek Kumar wrote: > Screen magnifier doesn't reflect the JRadiobutton checked/unchecked state. > After selecting JRadioButton, the screen magnifier does not show that > JRadioButton is selected. When mouse is moved away and moved back on the >

Re: RFR: 8302687 Implement interfaces and shared code for announcement feature

2023-03-13 Thread Artem Semenov
On Mon, 13 Mar 2023 16:58:39 GMT, Alexey Ushakov wrote: >> This enhancement covers basic API and shared code that should be implemented >> for the Accessibility Announcement feature. > > src/java.desktop/share/classes/sun/swing/AccessibleAnnounceProvider.java line > 40: > >> 38: *

RFR: 8302687 Implement interfaces and shared code for announcement feature

2023-03-13 Thread Artem Semenov
This enhancement covers basic API and shared code that should be implemented for the Accessibility Announcement feature. - Commit messages: - update - update - 8302687 Implement interfaces and shared code for announcement feature Changes:

Withdrawn: 8271846 a11y API lacks setSelectedIndex method

2023-02-25 Thread Artem Semenov
On Fri, 6 May 2022 16:10:35 GMT, Artem Semenov wrote: > A11Y implementation on macOS has to directly call the > 'JList.setSelectedIndex' method in order to request selection on an item (see > 'CAccessibility.requestSelection'). The reason is that a11y API lacks > appropriate me

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2023-02-25 Thread Artem Semenov
On Wed, 9 Nov 2022 09:42:00 GMT, Artem Semenov wrote: >> A11Y implementation on macOS has to directly call the >> 'JList.setSelectedIndex' method in order to request selection on an item >> (see 'CAccessibility.requestSelection'). The reason is that a11y API lac

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2023-02-22 Thread Artem Semenov
On Wed, 9 Nov 2022 09:42:00 GMT, Artem Semenov wrote: >> A11Y implementation on macOS has to directly call the >> 'JList.setSelectedIndex' method in order to request selection on an item >> (see 'CAccessibility.requestSelection'). The reason is that a11y API lac

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2023-01-24 Thread Artem Semenov
On Wed, 9 Nov 2022 09:42:00 GMT, Artem Semenov wrote: >> A11Y implementation on macOS has to directly call the >> 'JList.setSelectedIndex' method in order to request selection on an item >> (see 'CAccessibility.requestSelection'). The reason is that a11y API lac

Integrated: 8298644 JNI call of getCurrentComponent on a wrong thread

2023-01-13 Thread Artem Semenov
On Wed, 14 Dec 2022 10:47:09 GMT, Artem Semenov wrote: > [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v8]

2023-01-12 Thread Artem Semenov
On Tue, 10 Jan 2023 11:27:50 GMT, Artem Semenov wrote: >> [OutlineRowAccessibility currentAccessibleWithENV:] defines the >> getCurrentComponent method on the AccessibleContext instance of >> AccessibleJTreeNode class, however the call should go through CAc

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v8]

2023-01-10 Thread Artem Semenov
> [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it is executed on the Event Dispatch thread. Artem Semenov

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v7]

2023-01-10 Thread Artem Semenov
> [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it is executed on the Event Dispatch thread. Artem Semenov

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v6]

2023-01-10 Thread Artem Semenov
> [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it is executed on the Event Dispatch thread. Artem Semenov

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v5]

2023-01-10 Thread Artem Semenov
> [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it is executed on the Event Dispatch thread. Artem Semenov

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v4]

2023-01-10 Thread Artem Semenov
On Thu, 29 Dec 2022 20:52:52 GMT, Sergey Bylokhov wrote: >> Artem Semenov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge master >> - update accessor >> - Pl

Integrated: 8299412 JNI call of getAccessibleActionCount on a wrong thread

2023-01-05 Thread Artem Semenov
On Thu, 29 Dec 2022 15:54:43 GMT, Artem Semenov wrote: > [CommonComponentAccessibility getActionsWithEnv:] defines the > getAccessibleActionCount method on the AccessibleAction class, however the > call should go through CAccessibility so that it is executed on the Event > Dis

Re: RFR: 8299412 JNI call of getAccessibleActionCount on a wrong thread [v2]

2022-12-29 Thread Artem Semenov
On Thu, 29 Dec 2022 19:40:17 GMT, SWinxy wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> There's a more compact way of doing this: > > src/java.desktop/macosx/classes/sun/lwawt/macos

Re: RFR: 8299412 JNI call of getAccessibleActionCount on a wrong thread [v2]

2022-12-29 Thread Artem Semenov
> [CommonComponentAccessibility getActionsWithEnv:] defines the > getAccessibleActionCount method on the AccessibleAction class, however the > call should go through CAccessibility so that it is executed on the Event > Dispatch thread. > > @azuev-java @mrserb @prrace pl

RFR: 8299412 JNI call of getAccessibleActionCount on a wrong thread

2022-12-29 Thread Artem Semenov
[CommonComponentAccessibility getActionsWithEnv:] defines the getAccessibleActionCount method on the AccessibleAction class, however the call should go through CAccessibility so that it is executed on the Event Dispatch thread. @azuev-java @mrserb @prrace please review - Commit

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v4]

2022-12-29 Thread Artem Semenov
> [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it is executed on the Event Dispatch thread. Artem Semenov

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v4]

2022-12-29 Thread Artem Semenov
On Sat, 24 Dec 2022 00:35:07 GMT, Sergey Bylokhov wrote: >> Thank you. >> I removed adding accesses for TableCell and ListChildren. If that's what you >> meant. >> I would like to keep the implementation of the Accesser itself, if possible. >> Because in the future it may come in handy in this

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v3]

2022-12-29 Thread Artem Semenov
> [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it is executed on the Event Dispatch thread. Artem Semenov

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-12-26 Thread Artem Semenov
On Wed, 9 Nov 2022 09:42:00 GMT, Artem Semenov wrote: >> A11Y implementation on macOS has to directly call the >> 'JList.setSelectedIndex' method in order to request selection on an item >> (see 'CAccessibility.requestSelection'). The reason is that a11y API lac

Integrated: 8298645 JNI works with accessibleSelection on a wrong thread

2022-12-23 Thread Artem Semenov
On Tue, 13 Dec 2022 15:59:53 GMT, Artem Semenov wrote: > [ComboBoxAccessibility accessibilityValue] works with the accessibleSelection > object directly, however the work should go through CAccessibility so that it > is executed on the Event Dispatch thread. This pull request has

Re: RFR: 8298645 JNI works with accessibleSelection on a wrong thread [v3]

2022-12-23 Thread Artem Semenov
> [ComboBoxAccessibility accessibilityValue] works with the accessibleSelection > object directly, however the work should go through CAccessibility so that it > is executed on the Event Dispatch thread. Artem Semenov has updated the pull request incrementally with one additional com

Integrated: 8298643 JNI call of getAccessibleRowWithIndex and getAccessibleColumnWithIndex on a wrong thread

2022-12-23 Thread Artem Semenov
On Tue, 13 Dec 2022 13:30:45 GMT, Artem Semenov wrote: > [TableAccessibility accessibleRowWithIndex] and [TableAccessibility > accessibleColumnWithIndex] defines the getAccessibleRowWithIndex and > getAccessibleColumnWithIndex methods on the AccessibleContext instance of > Acce

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v2]

2022-12-23 Thread Artem Semenov
On Thu, 22 Dec 2022 22:01:39 GMT, Sergey Bylokhov wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Please split the long lines to have 80 chars per line. > > src/java.desktop/share/

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v2]

2022-12-23 Thread Artem Semenov
> [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it is executed on the Event Dispatch thread. Artem Semenov

RFR: 8298644 JNI call of getCurrentComponent on a wrong thread

2022-12-14 Thread Artem Semenov
[OutlineRowAccessibility currentAccessibleWithENV:] defines the getCurrentComponent method on the AccessibleContext instance of AccessibleJTreeNode class, however the call should go through CAccessibility so that it is executed on the Event Dispatch thread. - Commit messages: -

Re: RFR: 8298645 JNI works with accessibleSelection on a wrong thread [v2]

2022-12-14 Thread Artem Semenov
On Tue, 13 Dec 2022 19:26:37 GMT, SWinxy wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> A comment or javadoc should mention that this is called from native code,

Re: RFR: 8298645 JNI works with accessibleSelection on a wrong thread [v2]

2022-12-14 Thread Artem Semenov
> [ComboBoxAccessibility accessibilityValue] works with the accessibleSelection > object directly, however the work should go through CAccessibility so that it > is executed on the Event Dispatch thread. Artem Semenov has updated the pull request incrementally with one additional com

RFR: 8298645 JNI works with accessibleSelection on a wrong thread

2022-12-13 Thread Artem Semenov
[ComboBoxAccessibility accessibilityValue] works with the accessibleSelection object directly, however the work should go through CAccessibility so that it is executed on the Event Dispatch thread. - Commit messages: - 8298645 JNI works with accessibleSelection on a wrong thread

RFR: 8298643 JNI call of getAccessibleRowWithIndex and getAccessibleColumnWithIndex on a wrong thread

2022-12-13 Thread Artem Semenov
[TableAccessibility accessibleRowWithIndex] and [TableAccessibility accessibleColumnWithIndex] defines the getAccessibleRowWithIndex and getAccessibleColumnWithIndex methods on the AccessibleContext instance of AccessibleJTable class, however the call should go through CAccessibility so that

Integrated: 8298457 Instructions in a11y manual tests need to be updated

2022-12-09 Thread Artem Semenov
On Fri, 9 Dec 2022 11:02:09 GMT, Artem Semenov wrote: > Test instructions: > - Accessible Actions Test; > - AccessibleJTabbedPaneTest; > - Accessible Text Test. > contain inaccurate indications of actions in different screen readers. This pull request has now been integra

Re: RFR: 8298457 Instructions in a11y manual tests need to be updated

2022-12-09 Thread Artem Semenov
On Fri, 9 Dec 2022 11:02:09 GMT, Artem Semenov wrote: > Test instructions: > - Accessible Actions Test; > - AccessibleJTabbedPaneTest; > - Accessible Text Test. > contain inaccurate indications of actions in different screen readers. @azuev-java please review -

RFR: 8298457 Instructions in a11y manual tests need to be updated

2022-12-09 Thread Artem Semenov
Test instructions: - Accessible Actions Test; - AccessibleJTabbedPaneTest; - Accessible Text Test. contain inaccurate indications of actions in different screen readers. - Commit messages: - 8298457 Instructions in a11y manual tests need to be updated Changes:

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-11-28 Thread Artem Semenov
On Wed, 9 Nov 2022 09:42:00 GMT, Artem Semenov wrote: >> A11Y implementation on macOS has to directly call the >> 'JList.setSelectedIndex' method in order to request selection on an item >> (see 'CAccessibility.requestSelection'). The reason is that a11y API lac

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-11-21 Thread Artem Semenov
On Sun, 20 Nov 2022 03:16:28 GMT, Sergey Bylokhov wrote: >> It looks like it is. Please formulate the question differently. > > It is unclear why the `setSelectionInterval `is actually any better than > `addAccessibleSelection`. Both have a similar implementation, in some cases, > the

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-11-14 Thread Artem Semenov
On Fri, 11 Nov 2022 21:40:40 GMT, Sergey Bylokhov wrote: >> We tried to do this, it leads to an endless repetition of the selected line >> until it freezes. > > Probably because of the endless notifications loop? implementation of > addSelectionInterval looks similar to setSelectionInterval.

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-11-11 Thread Artem Semenov
On Fri, 11 Nov 2022 02:16:15 GMT, Sergey Bylokhov wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> We are not using author tags in tests either - but that's just a nitpick. > > src/j

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-11-09 Thread Artem Semenov
On Wed, 9 Nov 2022 00:51:10 GMT, Alexander Zuev wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> We don't do @author tags in openjdk >> Not 2022 ? > > src/java.desktop/share

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v3]

2022-11-09 Thread Artem Semenov
lists from the Java side, but I did not succeed in implementing it, because I > could not determine the inclusion of the so-called "VoiceOver multiple > selection mode". Artem Semenov has updated the pull request with a new target base due to a merge or a rebase. The increm

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-11-09 Thread Artem Semenov
lists from the Java side, but I did not succeed in implementing it, because I > could not determine the inclusion of the so-called "VoiceOver multiple > selection mode". Artem Semenov has updated the pull request incrementally with one additional commit since the last revis

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-11-09 Thread Artem Semenov
On Wed, 9 Nov 2022 04:29:57 GMT, Phil Race wrote: >> I am still waiting for the following questions (from July) to be answered >> here (not somewhere else) >> >>> You did not acknowledge this is not a backportable fix >> >> By which I mean, if this needs to be solved in say JDK 11 too, what

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-11-08 Thread Artem Semenov
On Mon, 7 Nov 2022 21:20:45 GMT, Phil Race wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> We don't do @author tags in openjdk >> Not 2022 ? > > I am still waiting fo

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-10-27 Thread Artem Semenov
On Wed, 11 May 2022 12:49:34 GMT, Artem Semenov wrote: >> A11Y implementation on macOS has to directly call the >> 'JList.setSelectedIndex' method in order to request selection on an item >> (see 'CAccessibility.requestSelection'). The reason is that a11y API lac

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-09-28 Thread Artem Semenov
On Wed, 11 May 2022 12:49:34 GMT, Artem Semenov wrote: >> A11Y implementation on macOS has to directly call the >> 'JList.setSelectedIndex' method in order to request selection on an item >> (see 'CAccessibility.requestSelection'). The reason is that a11y API lac

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-08-31 Thread Artem Semenov
On Wed, 11 May 2022 12:49:34 GMT, Artem Semenov wrote: >> A11Y implementation on macOS has to directly call the >> 'JList.setSelectedIndex' method in order to request selection on an item >> (see 'CAccessibility.requestSelection'). The reason is that a11y API lac

  1   2   >