On Fri, 8 Aug 2025 08:10:09 GMT, Matthias Baesken wrote:
>> java/awt/font/FontNames/LocaleFamilyNames.java is slow on Windows and on
>> some machines it even times out.
>> Add some logging to the test, and we could also increase the test timeout a
>> bit.
>
> Matthias Baesken has updated the pu
On Thu, 7 Aug 2025 08:14:45 GMT, Matthias Baesken wrote:
> java/awt/font/FontNames/LocaleFamilyNames.java is slow on Windows and on some
> machines it even times out.
> Add some logging to the test, and we could also increase the test timeout a
> bit.
Looks good. What is the reason to use othe
On Wed, 16 Jul 2025 12:44:45 GMT, Matthias Baesken wrote:
> We have build errors on AIX , seems related to
> [JDK-8354415](https://bugs.openjdk.org/browse/JDK-8354415) :
>
>
> === Output from failing command(s) repeated here ===
> * For target support_native_java.desktop_libawt_xawt_awt_Graphi
On Thu, 23 Jan 2025 09:23:52 GMT, Matthias Baesken wrote:
> In java2d coding there are a few overflows (those are shown when running
> jtreg tests with ubsan enabled binaries)
> jtreg test java/awt/Scrollbar/AquaLFScrollbarTest/ScrollBarBorderTest.java
> shows
>
> jdk/src/java.desktop/share/n
On Thu, 23 Jan 2025 09:23:52 GMT, Matthias Baesken wrote:
> In java2d coding there are a few overflows (those are shown when running
> jtreg tests with ubsan enabled binaries)
> jtreg test java/awt/Scrollbar/AquaLFScrollbarTest/ScrollBarBorderTest.java
> shows
>
> jdk/src/java.desktop/share/n
On Wed, 15 Jan 2025 08:39:49 GMT, Matthias Baesken wrote:
> ping, need a re-review after recent changes ...
What about Martin's comment regarding the %p for hex byte values? Shouldn't
some form of %x be better?
-
PR Comment: https://git.openjdk.org/jdk/pull/23076#issuecomment-2592
On Tue, 14 Jan 2025 10:51:56 GMT, Matthias Baesken wrote:
>> When enabling the jsound ERROR and TRACE reporting (see
>> src/java.desktop/share/native/libjsound/Configure.h
>> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libjsound/Configure.h#L32
>> ), we run into so
On Tue, 14 Jan 2025 08:55:57 GMT, Matthias Baesken wrote:
> Regarding jlong-format, in HS globalDefinitions.hpp we have this
>
> ```
> #define INT64_FORMAT "%" PRId64
>
> #ifndef JLONG_FORMAT
> #define JLONG_FORMAT INT64_FORMAT
> ```
>
> Not sure we want t
On Mon, 13 Jan 2025 14:54:09 GMT, Matthias Baesken wrote:
> When enabling the jsound ERROR and TRACE reporting (see
> src/java.desktop/share/native/libjsound/Configure.h
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libjsound/Configure.h#L32
> ), we run into some b
On Mon, 13 Jan 2025 14:54:09 GMT, Matthias Baesken wrote:
> When enabling the jsound ERROR and TRACE reporting (see
> src/java.desktop/share/native/libjsound/Configure.h
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libjsound/Configure.h#L32
> ), we run into some b
On Thu, 26 Sep 2024 14:44:53 GMT, Matthias Baesken wrote:
>> It has been discussed that checking the return value of pthread_create
>> should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the
>> splashscreen coding .
>
> Matthias Baesken has updated the pul
On Thu, 26 Sep 2024 07:07:27 GMT, Matthias Baesken wrote:
> > Yes, I think the call to java_md_macosx.m seems redundant. And I would
> > remove the comment in java_md_common.c. strerror is >used at various places
> > in JDK coding and there's actually only one place that uses strerror_r, in
>
On Wed, 25 Sep 2024 11:46:00 GMT, Matthias Baesken wrote:
> It has been discussed that checking the return value of pthread_create should
> be done.
> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the
> splashscreen coding .
> JLI_ReportErrorMessageSys
> I found so
On Wed, 25 Sep 2024 11:46:00 GMT, Matthias Baesken wrote:
> It has been discussed that checking the return value of pthread_create should
> be done.
> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the
> splashscreen coding .
Looks good overall, just one nit.
I guess
On Mon, 2 Sep 2024 11:43:20 GMT, Matthias Baesken wrote:
> We get a couple of warnings as errors on AIX because of unused variables or
> functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:66
On Fri, 15 Mar 2024 11:39:05 GMT, Christoph Langer wrote:
> > > I added it to our testing. Results early next week.
> >
> >
> > @RealCLanger Thank you. I'm more interested in the failing case. How
> > reliable does the test reproduce the problem?
>
On Fri, 15 Mar 2024 10:53:06 GMT, Alexey Ivanov wrote:
> > I added it to our testing. Results early next week.
>
> @RealCLanger Thank you. I'm more interested in the failing case. How reliable
> does the test reproduce the problem?
Yes, it's running in 21 and 22 as well, so we'll see what happ
On Mon, 11 Mar 2024 19:16:21 GMT, Alexey Ivanov wrote:
> @mrserb, @RealCLanger, could you run this test in your environments, please?
> It is for Linux and macOS only.
>
> I'm looking for confirmation that the test fails without the fix for
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8
On Thu, 7 Mar 2024 16:55:12 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>
On Mon, 29 Jan 2024 14:24:43 GMT, Christoph Langer wrote:
> The assertions reported in the bug were observed spuriously and here and
> there broke tests in some Windows configurations.
> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
> [JDK-82
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
On Thu, 7 Mar 2024 16:43:52 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp
>> line 182:
>>
>>> 180: gpBitmapInfo->bmiHeader.biBitCount = 0;
>>> 181: HDC hBMDC = this->GetDC();
>>> 182: VERIFY(hBMDC != NULL);
>>
>> You may wan
On Thu, 7 Mar 2024 00:47:00 GMT, Phil Race wrote:
>> It is not what I meant… If we want to preserve the way it work, we should
>> execute the below code even if `this->GetDC()` fails…
>>
>> On the other hand, testing didn't find any problems, in which case I prefer
>> bailing out after `::GetD
On Wed, 6 Mar 2024 08:29:01 GMT, Alexey Ivanov wrote:
>> Maybe. I think, as Phil already mentions, a cleanup/centralization of the
>> places that load libawt should be done. But I would suggest to do this in a
>> separate issue.
>
> Sounds reasonable. Will you create a CR for this? So that we w
On Wed, 6 Mar 2024 08:31:34 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
On Tue, 5 Mar 2024 18:20:39 GMT, Alexey Ivanov wrote:
> It looks good to me.
>
> The only question I have is for the fallback in `awt_Win32GraphicsDevice.cpp`.
>
> Bailing out quickly makes the code cleaner. In this case, if `::GetDIBits`
> fails, we can bail out too.
>
> If the fallback is n
On Wed, 6 Mar 2024 07:50:08 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>
On Tue, 5 Mar 2024 18:00:51 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> load awt.dll before display check
>
> src/java.desktop/windows/classes/sun/awt/Pla
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
On Thu, 29 Feb 2024 22:24:14 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
On Fri, 23 Feb 2024 13:44:15 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>
On Fri, 23 Feb 2024 13:44:15 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>
On Sat, 24 Feb 2024 19:12:31 GMT, Phil Race wrote:
> So there is something wrong here. About 40 tests just plain crash. About 10
> tests fail with headlessException - even if they say they are headful.
> Probably more tests would fail but entire tasks timed out as a result.
OK - do you have so
On Fri, 23 Feb 2024 21:43:21 GMT, Phil Race wrote:
> The change looks good but I'd like to run it through all our tests since if
> there's anything wrong with this code path we are in trouble :-)
Yes, please test thoroughly and let me know. I'll give it another spin in our
testing as well.
>
On Fri, 16 Feb 2024 13:26:19 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
On Fri, 16 Feb 2024 21:50:09 GMT, Phil Race wrote:
> The first thing I worry about here is that the obvious implication is that we
> can now have zero monitors. Even if the monitor were not usable, that seems
> to have been "OK" in practice so long as we didn't assert out in a debug
> build. H
On Mon, 19 Feb 2024 13:04:47 GMT, Matthias Baesken wrote:
> In AccessBridgeJavaEntryPoints.cpp we have a couple of exception checks with
> potential early returns. Those miss ReleaseStringChars .
LGTM
-
Marked as reviewed by clanger (Reviewer).
PR Review: https://git.openjdk.org/
On Fri, 16 Feb 2024 12:52:34 GMT, Alexey Ivanov wrote:
>> OK, yes, I'll turn this back to previous behavior. Rather don't touch
>> something at all if we have no idea... 😉
>
> I prefer *backing out*… — it makes the code cleaner. At the same time, I am
> unsure about the consequences of doing so
On Fri, 16 Feb 2024 11:40:15 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Little cleanup
>
> src/java.desktop/windows/native/libawt/windows/Devi
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
On Fri, 16 Feb 2024 11:29:18 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Little cleanup
>
> src/java.desktop/windows/native/libawt/windows/awt_Win32
On Fri, 16 Feb 2024 08:46:10 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>
On Thu, 15 Feb 2024 09:56:51 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comments
>
> src/java.desktop/windows/native/libawt/windows/Devices.cpp line
On Thu, 15 Feb 2024 22:46:54 GMT, Christoph Langer wrote:
>> src/java.desktop/windows/native/libawt/windows/Devices.cpp line 102:
>>
>>> 100: memset((void*)(&mieInfo), 0, sizeof(MONITORINFOEX));
>>> 101: mieInfo.cbSize = sizeof(MONITORINFOEX);
>>
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
On Thu, 15 Feb 2024 09:31:34 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comments
>
> src/java.desktop/windows/native/libawt/windows/Devices
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
On Thu, 15 Feb 2024 09:37:28 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comments
>
> src/java.desktop/windows/native/libawt/windows/awt_Win32
On Thu, 15 Feb 2024 09:25:26 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comments
>
> src/java.desktop/windows/native/libawt/windows/Devices.cpp line 10
On Fri, 12 Jan 2024 17:47:23 GMT, Christoph Langer wrote:
> This picks up fixing the issue of
> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
> been integrated with #17224 but @prrace had concerns and so it was backed out.
>
> I have now spent quit
On Fri, 9 Feb 2024 14:23:28 GMT, Alexey Ivanov wrote:
>> As far as I can see, the real problem is that `DWMIsCompositionEnabled`
>> calls a Java method and does not check if an exception occurred. It should
>> do it according to the JNI specification.
>>
>> I can assume `initScreens(env)` does
On Wed, 31 Jan 2024 06:05:18 GMT, Christoph Langer wrote:
>> This picks up fixing the issue of
>> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
>> been integrated with #17224 but @prrace had concerns and so it was backed
>> out.
>>
On Wed, 31 Jan 2024 07:23:13 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>
CreateDC returns non-NULL in Devices.cpp. I also add some more
> checking/error handling to AwtWin32GraphicsDevice::Initialize() for
> correctness.
>
> Furthermore, I re-enable the test
> `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows
> Debug VMs, which reve
On Tue, 30 Jan 2024 14:03:39 GMT, Alexey Ivanov wrote:
> Now that I re-read the problem statement and the exception handling JNI, the
> fix doesn't look correct to me.
>
> What does the warning say?
>
> > WARNING in native method: JNI call made without checking exceptions when
> > required to
On Tue, 30 Jan 2024 14:13:07 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Tue, 30 Jan 2024 13:44:22 GMT, Alexey Ivanov wrote:
>> In fact, any method can throw an exception…
>>
>> Is there a guide which clearly states where `ExceptionCheck` is required?
>> The function returns a boolean indicating whether there's a pending
>> exception. Shall we back out if there
On Mon, 29 Jan 2024 20:45:18 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
/8b6293f6bfb7b7628c6604e6c44401fc96d85cf4/src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsEnv.cpp#L141
> Maybe the usual control flow would call the wrapping native method
> `DWMIsCompositi
onEnabled()` from somewhere else initially such that the initialization of
`Win32Gr
The assertions reported in the bug were observed spuriously and here and there
broke tests in some Windows configurations.
For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
[JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or
[JDK-8323664](https://bugs.openjdk.org
/8b6293f6bfb7b7628c6604e6c44401fc96d85cf4/src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsEnv.cpp#L141
> Maybe the usual control flow would call the wrapping native method
> `DWMIsCompositi
onEnabled()` from somewhere else initially such that the initialization of
`Win32G
On Sat, 27 Jan 2024 06:44:59 GMT, Christoph Langer wrote:
> Thanks for the review. For some reason, however, I still saw the jni warning
> in our env with the patch applied. Still looking into it to understand what
> I'm missing...
OK, got it. The exception check needs to be b
On Thu, 25 Jan 2024 06:36:36 GMT, Christoph Langer wrote:
>> This picks up fixing the issue of
>> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
>> been integrated with #17224 but @prrace had concerns and so it was backed
>> out.
>>
/8b6293f6bfb7b7628c6604e6c44401fc96d85cf4/src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsEnv.cpp#L141
> Maybe the usual control flow would call the wrapping native method
> `DWMIsCompositi
onEnabled()` from somewhere else initially such that the initialization of
`Win32G
On Thu, 11 Jan 2024 16:52:40 GMT, Matthias Baesken wrote:
>> When running with fastdebug binaries we run intermittent into the issue
>> below in
>> jtreg test
>> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
>> Seems we miss checking of successful HBITMAP creation
On Thu, 11 Jan 2024 16:52:40 GMT, Matthias Baesken wrote:
>> When running with fastdebug binaries we run intermittent into the issue
>> below in
>> jtreg test
>> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
>> Seems we miss checking of successful HBITMAP creation
On Fri, 12 Jan 2024 17:47:23 GMT, Christoph Langer wrote:
> This picks up fixing the issue of
> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
> been integrated with #17224 but @prrace had concerns and so it was backed out.
>
> I have now spent quit
On Fri, 12 Jan 2024 17:47:23 GMT, Christoph Langer wrote:
> This picks up fixing the issue of
> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
> been integrated with #17224 but @prrace had concerns and so it was backed out.
>
> I have now spent quit
This picks up fixing the issue of
[JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
been integrated with #17224 but @prrace had concerns and so it was backed out.
I have now spent quite some thoughts into the problem and end up with the
[initial
commit](https://github
On Tue, 2 Jan 2024 15:03:12 GMT, Matthias Baesken wrote:
> The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced
> with https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni , and
> shows on Windows server 2019 the following JNI warning , so the test fails on
>
On Sun, 8 Oct 2023 22:15:59 GMT, Christoph Langer wrote:
> This test is failing on several Linux configurations (SLES 15), so it should
> be excluded.
This pull request has now been integrated.
Changeset: fcff222f
Author:Christoph Langer
URL:
https://git.openjdk.org/jdk/
This test is failing on several Linux configurations (SLES 15), so it should be
excluded.
-
Commit messages:
- JDK-8317706
Changes: https://git.openjdk.org/jdk/pull/16096/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16096&range=00
Issue: https://bugs.openjdk.org/browse
On Wed, 27 Sep 2023 08:10:16 GMT, Christoph Langer wrote:
>> Exclude java/awt/font/Rotate/RotatedTextTest.java until
>> [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The
>> error shows in several linux installations.
>
> Christoph Langer has updat
On Fri, 22 Sep 2023 06:20:42 GMT, Christoph Langer wrote:
> Exclude java/awt/font/Rotate/RotatedTextTest.java until
> [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The
> error shows in several linux installations.
This pull request has now been integrated.
On Tue, 26 Sep 2023 13:37:53 GMT, Alexey Ivanov wrote:
>> I couldn't find any best practices for problem-listing.
>>
>> Yet keeping tests in the same area closer seems like a good idea to me.
>> Either line is fine with me. Thanks.
>>
>> I started an internal discussion in clientlibs to see wh
> Exclude java/awt/font/Rotate/RotatedTextTest.java until
> [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The
> error shows in several linux installations.
Christoph Langer has updated the pull request with a new target base due to a
merge or a rebase. The in
On Mon, 25 Sep 2023 10:35:21 GMT, Alexey Ivanov wrote:
>> Exclude java/awt/font/Rotate/RotatedTextTest.java until
>> [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The
>> error shows in several linux installations.
>
> test/jdk/ProblemList.txt line 472:
>
>> 470:
>> 471:
Exclude java/awt/font/Rotate/RotatedTextTest.java until
[JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The error
shows in several linux installations.
-
Commit messages:
- JDK-8316710
Changes: https://git.openjdk.org/jdk/pull/15880/files
Webrev: https://webr
On Mon, 18 Sep 2023 06:19:05 GMT, Arno Zeller wrote:
> The test fails on newer SLES versions that have RobotoSlab-Regular.ttf as
> default font. I suggest to try getting a DejaVu font as default on Linux
> because it is known to work without issues.
To me this looks pragmatic. I made a few sug
On Thu, 3 Aug 2023 08:16:55 GMT, Andreas Steiner wrote:
>> Add the default include location(/opt/freeware/include/) for cups on AIX.
>> With this set the additional configure parameter --with-cups-include can be
>> removed, which was needed on AIX.
>
> Andreas Steiner has updated the pull reque
On Wed, 2 Aug 2023 15:20:55 GMT, Andreas Steiner wrote:
>> Add the default include location(/opt/freeware/include/) for cups on AIX.
>> With this set the additional configure parameter --with-cups-include can be
>> removed, which was needed on AIX.
>
> Andreas Steiner has updated the pull reque
On Tue, 1 Aug 2023 12:50:47 GMT, Andreas Steiner wrote:
>> Add the default include location(/opt/freeware/include/) for cups on AIX.
>> With this set the additional configure parameter --with-cups-include can be
>> removed, which was needed on AIX.
>
> Andreas Steiner has updated the pull reque
On Tue, 1 Aug 2023 07:28:02 GMT, Andreas Steiner wrote:
> Add the default include location(/opt/freeware/include/) for cups on AIX.
> With this set the additional configure parameter --with-cups-include can be
> removed, which was needed on AIX.
I think the check for the cups default location
On Fri, 28 Jul 2023 07:52:14 GMT, Matthias Baesken wrote:
> In file ThemeReader.cpp
> functionJava_sun_awt_windows_ThemeReader_paintBackground
> we create DCs and release them at the end, but seems we miss it in early
> returns.
>
> While looking at the code, I noticed that CreateCompatibleDC
On Fri, 28 Jul 2023 09:58:01 GMT, Matthias Baesken wrote:
>> The function WideCharToMultiByte is used at a number of places of the JDK
>> codebase for conversion purposes.
>> Unfortunately, the function might fail because of various reasons, so the
>> return value must be checked to avoid undef
On Tue, 25 Jul 2023 11:17:23 GMT, Matthias Baesken wrote:
> The function WideCharToMultiByte is used at a number of places of the JDK
> codebase for conversion purposes.
> Unfortunately, the function might fail because of various reasons, so the
> return value must be checked to avoid undefined
On Wed, 5 Jul 2023 15:01:52 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revi
On Fri, 30 Jun 2023 11:37:10 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
On Thu, 22 Jun 2023 09:21:29 GMT, Matthias Baesken wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java
>> line 196:
>>
>>> 194:
>>> 195: /**
>>> 196: * Set whether or not to use ct.sym as an alternate
>>
>> As an alternate to what? This needs somet
On Fri, 9 Jun 2023 10:42:59 GMT, Matthias Baesken wrote:
>> After
>> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982): [Wayland]
>> [XWayland] java.awt.Robot taking screenshots
>> the AIX build fails.
>> We get
>>
>> * For target support_native_java.desktop_libawt_xawt_screencast_pipe
On Thu, 8 Dec 2022 19:41:16 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warnings are
>> disabled for codes that us
On Mon, 19 Dec 2022 13:49:18 GMT, Matthias Baesken wrote:
> Looks like the coding in
> jdk/src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java
> readColorPalette is rather close to what staggeredReadByteStream does, so we
> could instead use staggeredReadByteStream a
On Wed, 7 Dec 2022 08:54:29 GMT, Matthias Baesken wrote:
>> The cleanup and error handling in function awt_parseColorModel in
>> awt_parseImage.c could be improved.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> small
97 matches
Mail list logo
