Integrated: 8361216: Do not fork javac in J2DBench ant build

2025-07-09 Thread Eric Caspole
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote: > Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a > different javac from the PATH. This pull request has now been integrated. Changeset: 7282f68c Author: Eric Caspole URL: https://git.openjdk.o

Re: RFR: 8361216: Do not fork javac in J2DBench ant build [v2]

2025-07-09 Thread Eric Caspole
> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a > different javac from the PATH. Eric Caspole has updated the pull request incrementally with one additional commit since the last revision: Update the version default to 8 in the Make file as Phil n

Re: RFR: 8361216: Do not fork javac in J2DBench ant build

2025-07-09 Thread Eric Caspole
On Fri, 4 Jul 2025 00:59:01 GMT, Sergey Bylokhov wrote: >>> I think we can just drop ant and leave the makefile as it is. The >>> source/target settings are set to that low level to indicate that the >>> source code should be compatible with older versions of the JDK. Currently, >>> JDK 1.4 co

Re: RFR: 8361216: Do not fork javac in J2DBench ant build

2025-07-03 Thread Eric Caspole
On Thu, 3 Jul 2025 19:30:40 GMT, Phil Race wrote: >> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a >> different javac from the PATH. > > src/demo/share/java2d/J2DBench/build.xml line 42: > >> 40: >> 41: >> 42: > > This would be inconsistent with the Make targe

Integrated: 8361213: J2DAnalyzer should emit the score as a decimal

2025-07-03 Thread Eric Caspole
On Tue, 1 Jul 2025 17:38:35 GMT, Eric Caspole wrote: > As mentioned in the bug, I think it would be better to always emit the score > as decimal instead of sometimes decimal, sometimes scientific notation. This pull request has now been integrated. Changeset: dcc7254a Author: Eric C

Re: RFR: 8361216: Do not fork javac in J2DBench ant build

2025-07-03 Thread Eric Caspole
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote: > Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a > different javac from the PATH. Could we move J2DBench under test next to micro/ ? It's not a demo, it's a benchmark but somehow it ended up under

Re: RFR: 8361216: Do not fork javac in J2DBench ant build

2025-07-03 Thread Eric Caspole
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote: > Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a > different javac from the PATH. I dont know the history of J2DBench or how its build was developed. It looks like J2DBench is not included in the JDK demos

Re: RFR: 8361216: Do not fork javac in J2DBench ant build

2025-07-02 Thread Eric Caspole
On Tue, 1 Jul 2025 19:30:21 GMT, Eric Caspole wrote: > Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a > different javac from the PATH. We only test back to 8 so we don't need to change it more often. But JDK 24/25 does not support source 7 so we should d

Re: RFR: 8361213: J2DAnalyzer should emit the score as a decimal [v2]

2025-07-02 Thread Eric Caspole
> As mentioned in the bug, I think it would be better to always emit the score > as decimal instead of sometimes decimal, sometimes scientific notation. Eric Caspole has updated the pull request incrementally with one additional commit since the last revision: Use - to left-align the

Re: RFR: 8361213: J2DAnalyzer should emit the score as a decimal [v2]

2025-07-02 Thread Eric Caspole
On Wed, 2 Jul 2025 16:10:10 GMT, Jonas Norlinder wrote: >> I am not sure what you mean, but with the 10, the scores line up with the >> rest of the minor stats when it is monospace font like this example - >> >> >> Summary: >> vimg_text_noaa: >> Number of tests: 2 >> Overall averag

Re: RFR: 8361213: J2DAnalyzer should emit the score as a decimal

2025-07-02 Thread Eric Caspole
On Tue, 1 Jul 2025 20:52:50 GMT, Jonas Norlinder wrote: >> As mentioned in the bug, I think it would be better to always emit the score >> as decimal instead of sometimes decimal, sometimes scientific notation. > > src/demo/share/java2d/J2DBench/src/j2dbench/report/J2DAnalyzer.java line 273: >

RFR: 8361216: Do not fork javac in J2DBench ant build

2025-07-01 Thread Eric Caspole
Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a different javac from the PATH. - Commit messages: - 8361216: Do not fork javac in J2DBench ant build Changes: https://git.openjdk.org/jdk/pull/26077/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=260

RFR: 8361213: J2DAnalyzer should emit the score as a decimal

2025-07-01 Thread Eric Caspole
As mentioned in the bug, I think it would be better to always emit the score as decimal instead of sometimes decimal, sometimes scientific notation. - Commit messages: - 8361213: J2DAnalyzer should emit the score as a decimal Changes: https://git.openjdk.org/jdk/pull/26076/files