Re: RFR: 8337681: PNGImageWriter uses much more memory than necessary [v2]

2024-08-03 Thread Laurent Bourgès
On Thu, 1 Aug 2024 21:51:04 GMT, Daniel Gredler wrote: >> At some point the `JPEGImageWriter` was optimized to reduce duplication / >> copying of rasters and data buffers (see `JDK-6266748`). However, >> `PNGImageWriter` never received a similar optimization, and is making >> unnecessary copie

Integrated: JDK-8323695 RenderPerf (2D) enhancements (23.12)

2024-02-22 Thread Laurent Bourgès
On Fri, 12 Jan 2024 21:34:32 GMT, Laurent Bourgès wrote: > - new executor modes (buffer & volatile) > - support parallel rendering on several frames and / or screens > - added robot calibration + optionally use rounded duration to min frame > latency (120Hz) > - give more st

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12) [v5]

2024-02-09 Thread Laurent Bourgès
ents > - added version + help information Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: JDK-8323695: fixed font names (supporting logical fonts too) - Changes: - all: https://git.openjdk.org/jdk/pull/1

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12) [v4]

2024-02-09 Thread Laurent Bourgès
On Fri, 9 Feb 2024 18:13:50 GMT, Alexey Ushakov wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8323695: use Font.DIALOG > > test/jdk/performance/client/RenderPerfTest/src/

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12) [v4]

2024-02-08 Thread Laurent Bourgès
ents > - added version + help information Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: JDK-8323695: use Font.DIALOG - Changes: - all: https://git.openjdk.org/jdk/pull/17408/files - new: https://git.openjdk

Re: RFR: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java [v2]

2024-02-07 Thread Laurent Bourgès
On Thu, 8 Feb 2024 06:04:16 GMT, Sergey Bylokhov wrote: >> The ClipShapeTest test is split into 4 different tests which could be >> executed in parallel. >> >> The execution time is changed from: >> >> >> == >> Test summary >> == >>T

Re: RFR: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java

2024-02-06 Thread Laurent Bourgès
On Tue, 6 Feb 2024 03:10:36 GMT, Sergey Bylokhov wrote: > The ClipShapeTest test is split into 4 different tests which could be > executed in parallel. > > The execution time is changed from: > > > == > Test summary > == >TEST

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12) [v3]

2024-02-03 Thread Laurent Bourgès
ents > - added version + help information Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: JDK-8323695: updated help to describe new command-line arguments - Changes: - all: https://git.openjdk.org/jdk/pull/1

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12) [v2]

2024-02-02 Thread Laurent Bourgès
ents > - added version + help information Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: JDK-8323695: RenderPerf 24.2 enhancements: - improved stddev estimation based on InterQuantileRange (IQR for fps) or MeanAbsoluteDeviati

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12)

2024-01-21 Thread Laurent Bourgès
On Thu, 18 Jan 2024 21:35:37 GMT, Phil Race wrote: >> Of course, I will make constant Font instances (no new Font() in benchmark >> code!) and use family name (Dialog or SansSerif), what do you prefer? > > either dialog or sansserif. Dialog is the default font so perhaps that. Dialog by default

Re: RFR: 8323170 - j2dbench is using outdated javac source/target to be able to build by itself

2024-01-18 Thread Laurent Bourgès
On Mon, 8 Jan 2024 13:03:22 GMT, Jiří Vaněk wrote: > This PR is fixig to-old values of javac source/target for jdk22. > Note, that jdk21 suffers the same, only the target values have to be 8. I > will be happy to backport this cange to jdk17 later. > > Note, that considering the rolling release

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12)

2024-01-18 Thread Laurent Bourgès
On Mon, 15 Jan 2024 11:14:40 GMT, Alexey Ushakov wrote: >> - new executor modes (buffer & volatile) >> - support parallel rendering on several frames and / or screens >> - added robot calibration + optionally use rounded duration to min frame >> latency (120Hz) >> - give more statistics in verbo

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12)

2024-01-18 Thread Laurent Bourgès
On Tue, 16 Jan 2024 21:46:24 GMT, Phil Race wrote: >> - new executor modes (buffer & volatile) >> - support parallel rendering on several frames and / or screens >> - added robot calibration + optionally use rounded duration to min frame >> latency (120Hz) >> - give more statistics in verbose (-

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12)

2024-01-15 Thread Laurent Bourgès
On Fri, 12 Jan 2024 21:34:32 GMT, Laurent Bourgès wrote: > - new executor modes (buffer & volatile) > - support parallel rendering on several frames and / or screens > - added robot calibration + optionally use rounded duration to min frame > latency (120Hz) > - give more st

Re: RFR: JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 [v2]

2024-01-15 Thread Laurent Bourgès
On Fri, 12 Jan 2024 20:21:52 GMT, Harshitha Onkar wrote: >> ShapeNotSetSometimes.java fails intermittently on macOS 14. Following is a >> test stabilization fix for macOS 14. With the added delays >> ShapeNotSetSometimes.java passes on older versions of macOS as well as on >> macOS 14.1, 14.2.

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12)

2024-01-13 Thread Laurent Bourgès
On Fri, 12 Jan 2024 21:34:32 GMT, Laurent Bourgès wrote: > - new executor modes (buffer & volatile) > - support parallel rendering on several frames and / or screens > - added robot calibration + optionally use rounded duration to min frame > latency (120Hz) > - give more st

RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12)

2024-01-13 Thread Laurent Bourgès
- new executor modes (buffer & volatile) - support parallel rendering on several frames and / or screens - added robot calibration + optionally use rounded duration to min frame latency (120Hz) - give more statistics in verbose (-v) - added new command-line arguments - added version + help informa

Re: RenderPerf 23.11

2023-12-08 Thread Laurent Bourgès
OCA, but under OCA you can only > contribute code for which you own the copyright. So in this case, JetBrains > would have to contribute the code. > > I understand that it is just a test, but still. > > Best regards, > Volker > > Laurent Bourgès schrieb am Fr., 8.

RenderPerf 23.11

2023-12-08 Thread Laurent Bourgès
Hi, I forked & improved RenderPerf test from jetbrains runtime ie openjdk/test/jdk/performance... See RenderPerf 23.11 release for new features: https://github.com/bourgesl/RenderPerf/releases/tag/v23_11 FYI I will fix minor things and will contribute it back to openjdk as PR for early 2024. Ch

Integrated: JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-21 Thread Laurent Bourgès
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote: > For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts This pull request has now been integrated. Changeset: a876beb6 Author:Laurent Bourgè

Re: RFR: JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes [v2]

2023-10-21 Thread Laurent Bourgès
On Fri, 20 Oct 2023 18:05:19 GMT, Damon Nguyen wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed 2 missing white spaces > > test/jdk/sun/java2d/marlin/TestCreateStrokedSha

Re: RFR: JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes [v2]

2023-10-21 Thread Laurent Bourgès
> For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed 2 missing white

Re: RFR: JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-20 Thread Laurent Bourgès
On Tue, 10 Oct 2023 21:24:47 GMT, Phil Race wrote: >> For stroked shapes (no Renderer use), the min-join-error check is disabled. >> Added new jtreg test to verify join using pixel counts > > Let me submit a test task to verify. As only @prrace approved, is it enough for me to integrate this PR

Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-13 Thread Laurent Bourgès
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote: > For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts @johanvos could you review this fix? - PR Comment: https://git.openjdk.org/jdk/pull

Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-12 Thread Laurent Bourgès
On Tue, 10 Oct 2023 21:24:47 GMT, Phil Race wrote: >> For stroked shapes (no Renderer use), the min-join-error check is disabled. >> Added new jtreg test to verify join using pixel counts > > Let me submit a test task to verify. Thanks @prrace for approval. @kevinrushforth could you review this

Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-10 Thread Laurent Bourgès
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote: > For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts @prrace could you review this simple fix for jdk22, thatcan be backported to 21

RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-01 Thread Laurent Bourgès
For stroked shapes (no Renderer use), the min-join-error check is disabled. Added new jtreg test to verify join using pixel counts - Commit messages: - fixed line endings - JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes by disabling the min-j

Re: RFR: 8313697: [XWayland][Screencast] consequent getPixelColor calls are slow [v3]

2023-08-15 Thread Laurent Bourgès
On Mon, 14 Aug 2023 22:46:16 GMT, Alexander Zvegintsev wrote: >> src/java.desktop/unix/classes/sun/awt/screencast/ScreencastHelper.java line >> 127: >> >>> 125: @Override >>> 126: public void run() { >>> 127: closeSession(); >> >> What happen if the "cl

Re: RFR: 8311666: Disabled tests in test/jdk/sun/java2d/marlin

2023-07-08 Thread Laurent Bourgès
On Fri, 7 Jul 2023 23:20:05 GMT, Liam Miller-Cushon wrote: > Please review this fix for JDK-8311666, which adds missing jtreg `/* @test > */` comments to several tests in `test/jdk/sun/java2d/marlin` which were not > being run. The test dates are from 2010 for pisces, moved into marlin tests o

Re: RFR: 8302671: libawt has a memmove decay error

2023-02-17 Thread Laurent Bourgès
On Thu, 16 Feb 2023 15:33:51 GMT, Julian Waters wrote: > In libawt, the size parameter is issued by a sizeof on an array, which as > expected decays into a pointer and breaks the cleanup code by giving the > incorrect size Or use #define KBD_BUF_LEN 256 And use it explicitely in array init & m

Re: RFR: 8302671: libawt has a memmove decay error

2023-02-16 Thread Laurent Bourgès
On Thu, 16 Feb 2023 15:33:51 GMT, Julian Waters wrote: > In libawt, the size parameter is issued by a sizeof on an array, which as > expected decays into a pointer and breaks the cleanup code by giving the > incorrect size LGTM. Length is 256*sizeof(BYTE) = 256. - PR: https://gi

Enhancing java2d Image classes & pipelines to support HDR (10b) or 16bits RGBA

2023-01-26 Thread Laurent Bourgès
Hi, I would like enhancing Java Image classes (awt / java2D) to support natively new image types with their use cases: - BGRA (inverse RGBA) with both byte, integer & PREMUL variants (4x8bits), as supported by skia, metal, vulkan apis - 10 or 16 bits per RGBA component to support HDR or 64bits ima

Re: RFR: 8300725: Improve performance of ColorConvertOp for default destinations with alpha

2023-01-21 Thread Laurent Bourgès
On Fri, 20 Jan 2023 06:02:53 GMT, Sergey Bylokhov wrote: > The "default destination" for the ColorConverOp is used when the user passes > "null" as the DST parameter. In this case, the "ColorConverOp.filter" creates > the default image and uses ComponentColorModel: 8 bits per color component >

Re: RFR: 8300167: Add validation of the raster's layout before using in native

2023-01-16 Thread Laurent Bourgès
On Sat, 14 Jan 2023 07:23:18 GMT, Sergey Bylokhov wrote: > Currently, we always validate image layouts passed from java to native, > except for some types of rasters. One of the reasons why the rasters are > skipped is that they are not public and have their own validation during > constructio

Re: [jdk20] RFR: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java

2022-12-22 Thread Laurent Bourgès
On Thu, 22 Dec 2022 05:39:54 GMT, Ajit Ghaisas wrote: > - Regression test test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java was > added as part of [JDK-8291266](https://bugs.openjdk.org/browse/JDK-8291266). > We had to revert [JDK-8291266](https://bugs.openjdk.org/browse/JDK-8291266) > whil

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

2022-12-09 Thread Laurent Bourgès
On Thu, 8 Dec 2022 19:41:16 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

2022-12-08 Thread Laurent Bourgès
On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: Quick fix for openjdk20

2022-12-07 Thread Laurent Bourgès
a long time > in production. It helped us with scrolling performance on 4K monitors. The > suggested property could help to adjust the buffer for the needs of > particular application. > > Best Regards, > Alexey > > On 7 Dec 2022, at 11:37, Laurent Bourgès > wrote: >

Re: Quick fix for openjdk20

2022-12-07 Thread Laurent Bourgès
ged buffer for a long time > in production. It helped us with scrolling performance on 4K monitors. The > suggested property could help to adjust the buffer for the needs of > particular application. > > Best Regards, > Alexey > > On 7 Dec 2022, at 11:37, Laurent Bourgès >

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-07 Thread Laurent Bourgès
On Wed, 7 Dec 2022 08:35:52 GMT, Thomas Stuefe wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment for snprintf_checked > > src/hotspot/os/bsd/attachListener_bsd.cpp line 260: > >> 258: // name ("load"

Quick fix for openjdk20

2022-12-07 Thread Laurent Bourgès
} protected static int align(final int val, final int norm) { final int ceil = (int)Math.ceil( ((float) val) / norm); return ceil * norm; } ]]] Would you accept such late change for openjdk20 ? Cheers, Laurent Bourgès

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v17]

2022-12-07 Thread Laurent Bourgès
On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8269806: Emoji rendering on Linux [v16]

2022-12-02 Thread Laurent Bourgès
On Thu, 1 Dec 2022 19:38:44 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or >> bilin

Re: RFR: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit

2022-11-28 Thread Laurent Bourgès
On Sun, 27 Nov 2022 06:26:48 GMT, Sergey Bylokhov wrote: > I have found that drawing the BufferedImage.4BYTE_ABGR_PRE to the > INT_ARGB_PRE image caused java2d to do an additional conversion from/to ARGB > format. That conversion is done via a native > [loop](https://github.com/openjdk/jdk/blo

Re: RFR: 8269806: Emoji rendering on Linux [v13]

2022-11-28 Thread Laurent Bourgès
On Tue, 27 Sep 2022 11:14:11 GMT, Nikita Gubarkov wrote: >> Nikita Gubarkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix italic and bold styles for colored outline glyphs > > 💅 @YaaZ Could you merge with latest openjdk20 master t

Integrated: JDK-8297230: Update Marlin2D to 0.9.4.6

2022-11-23 Thread Laurent Bourgès
On Thu, 17 Nov 2022 22:51:00 GMT, Laurent Bourgès wrote: > Initial PR This pull request has now been integrated. Changeset: 5b3d86f2 Author: Laurent Bourgès URL: https://git.openjdk.org/jdk/commit/5b3d86f2296ec011f70cebe80a221b8a6f926912 Stats: 4286 lines in 38 files chan

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v4]

2022-11-23 Thread Laurent Bourgès
On Wed, 23 Nov 2022 01:56:30 GMT, Sergey Bylokhov wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed class header comment > > test/jdk/sun/java2d/marlin/HugePolygonC

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v4]

2022-11-21 Thread Laurent Bourgès
On Mon, 21 Nov 2022 10:15:01 GMT, Laurent Bourgès wrote: >> Initial PR > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed class header comment A phil approved early, I fixed comments and added

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v4]

2022-11-21 Thread Laurent Bourgès
> Initial PR Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed class header comment - Changes: - all: https://git.openjdk.org/jdk/pull/11225/files - new: https://git.openjdk.org/jdk/pull/11225/files/0ef50

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v3]

2022-11-20 Thread Laurent Bourgès
On Sun, 20 Nov 2022 11:15:33 GMT, Sergey Bylokhov wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added HugePolygonClipTest > > src/java.desktop/share/classes/sun/java2d/marlin/Ar

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v3]

2022-11-19 Thread Laurent Bourgès
On Sat, 19 Nov 2022 01:43:59 GMT, Phil Race wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added HugePolygonClipTest > > src/java.desktop/share/classes/sun/java2d/marlin/Ma

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v3]

2022-11-19 Thread Laurent Bourgès
> Initial PR Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: added HugePolygonClipTest - Changes: - all: https://git.openjdk.org/jdk/pull/11225/files - new: https://git.openjdk.org/jdk/pull/11225/files/86364

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v2]

2022-11-19 Thread Laurent Bourgès
> Initial PR Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed typos - Changes: - all: https://git.openjdk.org/jdk/pull/11225/files - new: https://git.openjdk.org/jdk/pull/11225/files/4516b8de..86364

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6

2022-11-18 Thread Laurent Bourgès
On Thu, 17 Nov 2022 22:51:00 GMT, Laurent Bourgès wrote: > Initial PR Thanks, phil. I will write anyway a new test for java2d backport of https://github.com/bourgesl/jfx/blob/0e739a9cda59e4ebfe7676278b3d35c3043ad535/tests/system/src/test/java/test/com/sun/marlin/HugePolygonClipTest.j

RFR: JDK-8297230: Update Marlin2D to 0.9.4.6

2022-11-17 Thread Laurent Bourgès
Initial PR - Commit messages: - JDK-8297230: Update Marlin2D to 0.9.4.6 Changes: https://git.openjdk.org/jdk/pull/11225/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11225&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297230 Stats: 4142 lines in 37 files changed

Re: RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines [v4]

2022-06-19 Thread Laurent Bourgès
On Fri, 10 Jun 2022 01:24:48 GMT, Jeremy wrote: >> Previously when you drew a line that moved exactly (+0, +0) with a miter >> stroke the Stroker class acted like a horizontal miter was appropriate. Now >> we abort instead, so no miter is applied. >> >> The new unit test tests the original ste

Re: Re[4]: Any interest in JDK-8264999 (stroke miter edge case in Marlin)

2022-06-16 Thread Laurent Bourgès
2022, 00:07, Laurent Bourgès a écrit : > Sorry, I corrected 2 typo error: > > I quickly tested my modified patch with the extra condition and noticed no > difference in my tests + fixed the original reproducer code. > > Laurent > > Le ven. 3 juin 2022, 00:00, Laurent