On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla wrote:
> If you're currently reviewing this PR, thank you!
> Most fixes here are according to the reports by the since checker tool in
> #18934 and are pretty simple.
>
> To make reviewing easier
> - `BasicSliderUI` has the c
On Wed, 26 Jun 2024 09:52:38 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> -
und instances of `@since 1.1` in the other packages but
> `javax/swing/plaf/synth/package-info.java` might be worth checking as most
> classes there had no `@since`.
Nizar Benalla has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contain
und instances of `@since 1.1` in the other packages but
> `javax/swing/plaf/synth/package-info.java` might be worth checking as most
> classes there had no `@since`.
Nizar Benalla has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> -
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> -
On Sun, 12 May 2024 00:37:26 GMT, Nizar Benalla wrote:
> Simple code cleanup.
> If you're reviewing this, thanks.
This pull request has now been integrated.
Changeset: 1ff5acda
Author: Nizar Benalla
Committer: Phil Race
URL:
https://git.openjdk.org/jdk/
On Sun, 12 May 2024 00:37:26 GMT, Nizar Benalla wrote:
> Simple code cleanup.
> If you're reviewing this, thanks.
keep alive
-
PR Comment: https://git.openjdk.org/jdk/pull/19197#issuecomment-2158219905
On Mon, 3 Jun 2024 20:02:12 GMT, Sergey Bylokhov wrote:
>>> Hmm, the _explicit_ default constructor was added in JDK 16, but it was
>>> implicit before then. So I am not 100% sure what the right answer is - the
>>> same as the class, or when it was explicitly added.
>>
>> I believe there was
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> -
On Wed, 29 May 2024 11:38:02 GMT, Alexey Ivanov wrote:
> Why is it? There's history beyond 10 and 9
As I've explained before, a program relying on the historical data built into
`javac` can only give accurate reports for newer releases. As that data only
goes back so far. I was left to
und instances of `@since 1.1` in the other packages but
> `javax/swing/plaf/synth/package-info.java` might be worth checking as most
> classes there had no `@since`.
Nizar Benalla has updated the pull request incrementally with one additional
commit since the last revision:
Swing was a
On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla wrote:
> If you're currently reviewing this PR, thank you!
> Most fixes here are according to the reports by the since checker tool in
> #18934 and are pretty simple.
>
> To make reviewing easier
> - `BasicSliderUI` has the c
On Tue, 14 May 2024 21:53:24 GMT, Phil Race wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor `public
Simple code cleanup.
If you're reviewing this, thanks.
-
Commit messages:
- (C)
- Add `@since` to package-info.java in `jdk.jsobject`
Changes: https://git.openjdk.org/jdk/pull/19197/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19197=00
Issue:
If you're currently reviewing this PR, thank you!
Most fixes here are according to the reports by the since checker tool in
#18934 and are pretty simple.
To make reviewing easier
- `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a
long time so the default constructor
16 matches
Mail list logo
