Re: RFR: 8297191 : [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

2024-06-21 Thread Renjith Kannath Pariyangad
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > This fix will resolve page range not printing proper pages if the rage begin > from 2 or above on Mac machines. > I have verified the manual range related tests like PageRanges.java, >

Re: RFR: 8297191 : [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

2024-06-21 Thread Renjith Kannath Pariyangad
On Thu, 20 Jun 2024 18:40:29 GMT, Alexey Ivanov wrote: > Do you refer to > [`test/jdk/java/awt/print/PrinterJob/PageRanges.java`](https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/print/PrinterJob/PageRanges.java) > and >

Re: RFR: 8297191 : [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

2024-06-20 Thread Renjith Kannath Pariyangad
On Tue, 18 Jun 2024 21:48:54 GMT, Alisen Chung wrote: > why was this attribute added, and why is it being removed now? is the bug in > SunPageSelection? I am not sure why this attribute added, but noticed for other OS's this workflow will be taken care by _RasterPrinterJob_ . With this

RFR: 8297191 : [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

2024-06-17 Thread Renjith Kannath Pariyangad
Hi Reviewers, This fix will resolve page range not printing proper pages if the rage begin from 2 or above on Mac machines. I have verified the manual range related tests like PageRanges.java, ClippedImages.java and test.java and confirmed its fixing the issue. Please review and let me know

Integrated: JDK-8333360 : PrintNullString.java doesn't use float arguments

2024-06-11 Thread Renjith Kannath Pariyangad
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > I have updated the test case with passing float value for evaluation and a > typo. Please review and let me know your suggestions if any. This pull request has now been integrated. Changeset: 86

RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments

2024-06-04 Thread Renjith Kannath Pariyangad
Hi Reviewers, I have updated the test case with passing float value for evaluation and a typo. Please review and let me know your suggestions if any. - Commit messages: - JDK-860 : PrintNullString.java doesn't use float arguments Changes:

Re: RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]

2024-04-19 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Added pageloader cancel before new page creation along with code > restructuring. Moved all page loading calls inside synchronize to make it > thread safe. > > Regards, > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementa

Re: RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v2]

2024-04-19 Thread Renjith Kannath Pariyangad
On Thu, 18 Apr 2024 16:41:34 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Suggesions updated > > src/java.desktop/share/classes/javax/swing/JEdito

Re: RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v2]

2024-04-19 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Added pageloader cancel before new page creation along with code > restructuring. Moved all page loading calls inside synchronize to make it > thread safe. > > Regards, > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementa

Integrated: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame

2024-04-18 Thread Renjith Kannath Pariyangad
On Thu, 4 Apr 2024 12:07:46 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > I have updated the test with PassFailJFrame along with printer availability > check. Please review and let me know your suggestions. > > Renjith. This pull request has now been inte

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Renjith Kannath Pariyangad
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renji

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Renjith Kannath Pariyangad
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renji

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-08 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the test with PassFailJFrame along with printer availability > check. Please review and let me know your suggestions. > > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementally with two additional commits since

RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled

2024-04-08 Thread Renjith Kannath Pariyangad
Hi Reviewers, Added pageloader cancel before new page creation along with code restructuring. Moved all page loading calls inside synchronize to make it thread safe. Regards, Renjith. - Commit messages: - Removed space - JDK-8328977 : JEditorPane.setPage not thread-safe,

RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame

2024-04-04 Thread Renjith Kannath Pariyangad
Hi Reviewers, I have updated the test with PassFailJFrame along with printer availability check. Please review and let me know your suggestions. Renjith. - Commit messages: - JDK-8329322:Convert PageFormat/Orient.java to use PassFailJFrame Changes:

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v17]

2024-04-02 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Integrated: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1

2024-04-02 Thread Renjith Kannath Pariyangad
On Mon, 29 Jan 2024 06:24:29 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review

Integrated: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2

2024-04-02 Thread Renjith Kannath Pariyangad
On Mon, 29 Jan 2024 06:52:01 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v16]

2024-04-02 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Integrated: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3

2024-04-01 Thread Renjith Kannath Pariyangad
On Mon, 29 Jan 2024 07:22:57 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v14]

2024-04-01 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v15]

2024-03-31 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v14]

2024-03-31 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Integrated: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs

2024-03-21 Thread Renjith Kannath Pariyangad
On Thu, 14 Mar 2024 11:52:09 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > I have updated the test with PassFailJFrame with information panel, earlier > this was informed through terminal. > Please review and let me know your suggestions if any. This pull reque

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v13]

2024-03-19 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v4]

2024-03-19 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the test with PassFailJFrame with information panel, earlier > this was informed through terminal. > Please review and let me know your suggestions if any. Renjith Kannath Pariyangad has updated the pull request incrementally with one addition

Re: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v3]

2024-03-15 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the test with PassFailJFrame with information panel, earlier > this was informed through terminal. > Please review and let me know your suggestions if any. Renjith Kannath Pariyangad has updated the pull request incrementally with two add

Re: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]

2024-03-15 Thread Renjith Kannath Pariyangad
On Fri, 15 Mar 2024 03:33:24 GMT, Tejesh R wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Added summary > > test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.j

Re: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]

2024-03-15 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the test with PassFailJFrame with information panel, earlier > this was informed through terminal. > Please review and let me know your suggestions if any. Renjith Kannath Pariyangad has updated the pull request incrementally with one addition

Re: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs

2024-03-15 Thread Renjith Kannath Pariyangad
On Fri, 15 Mar 2024 03:43:13 GMT, Tejesh R wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame with information panel, earlier >> this was informed through terminal. >> Please review and let me know your suggestions if any. > >

Re: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs

2024-03-15 Thread Renjith Kannath Pariyangad
On Fri, 15 Mar 2024 03:31:32 GMT, Tejesh R wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame with information panel, earlier >> this was informed through terminal. >> Please review and let me know your suggestions if any. > >

RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs

2024-03-14 Thread Renjith Kannath Pariyangad
Hi Reviewers, I have updated the test with PassFailJFrame with information panel, earlier this was informed through terminal. Please review and let me know your suggestions if any. - Commit messages: - Removed extra space before instruction lines - Updated with message - Use

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v13]

2024-03-07 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v12]

2024-03-07 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v12]

2024-03-06 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v11]

2024-03-06 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v10]

2024-03-05 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v11]

2024-03-05 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]

2024-03-05 Thread Renjith Kannath Pariyangad
On Tue, 5 Mar 2024 13:07:30 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Updated instruction > > test/jdk/java/awt/print/PrinterJob/Collate2DPrint

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v12]

2024-03-05 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v9]

2024-03-03 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]

2024-03-03 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v11]

2024-03-03 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v9]

2024-02-23 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v8]

2024-02-22 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Integrated: 8321192 : j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test if there's no printer

2024-02-22 Thread Renjith Kannath Pariyangad
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > I have updated the test with 'PassFailJFrame' with programmatically > generating image and print , please review and let me know your suggestions. This pull request has now been integrated.

Re: RFR: 8321192 : j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test if there's no printer [v3]

2024-02-22 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > I have updated the test with 'PassFailJFrame' with programmatically > generating image and print , please review and let me know your suggestions. Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v8]

2024-02-22 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v7]

2024-02-22 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v7]

2024-02-22 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v10]

2024-02-22 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v9]

2024-02-14 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v8]

2024-02-14 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v7]

2024-02-14 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v6]

2024-02-13 Thread Renjith Kannath Pariyangad
On Tue, 13 Feb 2024 10:43:38 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Fixed compiler error > > test/jdk/java/awt/print/PrinterJob/Cancel

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v3]

2024-02-13 Thread Renjith Kannath Pariyangad
On Thu, 8 Feb 2024 15:15:39 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disposed g2D object and similar test parm into one line > > test

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v6]

2024-02-13 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v5]

2024-02-13 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v4]

2024-02-13 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v6]

2024-02-13 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v3]

2024-02-13 Thread Renjith Kannath Pariyangad
On Fri, 9 Feb 2024 11:04:49 GMT, Renjith Kannath Pariyangad wrote: >> test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 40: >> >>> 38: * @library /test/lib /java/awt/regtesthelpers >>> 39: * @build PassFailJFrame jtreg.SkippedException >>> 4

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v5]

2024-02-13 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v4]

2024-02-12 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v6]

2024-02-12 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8321192 : j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test if there's no printer [v2]

2024-02-12 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > I have updated the test with 'PassFailJFrame' with programmatically > generating image and print , please review and let me know your suggestions. Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last

RFR: 8321192 : j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test if there's no printer

2024-02-09 Thread Renjith Kannath Pariyangad
Hi Reviewers, I have updated the test with 'PassFailJFrame' with programmatically generating image and print , please review and let me know your suggestions. - Commit messages: - JDK-8321192 : j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test if there's no printer

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-09 Thread Renjith Kannath Pariyangad
On Wed, 7 Feb 2024 17:48:41 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disposed g2D object and similar test parm into one line > > test

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v5]

2024-02-09 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v4]

2024-02-09 Thread Renjith Kannath Pariyangad
On Thu, 8 Feb 2024 12:03:19 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Review comments integrated > > test/jdk/java/awt/print/PrinterJob/Draw

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v4]

2024-02-08 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v3]

2024-02-01 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-01 Thread Renjith Kannath Pariyangad
On Wed, 31 Jan 2024 23:07:45 GMT, Harshitha Onkar wrote: >> Updating the size impacting layouts, its visible in my system. > > With the present frame size and layout settings, Set Paper" and "Print" > options are not visible. > >

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-02-01 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-31 Thread Renjith Kannath Pariyangad
On Wed, 31 Jan 2024 23:07:45 GMT, Harshitha Onkar wrote: >> Updating the size impacting layouts, its visible in my system. > > With the present frame size and layout settings, Set Paper" and "Print" > options are not visible. > >

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v2]

2024-01-31 Thread Renjith Kannath Pariyangad
On Wed, 31 Jan 2024 21:53:25 GMT, Alisen Chung wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Capitalized static final variables > > test/jdk/java/awt/print/Print

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v2]

2024-01-31 Thread Renjith Kannath Pariyangad
On Wed, 31 Jan 2024 21:51:16 GMT, Alisen Chung wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Capitalized static final variables > > test/jdk/java/awt/print/PrinterJob/

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v3]

2024-01-31 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v2]

2024-01-31 Thread Renjith Kannath Pariyangad
On Wed, 31 Jan 2024 09:22:41 GMT, Tejesh R wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Capitalized static final variables > > test/jdk/java/awt/print/PrinterJob

Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v2]

2024-01-30 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-30 Thread Renjith Kannath Pariyangad
On Tue, 30 Jan 2024 00:14:05 GMT, Harshitha Onkar wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Suggestions integrated > > test/jdk/java/awt/print/PrinterJob/ValidateP

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-29 Thread Renjith Kannath Pariyangad
On Tue, 30 Jan 2024 06:30:00 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >&g

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v2]

2024-01-29 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-29 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3

2024-01-28 Thread Renjith Kannath Pariyangad
Hi Reviewers, Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured. Please review and let me know your suggestions. Regards, Renjith - Commit messages: - JDK-8324808 :

RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2

2024-01-28 Thread Renjith Kannath Pariyangad
Hi Reviewers, Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured. Please review and let me know your suggestions. Regards, Renjith - Commit messages: - JDK-8324807 :

RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close

2024-01-28 Thread Renjith Kannath Pariyangad
Hi Reviewers, Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured. Please review and let me know your suggestions. Regards, Renjith - Commit messages: - JDK-8320676 :

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-01-28 Thread Renjith Kannath Pariyangad
On Fri, 26 Jan 2024 00:27:45 GMT, Harshitha Onkar wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Fixed whitespace errors > > @Renjithkannath There are many test ch

Withdrawn: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close

2024-01-28 Thread Renjith Kannath Pariyangad
On Thu, 25 Jan 2024 04:52:15 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-01-24 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-24 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith

RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close

2024-01-24 Thread Renjith Kannath Pariyangad
Hi Reviewers, Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured. Please review and let me know your suggestions. Regards, Renjith - Commit messages: - JDK-8320676 :

Integrated: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix

2024-01-17 Thread Renjith Kannath Pariyangad
On Thu, 30 Nov 2023 03:34:08 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > There was a typo for color conversion instead of dstColorSpace function > srcColorSpace was used. Please review and let me know your suggestions if > any. > > Renjith. This pull re

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v16]

2024-01-16 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > There was a typo for color conversion instead of dstColorSpace function > srcColorSpace was used. Please review and let me know your suggestions if > any. > > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementally with one addit

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v15]

2024-01-15 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > There was a typo for color conversion instead of dstColorSpace function > srcColorSpace was used. Please review and let me know your suggestions if > any. > > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementally with one addit

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix

2024-01-12 Thread Renjith Kannath Pariyangad
On Fri, 12 Jan 2024 02:55:59 GMT, Sergey Bylokhov wrote: >> @mrserb , >> >> Did you mean to use the wrapper for the middle like `ColorSpace mid = >> createCS(ColorSpaceSelector.WRAPPED_PYCC);` , So we can achieve : >> >> **From** >> wrapper->icc_color_space->wrapper >>

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v14]

2024-01-12 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > There was a typo for color conversion instead of dstColorSpace function > srcColorSpace was used. Please review and let me know your suggestions if > any. > > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementally with one addit

Integrated: 8320673 : PageFormat/CustomPaper.java has no Pass/Fail buttons; multiple instructions

2024-01-11 Thread Renjith Kannath Pariyangad
On Wed, 27 Dec 2023 04:20:42 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > I have updated the test case. Now test has pass/fail option also test will > execute two time for covering different cases which are part of the test. > > Please review and let me kno

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix

2024-01-10 Thread Renjith Kannath Pariyangad
On Wed, 10 Jan 2024 19:50:45 GMT, Sergey Bylokhov wrote: >> Can this patch be covered by the new test? > >>I'm not sureā€¦ We want the filter to take another path, there could be a list >>of filters applied, if I understand @mrserb correctly. Sergey could be able >>to provide a more detailed

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v13]

2024-01-09 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > There was a typo for color conversion instead of dstColorSpace function > srcColorSpace was used. Please review and let me know your suggestions if > any. > > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementally with one addit

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v6]

2024-01-09 Thread Renjith Kannath Pariyangad
On Fri, 5 Jan 2024 16:16:51 GMT, Alexey Ivanov wrote: >> @mrserb for avoiding _ArrayIndexOutOfBoundsException_ I have modified >> `CS_GRAY `with `CS_LINEAR_RGB ` for making same number of channels. But the >> test passed irrespective of fix. >> Do you find any alternative way to fail the test

  1   2   3   >