On Fri, 15 Mar 2024 03:31:32 GMT, Tejesh R <t...@openjdk.org> wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 47:
>
>> 45: */
>> 46: public class SecurityDialogTest extends Frame {
>> 47: private static final String INSTRUCTIONS =
>
> `INSTRUCTIONS` can be moved inside main.
Most of the test with PassFailJFrame instruction stored as string inside class,
what additional benefit will get keeping it inside Main ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525799780
