This is a sound manual of style proposal. At some point I'd like all the
tests to conform to this. I would add on to say that @summary should be a
mandatory field, as the test in [2] lacks a short description.
SWinxy
On Thu, Feb 1, 2024 at 10:48 AM Aleksei Ivanov
wrote:
> Hello fel
apple.com/documentation/foundation/nsusernotification?language=objc>
in
macOS 10.8. Never worked with the WinRT before, though.
SWinxy
On Mon, Jan 8, 2024 at 4:06 PM Davide Perini
wrote:
> Thanks for the explanation Aleksei
> but can you explain me what is the OpenJDK direction please?
>
&g
found AudioAction, a subclass of BasicLookAndFeel, which I hope
helps in any way possible. I've never touched this part of java.desktop, so
I can't be of much help.
SWinxy
On Sat, Dec 23, 2023 at 4:07 PM wrote:
> Also: the discouraged methods (applet-based and sun.audio.Player) are
> friendly en
On Tue, 28 Feb 2023 20:09:04 GMT, SWinxy wrote:
>> Many `installDefaults` methods set the font, foreground, and background on
>> objects but their inverse methods `uninstallDefaults` do not remove them.
>> I've added an inverse method to remove the color
`XTextAreaPeer`.
>
> Sorry I couldn't write a test; I wasn't sure how I should have accessed the
> protected variable aside from creating extending classes for each class that
> changed.
>
> See also #6603, where this issue was discovered.
SWinxy has updated the pull reque
`XTextAreaPeer`.
>
> Sorry I couldn't write a test; I wasn't sure how I should have accessed the
> protected variable aside from creating extending classes for each class that
> changed.
>
> See also #6603, where this issue was discovered.
SWinxy has updated the pull request in
On Fri, 24 Feb 2023 00:07:20 GMT, Phil Race wrote:
> And if a default font prevents the FontUIResource from being installed, how
> does it get installed the in the first place ?
Perhaps that first time the component has no peer and it really is null ?
The font is null when it's created.
On Sat, 18 Feb 2023 22:18:52 GMT, SWinxy wrote:
> Please review this change which moves the parsing of the
> `awt.image.incrementaldraw` property from the static initializer block into
> the field itself by invoking `Boolean.parseBoolean()` on the system property
> getter.
&g
On Sat, 18 Feb 2023 22:18:52 GMT, SWinxy wrote:
> Please review this change which moves the parsing of the
> `awt.image.incrementaldraw` property from the static initializer block into
> the field itself by invoking `Boolean.parseBoolean()` on the system property
> getter.
&g
On Sun, 5 Feb 2023 09:55:27 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded
>> Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776)
>>
>> This is tracked in JBS as
>> - [JDK-8293776 : Adds CSS 4 and
On Sun, 25 Sep 2022 04:01:26 GMT, SWinxy wrote:
> Some also had two separate methods to check equality, one calling the other.
> Objects.equals() is used in some places as a replacement for a local copy of
> the function. In the end, the equals methods become quicker to u
On Wed, 22 Feb 2023 20:49:43 GMT, SWinxy wrote:
>> Some also had two separate methods to check equality, one calling the other.
>> Objects.equals() is used in some places as a replacement for a local copy of
>> the function. In the end, the equals methods become qui
more in line with other equality
> methods in the JDK.
SWinxy has updated the pull request with a new target base due to a merge or a
rebase. The incremental webrev excludes the unrelated changes brought in by the
merge/rebase. The pull request contains seven additional commits since the
On Fri, 9 Dec 2022 00:38:47 GMT, Sergey Bylokhov wrote:
>> Looks like there are issues with my PR that I haven't noticed. Shoot.
>
>> Looks like there are issues with my PR that I haven't noticed. Shoot.
>
> While you are working on it you can move the PR to the draft state.
@mrserb would you
On Wed, 22 Feb 2023 00:02:10 GMT, Damon Nguyen wrote:
>> Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in
>> a JButton in Aqua L The new issue comes from having text inside the HTML
>> as the button's text. If an icon is used, this icon exceeds the bounds of
>> the
On Tue, 14 Feb 2023 23:02:16 GMT, Damon Nguyen wrote:
>> Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in
>> a JButton in Aqua L The new issue comes from having text inside the HTML
>> as the button's text. If an icon is used, this icon exceeds the bounds of
>> the
On Sun, 19 Feb 2023 23:52:52 GMT, Archie L. Cobbs wrote:
> This bug relates to the "potentially ambiguous overload" warning which is
> enabled by `-Xlint:overloads`.
>
> The warning detects certain ambiguities that can cause problems for lambdas.
> For example, consider the interface
On Mon, 20 Feb 2023 08:10:54 GMT, Julian Waters wrote:
> In jabswitch, main is defined as `void main()`, which requires an explicit
> exit call whenever an error occurs, and extra error checking code on our
> part. Visual C++ will automatically convert all instances of `void main()` to
>
On Sun, 19 Feb 2023 09:35:53 GMT, SWinxy wrote:
>> Many `installDefaults` methods set the font, foreground, and background on
>> objects but their inverse methods `uninstallDefaults` do not remove them.
>> I've added an inverse method to remove the color
`XTextAreaPeer`.
>
> Sorry I couldn't write a test; I wasn't sure how I should have accessed the
> protected variable aside from creating extending classes for each class that
> changed.
>
> See also #6603, where this issue was discovered.
SWinxy has updated the pull request inc
On Sun, 19 Feb 2023 09:35:53 GMT, SWinxy wrote:
>> Many `installDefaults` methods set the font, foreground, and background on
>> objects but their inverse methods `uninstallDefaults` do not remove them.
>> I've added an inverse method to remove the color
`XTextAreaPeer`.
>
> Sorry I couldn't write a test; I wasn't sure how I should have accessed the
> protected variable aside from creating extending classes for each class that
> changed.
>
> See also #6603, where this issue was discovered.
SWinxy has updated the pull request with
Please review this change which moves the parsing of the
`awt.image.incrementaldraw` property from the static initializer block into the
field itself by invoking `Boolean.parseBoolean()` on the system property getter.
Hopefully in the near future we can do away with `AccessController`s and
On Tue, 14 Feb 2023 20:41:39 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue
> was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)
> for building failure, and
On Thu, 9 Feb 2023 09:51:10 GMT, Andrey Turbanov wrote:
> There is only add/iterator/indexOf calls on this list. No removes from the
> head or something like this. ArrayList should be preferred as more efficient
> and widely used (more chances for JIT) collection
As usual I prefer `List<>` as
On Fri, 20 Jan 2023 12:01:06 GMT, Daniel Jeliński wrote:
>> Please review this patch that fixes and re-enables a few warnings in libawt
>> compilation.
>>
>> Verified that debug and release builds finish successfully on Win, Mac and
>> Linux. Also verified that client libs tests still pass.
>
On Fri, 27 Jan 2023 13:26:28 GMT, Andrey Turbanov wrote:
> There is only add/iterator calls on this list. No removes from the head or
> something like this. Not sure why LinkedList was used, but ArrayList should
> be preferred as more efficient and widely used (more chances for JIT)
>
On Mon, 16 Jan 2023 20:30:08 GMT, SWinxy wrote:
> BasicLookAndFeel checks an instanceof in its `AWTEventHelper` listener class,
> but the result of that will always be non-null. The check should be removed.
This pull request has now been integrated.
Changeset: 597a9a48
Author:
I support this! HDR support would be nice, but if there are issues with
color spaces, that to me is a higher priority.
What do you mean to fix in the macros and graphics pipelines?
On Thu, Jan 26, 2023 at 5:11 AM Laurent Bourgès
wrote:
> Hi,
>
> I would like enhancing Java Image classes (awt /
On Thu, 26 Jan 2023 20:58:45 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of numeric array have default values after
> allocations - 0.
Marked as reviewed by swi...@github.com (no known OpenJDK
BasicLookAndFeel checks an instanceof in its `AWTEventHelper` listener class,
but the result of that will always be non-null. The check should be removed.
-
Commit messages:
- BasicLookAndFeel does not need to check for null after checking for type
Changes:
On Mon, 19 Dec 2022 21:43:26 GMT, Alexey Ivanov wrote:
>>> This change cause 23 test cases to fail across the platforms:
>>
>> So I thought we'd got past the testing since a CSR was proposed. The CSR
>> should have waited.
>>
>>>
>>> * `sanity/client/SwingSet/src/SwingSet2DemoTest.java`;
>>>
On Sat, 28 Jan 2023 14:54:38 GMT, Andrey Turbanov wrote:
> There is only add/iterator calls on this list. No removes from the head or
> something like this. Not sure why LinkedList was used, but ArrayList should
> be preferred as more efficient and widely used (more chances for JIT)
>
On Fri, 27 Jan 2023 17:00:48 GMT, Alexander Scherbatiy
wrote:
>> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font
>> coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE
>> detection by checking SLES os name property in `/etc/os-release` file.
>>
On Fri, 27 Jan 2023 10:26:10 GMT, Prasanta Sadhukhan
wrote:
> When the Action.SELECTED_KEY property action is assigned to ToggleButton and
> an accelerator key binding is mapped to the action, then pressing the
> accelerator key binding does not toggle the toggle button.
> This is because
On Thu, 26 Jan 2023 09:24:25 GMT, Andrey Turbanov wrote:
>> That is not about the default values in the array but about missing
>> initialization of `bandOffsets`, which we will skip intentionally. So it
>> won't raise the question later why we initiated the Indices and not offsets.
>
> I've
On Fri, 9 Dec 2022 00:35:48 GMT, Sergey Bylokhov wrote:
>> Some also had two separate methods to check equality, one calling the other.
>> Objects.equals() is used in some places as a replacement for a local copy of
>> the function. In the end, the equals methods become quicker to understand
On Sun, 25 Sep 2022 04:01:26 GMT, SWinxy wrote:
> Some also had two separate methods to check equality, one calling the other.
> Objects.equals() is used in some places as a replacement for a local copy of
> the function. In the end, the equals methods become quicker to u
On Sun, 25 Sep 2022 06:21:43 GMT, ExE Boss wrote:
>> Some also had two separate methods to check equality, one calling the other.
>> Objects.equals() is used in some places as a replacement for a local copy of
>> the function. In the end, the equals methods become quicker to understand
>>
Some also had two separate methods to check equality, one calling the other.
Objects.equals() is used in some places as a replacement for a local copy of
the function. In the end, the equals methods become quicker to understand their
checks, more condensed, and becomes more in line with other
On Wed, 25 Jan 2023 16:13:00 GMT, Andy Goryachev wrote:
> do we know why this test is failing?
Doesn't matter; it's javadoc changes only. Pre-submit tests randomly fail
sometimes for no good reason.
-
PR: https://git.openjdk.org/jdk/pull/10975
On Mon, 12 Dec 2022 13:06:09 GMT, Alexey Ivanov wrote:
>> Looks good to me.
>>
>> In the description above: “…invoked one per property…”, it shoud be “once”.
>>
>> I think there's room for improvement. However, this is an internal-only
>> class.
>
>> I think there's room for improvement.
On Mon, 23 Jan 2023 17:20:41 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of numeric array have default values after
> allocations - 0.
Marked as reviewed by swi...@github.com (no known OpenJDK
On Mon, 23 Jan 2023 06:11:46 GMT, Prasanta Sadhukhan
wrote:
> I think it was mistakenly done
I agree. All classes would probably be fine if their code only referenced their
protected object instead of the `e.getSource()` one. If they aren't, then that
means there are bugs elsewhere.
On Sat, 21 Jan 2023 19:44:39 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of array have default values after
> allocations: boolean - `false`, reference types - `null`, double - `0.`
Marked as
On Thu, 19 Jan 2023 19:32:05 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with `null`: it was just created. Java
> guarantees that all elements of array are `null`s anyway.
Marked as reviewed by swi...@github.com (no known OpenJDK username).
-
PR:
On Mon, 16 Jan 2023 20:07:07 GMT, SWinxy wrote:
> Please review this small change to cache a component's popup menu in BLAF.
This pull request has now been integrated.
Changeset: 2e9cb4b1
Author: SWinxy
Committer: Julian Waters
URL:
https://git.openjdk.org/jdk/com
On Wed, 18 Jan 2023 15:21:34 GMT, SWinxy wrote:
>> Please review this small change to cache a component's popup menu in BLAF.
>
> SWinxy has updated the pull request incrementally with one additional commit
> since the last revision:
>
> order imports
@TheShermanTanke
> Please review this small change to cache a component's popup menu in BLAF.
SWinxy has updated the pull request incrementally with one additional commit
since the last revision:
order imports
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12017/files
- new: ht
an be used for. So our remedial options are to change the
documentation; implement macOS and Linux; deprecate it; change the return
type; or any combination. (My thoughts are for deprecating.)
What should we do?
-SWinxy
On Tue, 17 Jan 2023 01:53:05 GMT, SWinxy wrote:
> Please review this itty-bitty typo fix.
This pull request has now been integrated.
Changeset: 8c12ae86
Author: SWinxy
Committer: Alexey Ivanov
URL:
https://git.openjdk.org/jdk/commit/8c12ae867350a866a6a110ea85d86404f1efb0fb
St
On Tue, 17 Jan 2023 16:23:36 GMT, SWinxy wrote:
>> Please review this itty-bitty typo fix.
>
> SWinxy has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Copyright & rm fluff
@TheShermanTanker if you're good to sp
On Tue, 17 Jan 2023 05:14:35 GMT, Prasanta Sadhukhan
wrote:
>> SWinxy has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Single-class imports
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/Ba
> Please review this small change to cache a component's popup menu in BLAF.
SWinxy has updated the pull request incrementally with one additional commit
since the last revision:
Single-class imports
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12017/files
- new: ht
> Please review this itty-bitty typo fix.
SWinxy has updated the pull request incrementally with one additional commit
since the last revision:
Copyright & rm fluff
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12020/files
- new: https://git.openjdk.org/jdk/pul
Please review this itty-bitty typo fix.
-
Commit messages:
- 8283203: Fix typo in SystemTray.getTrayIconSize javadoc
Changes: https://git.openjdk.org/jdk/pull/12020/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=12020=00
Issue: https://bugs.openjdk.org/browse/JDK-8283203
Please review this small change to cache a component's popup menu in BLAF.
-
Commit messages:
- 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get
a popup menu
Changes: https://git.openjdk.org/jdk/pull/12017/files
Webrev:
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Sun, 25 Sep 2022 18:00:39 GMT, SWinxy wrote:
>> The `SDRenderType` enum is often returned using a variable declared at the
>> start of functions. These can be inlined in the `return` itself. Using a
>> ternary operator condenses what may be 12 lines into one, in the most
On Wed, 11 Jan 2023 07:52:13 GMT, Sergey Bylokhov wrote:
> Is it possible to change the current UI style based on the context from the
> separate component?
Looks like it. It _could_ be addressed by passing the `list` object into
`SynthListUI#updateStyle` instead. Or by making these classes
On Sat, 7 Jan 2023 19:29:17 GMT, Andrey Turbanov wrote:
> I don't see this array in
> `src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c` too. Seems
> leftovers from refactoring?
Marked as reviewed by swi...@github.com (no known OpenJDK username).
-
PR:
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Sat, 7 Jan 2023 03:34:02 GMT, SWinxy wrote:
> Added in JDK-8192888, and became unused in JDK-8213843.
This pull request has now been integrated.
Changeset: 7607c07e
Author: SWinxy
Committer: Julian Waters
URL:
https://git.openjdk.org/jdk/com
Added in JDK-8192888, and became unused in JDK-8213843.
-
Commit messages:
- SYNTH_BUTTON_UI_KEY field is unused
Changes: https://git.openjdk.org/jdk/pull/11890/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11890=00
Issue: https://bugs.openjdk.org/browse/JDK-8299774
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Thu, 5 Jan 2023 03:02:11 GMT, Sergey Bylokhov wrote:
>> Small cleanup, unnecessary semicolons are deleted here and there.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> native on win
Marked as reviewed by
On Sat, 24 Dec 2022 03:49:38 GMT, Sergey Bylokhov wrote:
> I have found that we store the native pointer in the
> "java.awt.image.ColorModel#pData" field and never update/clean it. We can
> check how and when the native data is deallocated and reset the pointer, but
> it will be easy just to
On Thu, 29 Dec 2022 20:41:04 GMT, Artem Semenov wrote:
>> [CommonComponentAccessibility getActionsWithEnv:] defines the
>> getAccessibleActionCount method on the AccessibleAction class, however the
>> call should go through CAccessibility so that it is executed on the Event
>> Dispatch
On Thu, 29 Dec 2022 15:54:43 GMT, Artem Semenov wrote:
> [CommonComponentAccessibility getActionsWithEnv:] defines the
> getAccessibleActionCount method on the AccessibleAction class, however the
> call should go through CAccessibility so that it is executed on the Event
> Dispatch thread.
>
The Apple system properties are going to remain as they are, unless e.g.
there's some good reason to change the key of a property. Afaik
setAboutHandler is the only way to set such a callback. I don't know what "
com.apple.mrj.application.apple.menu.about.name" is, as it's not a string
in the JDK.
On Mon, 19 Dec 2022 13:49:18 GMT, Matthias Baesken wrote:
> Looks like the coding in
> jdk/src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java
> readColorPalette is rather close to what staggeredReadByteStream does, so we
> could instead use staggeredReadByteStream
On Thu, 15 Dec 2022 23:41:30 GMT, Phil Race wrote:
> So all the test failures are blocker problem
100%. I'll see what I can learn from the failed tests, but my hunch is that
many fail due to incorrect assumptions.
-
PR: https://git.openjdk.org/jdk/pull/10565
On Sun, 18 Sep 2022 21:23:12 GMT, SWinxy wrote:
> `JRSUIUtils.java` structurally does things weirdly. The utility class mostly
> passes parameters from functions to other functions. The indirection makes
> things harder to understand the eventual purpose.
`JRSUIUtils.java` structurally does things weirdly. The utility class mostly
passes parameters from functions to other functions. The indirection makes
things harder to understand the eventual purpose.
Take `AquaInternalFrameBorderMetrics.java`. It has a `static boolean` that
caches a call to
On Tue, 13 Dec 2022 15:59:53 GMT, Artem Semenov wrote:
> [ComboBoxAccessibility accessibilityValue] works with the accessibleSelection
> object directly, however the work should go through CAccessibility so that it
> is executed on the Event Dispatch thread.
On Mon, 12 Dec 2022 17:37:24 GMT, Phil Race wrote:
> I have made a number of edits to the CSR. There is some rewording which you
> need to copy back to here. Also I didn't see the need to include the @see
> changes in other methods in the CSR. They are not spec-relevant and clutter it
Done.
`XTextAreaPeer`.
>
> Sorry I couldn't write a test; I wasn't sure how I should have accessed the
> protected variable aside from creating extending classes for each class that
> changed.
>
> See also #6603, where this issue was discovered.
SWinxy has updated the pull request in
On Sat, 10 Dec 2022 12:37:42 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8296661 : Typo Found In
>> CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661)
>>
>> This is tracked in JBS as
>> - [JDK-8296661 : Typo Found In
>>
On Fri, 11 Nov 2022 07:00:52 GMT, Andrey Turbanov wrote:
> `Vector args` is used only in single method and then it converted to
> `Object[]`.
> So we can avoid usage of legacy synchronized `Vector` here and use
> `ArrayList` instead.
src/java.desktop/share/classes/java/beans/MetaData.java
On Mon, 5 Dec 2022 08:23:58 GMT, Andrey Turbanov wrote:
> There are 3 implementations of javax.print.DocPrintJob in the JDK (It seems
> they were copy-pasted from each other):
> 1. PSStreamPrintJob
> 2. UnixPrintJob
> 3. Win32PrintJob
>
> They have Vector fields 'jobListeners',
On Thu, 8 Dec 2022 04:31:06 GMT, Prasanta Sadhukhan
wrote:
> Typo rectified
Marked as reviewed by swi...@github.com (no known OpenJDK username).
-
PR: https://git.openjdk.org/jdk/pull/11578
On Wed, 7 Dec 2022 04:07:45 GMT, Sergey Bylokhov wrote:
> ImageLayoutException is used to report any issues with image layout
> calculation. But since we cannot throw the unspecified exception to the
> application, all usages of ImageLayoutException are wrapped by the
> CMMException. And now
make the field private in
> the future.
SWinxy has updated the pull request incrementally with one additional commit
since the last revision:
dash
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10417/files
- new: https://git.openjdk.org/jdk/pull/10417/files/9
make the field private in
> the future.
SWinxy has updated the pull request incrementally with one additional commit
since the last revision:
Use javadoc code syntax for null
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10417/files
- new: https://git.openjdk.o
On Fri, 2 Dec 2022 16:38:54 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly)
; Because we'd no longer be causing a `ClassCastException` from casting this
>> to be a `Graphics2D` object, later down on line 311, if the `Graphics`
>> object isn't a G2D type, then it will throw an NPE. I fear matrices, so I
>> have no idea what the value of `getScaleX(
On Mon, 28 Nov 2022 20:25:19 GMT, Harshitha Onkar wrote:
>> Updated Metal Border code for JInternalFrame.
>>
>> - Added instanceof check before casting Graphics to G2D.
>> - Replaced roundHalfDown with Region.clipRound()
>
> Harshitha Onkar has updated the pull request incrementally with one
On Fri, 25 Nov 2022 01:34:26 GMT, Sergey Bylokhov wrote:
>> The native method used to access the private method in the `ICC_Profile`
>> class is replaced by the accessor.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a
> merge or a rebase. The incremental
On Fri, 4 Nov 2022 01:56:05 GMT, ScientificWare wrote:
> This is referenced in Java Bug Database as
> - [JDK-8296661 : Fix
> typo](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661)
>
> This is tracked in JBS as
> - [JDK-8296661 : Fix
On Tue, 4 Oct 2022 22:52:30 GMT, SWinxy wrote:
> Many `installDefaults` methods set the font, foreground, and background on
> objects but their inverse methods `uninstallDefaults` do not remove them.
> I've added an inverse method to remove the colors and fon
On Tue, 4 Oct 2022 07:00:04 GMT, Renjith Kannath Pariyangad
wrote:
> Updated the documentation with proper meaningful message for better
> understanding.
Marked as reviewed by swi...@github.com (no known OpenJDK username).
@Renjithkannath you need to begin the comment with `/covered`. Could
On Mon, 24 Oct 2022 04:42:18 GMT, Phil Race wrote:
>> src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java line
>> 1364:
>>
>>> 1362:HashSet alreadyChecked) {
>>> 1363: // Avoid descending the same mapping twice.
>>> 1364: if
On Fri, 21 Oct 2022 08:42:12 GMT, Alexander Scherbatiy
wrote:
> A printed content is truncated on macOS if the content paper size width
> larger than height with portrait orientation or width is less than height
> with landscape orientation.
>
> To reproduce the issue run the
>
On Sun, 16 Oct 2022 21:30:47 GMT, Andrey Turbanov wrote:
> Remove couple of unused `static` fields in `sun.awt.geom.Edge` class.
I wonder what they were originally meant for. Some sort of growable list?
-
Marked as reviewed by swi...@github.com (no known OpenJDK username).
PR:
On Sat, 1 Oct 2022 16:53:17 GMT, Andrey Turbanov wrote:
> Hashtable was used only from single thread. And only non-null key/values
> added to it. We can safely replace it with HashSet.
src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java line 1364:
> 1362:
On Tue, 11 Oct 2022 14:17:42 GMT, Manukumar V S wrote:
> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS
> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as
> adding some stability improvements fixes the issue. It intermittently fails
> in CI
JDK-8294904 [1] should be updated with your sample. I'm not exactly
sure why it was marked as resolved this past Friday, but the resolution of
'incomplete' makes me think they didn't feel you provided enough
information. Also I think the OS was set to 'generic' because the lack of
support might
On Sat, 1 Oct 2022 17:05:11 GMT, Andrey Turbanov wrote:
> There are 3 unused fields in single `StyleSheet` file:
> 1. `static final Border noBorder = new EmptyBorder(0,0,0,0);`
> 2. `static final int DEFAULT_FONT_SIZE = 3;`
> 3. `URL imageurl;` in nested
Many `installDefaults` methods set the font, foreground, and background on
objects but their inverse methods `uninstallDefaults` do not remove them. I've
added an inverse method to remove the colors and font to call for the
`uninstallDefaults` methods that install defaults.
`AquaButtonUI` can
On Fri, 23 Sep 2022 01:11:14 GMT, SWinxy wrote:
> I also took the opportunity to link to `realSync(long)`.
>
> /**
> * Parameterless version of realsync which uses default timout (see
> DEFAUL_WAIT_TIME).
> */
>
>
> /**
> * Parameterless version of {@li
1 - 100 of 136 matches
Mail list logo
