On Wed, 26 Jun 2024 08:36:45 GMT, Prasanta Sadhukhan
wrote:
>> Alisen's concern is valid.
>>
>> What if `setEnabled(false)` is called when `isOneTouchExpandable` is `false`
>> and then `setOneTouchExpandable(true)` is called which adds the buttons? The
>> buttons are enabled when they should
On Wed, 26 Jun 2024 08:43:40 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
>> line 376:
>>
>>> 374: leftButton.setEnabled(enabled);
>>> 375: }
>>> 376: }
>>
>> Is it possible to override `isEnabled`
On Tue, 18 Jun 2024 12:19:39 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Omit gtk
>
> test/jdk/javax/swing/JSplitPane/TestSplitPaneEnableTest.java line 100:
>
>> 98:
On Tue, 18 Jun 2024 12:17:41 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Omit gtk
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
> line 376:
>
On Tue, 18 Jun 2024 12:13:49 GMT, Alexey Ivanov wrote:
>> All L including Aqua extends BasicSplitPaneUI so it's ok...The existing
>> test iterates through all L without any issue..
>
>> All L including Aqua extends BasicSplitPaneUI so it's ok...The existing
>> test iterates through all L
On Mon, 17 Jun 2024 05:07:22 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
>> line 369:
>>
>>> 367: @Override
>>> 368: public void setEnabled(boolean enabled) {
>>> 369: if (splitPane.isOneTouchExpandable()
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Mon, 17 Jun 2024 05:08:29 GMT, Prasanta Sadhukhan
wrote:
> All L including Aqua extends BasicSplitPaneUI so it's ok...The existing
> test iterates through all L without any issue..
That is true, yet it is still possible to set a L that doesn't extend
`BasicSplitPaneUI` and the updated
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Fri, 14 Jun 2024 20:39:25 GMT, Alisen Chung wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Omit gtk
>
> src/java.desktop/share/classes/javax/swing/JSplitPane.java line 372:
>
>> 370: public void
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
> can't be dragged via its divider, But if SplitPane have one touch expandable
> true than user can click those buttons and change the divider position.
> So, if splitpane is disabled, then both dragging in divider and
13 matches
Mail list logo
