On Mon, 20 Nov 2023 15:50:54 GMT, Alexey Ivanov wrote:
>> But the current logic in test doesn't hold good for few Look and Feel
>> including Nimbus. Should I make the test as manual mentioning it to be
>> tested against all Look and Feel?
>
> You can have two tests: for Metal and for Synth (Nim
On Mon, 20 Nov 2023 10:55:47 GMT, Tejesh R wrote:
>> Ok.
>
> But the current logic in test doesn't hold good for few Look and Feel
> including Nimbus. Should I make the test as manual mentioning it to be tested
> against all Look and Feel?
You can have two tests: for Metal and for Synth (Nimbu
On Wed, 15 Nov 2023 19:17:14 GMT, Damon Nguyen wrote:
>> U mean to create a test directory and store image there?
>
> Not a new test directory. In that referenced PR, I had to get the path to the
> directory where test files are stored temporarily. This helps with testing
> mainly.
>
> `Path.o
On Mon, 20 Nov 2023 10:11:27 GMT, Tejesh R wrote:
>> Since this PR touches Synth, there should a regression testcase for Synth
>> L&F too..
>
> Ok.
But the current logic in test doesn't hold good for few Look and Feel including
Nimbus. Should I make the test as manual mentioning it to be teste
On Mon, 20 Nov 2023 09:50:19 GMT, Prasanta Sadhukhan
wrote:
>> I couldn't find a way to generalize the automatic test for all L&F, though I
>> tested all manually.
>
> Since this PR touches Synth, there should a regression testcase for Synth L&F
> too..
Ok.
-
PR Review Comment:
On Tue, 7 Nov 2023 04:09:21 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JTable/JTableRightAlignmentTest.java line 64:
>>
>>> 62:
>>> 63: public static void main(String[] args) throws Exception {
>>> 64:
>>> UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
>>
>
On Tue, 7 Nov 2023 04:11:22 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JTable/JTableRightAlignmentTest.java line 121:
>>
>>> 119: private static void saveImage(BufferedImage image, String
>>> fileName) {
>>> 120: try {
>>> 121: ImageIO.write(image, "png", new File(file
On Fri, 3 Nov 2023 21:06:07 GMT, Damon Nguyen wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Synth update
>
> test/jdk/javax/swing/JTable/JTableRightAlignmentTest.java line 64:
>
>> 62:
>> 63: public static void
On Thu, 26 Oct 2023 10:42:52 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
> Table contents does not follow right-left Orientation when Max width of
> columns are set. This is due to not considering the offset in `x position`
> while painting table grid and table cell. The fix handles the offset and
> adjust the x position for each paint, similar to how header is paint
10 matches
Mail list logo
