On Mon, 23 Jan 2023 06:11:46 GMT, Prasanta Sadhukhan
wrote:
> I think it was mistakenly done
I agree. All classes would probably be fine if their code only referenced their
protected object instead of the `e.getSource()` one. If they aren't, then that
means there are bugs elsewhere.
On Mon, 23 Jan 2023 06:01:42 GMT, Prasanta Sadhukhan
wrote:
> It seems true that the code expects to always read the styles from the
> protected field, and that intention seems to be the opposite of what we do in
> the current change, no?
Also, it is done same for all other SYnth classes as
On Sun, 22 Jan 2023 16:16:56 GMT, Sergey Bylokhov wrote:
> > As they ought to. All UI classes assume that the source for the property
> > listener is the component it is the delegate for, which is why we see some
> > classes passing e.getSource() and others passing the protected field. It's
>
On Mon, 16 Jan 2023 19:28:05 GMT, SWinxy wrote:
>As they ought to. All UI classes assume that the source for the property
>listener is the component it is the delegate for, which is why we see some
>classes passing e.getSource() and others passing the protected field. It's not
>something we
On Mon, 16 Jan 2023 05:31:18 GMT, Prasanta Sadhukhan
wrote:
> `list` and `c` points to same object
> _javax.swing.JList[,0,0,0x0,invalid,alignmentX=0.0,alignmentY=0.0,border=javax.swing.plaf.synth.SynthBorder@fc8b518,flags=3355472
>
>
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Wed, 11 Jan 2023 07:52:13 GMT, Sergey Bylokhov wrote:
> Is it possible to change the current UI style based on the context from the
> separate component?
Looks like it. It _could_ be addressed by passing the `list` object into
`SynthListUI#updateStyle` instead. Or by making these classes
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Mon, 9 Jan 2023 16:51:34 GMT, Sergey Bylokhov wrote:
> > I dont think there is any difference between passing method argument
> > vis-a-vis this as I think both point to same object..
>
> Are you sure that it is always the same? Right now we ignore the component
> passed from the
On Mon, 9 Jan 2023 10:17:01 GMT, Prasanta Sadhukhan
wrote:
> I dont think there is any difference between passing method argument
> vis-a-vis this as I think both point to same object..
Are you sure that it is always the same? Right now we ignore the component
passed from the
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Fri, 6 Jan 2023 12:59:40 GMT, Prasanta Sadhukhan
wrote:
> Also, looking at other Synth classes, it seems to be the way to go to
> maintain consistency
But I think we should understand what goes wrong when we pass current values,
and what we fix by this change.
-
PR:
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to
It seems Synth has two cases of updateStyle() where its argument is not passed
to the getContext() call. It seems to be an oversight as in other Synth
classes, the component argument passed to updateStyle is being passed to
getContext().
CI tests are ok with this change and there is no new
18 matches
Mail list logo
