Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-15 Thread Ambarish Rapte
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-13 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-13 Thread Prasanta Sadhukhan
On Thu, 12 Oct 2023 16:31:38 GMT, Prasanta Sadhukhan wrote: > Yes, known issue...please refer > [JDK-8298796](https://bugs.openjdk.org/browse/JDK-8298796) As already mentioned above, this are known issues and not caused by this PR.. This issues will be investigated as part of that JBS...

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Prasanta Sadhukhan
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-10 Thread Prasanta Sadhukhan
On Tue, 10 Oct 2023 06:45:45 GMT, Prasanta Sadhukhan wrote: >>> in the mean time, do you know why the checks are consistently failing for >>> this PR? >> >> No, this failure is in hotspot and it's ok to ignore thisnothing to do >> with the change in this PR >> ❌ [linux-x64 / test (hs/tier

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-10 Thread Phil Race
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-10 Thread Andy Goryachev
On Tue, 10 Oct 2023 06:45:45 GMT, Prasanta Sadhukhan wrote: >>> in the mean time, do you know why the checks are consistently failing for >>> this PR? >> >> No, this failure is in hotspot and it's ok to ignore thisnothing to do >> with the change in this PR >> ❌ [linux-x64 / test (hs/tier

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-09 Thread Prasanta Sadhukhan
On Tue, 10 Oct 2023 03:06:04 GMT, Prasanta Sadhukhan wrote: > > in the mean time, do you know why the checks are consistently failing for > > this PR? > > No, this failure is in hotspot and it's ok to ignore thisnothing to do > with the change in this PR ❌ [linux-x64 / test (hs/tier1 > s

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-09 Thread Prasanta Sadhukhan
On Mon, 9 Oct 2023 17:31:46 GMT, Andy Goryachev wrote: > in the mean time, do you know why the checks are consistently failing for > this PR? No, this failure is in hotspot and it's ok to ignore thisnothing to do with the change in this PR ❌ [linux-x64 / test (hs/tier1 serviceability)](ht

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-09 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-08 Thread Prasanta Sadhukhan
On Fri, 6 Oct 2023 17:34:54 GMT, Andy Goryachev wrote: > With the latest change, it behaves as expected on the primary retina screen. > > However, something is wrong if I put it on the secondary monitor right after > the launch: I am still getting inconsistent behavior, incorrect button > loca

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-06 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-06 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-06 Thread Prasanta Sadhukhan
> SwingNode does not update its internal cache of Swing pref/max/min height and > widths when its JComponent content's corresponding size constraints are > updated. As such, it isn't resized to honor those size constraints. > > JLightweightFrame does install a PropertyChangeListener for "prefer