Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v18]

2024-07-11 Thread Andrey Turbanov
On Mon, 8 Jul 2024 15:40:25 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit for normal >> buttons and tested with libreoffice for menu**), the menu mnemonics toggle >> o

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v18]

2024-07-10 Thread Abhishek Kumar
On Wed, 10 Jul 2024 23:35:59 GMT, Phil Race wrote: > This looks like it is much better than the first iteration and being able to > unify some code is good. The change looks "big" but seems to be mostly > because of refactoring. I suppose you tracked down all tests that need > updating ? Meani

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v18]

2024-07-10 Thread Phil Race
On Mon, 8 Jul 2024 15:40:25 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit for normal >> buttons and tested with libreoffice for menu**), the menu mnemonics toggle >> o

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v18]

2024-07-09 Thread Tejesh R
On Mon, 8 Jul 2024 15:40:25 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit for normal >> buttons and tested with libreoffice for menu**), the menu mnemonics toggle >> o

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v18]

2024-07-08 Thread Alexey Ivanov
On Mon, 8 Jul 2024 15:37:04 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit for normal >> buttons and tested with libreoffice for menu**), the menu mnemonics toggle >> o

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v18]

2024-07-08 Thread Abhishek Kumar
> In GTK LAF, the menu mnemonics are always displayed which is different from > the native behavior. In native application **(tested with gedit for normal > buttons and tested with libreoffice for menu**), the menu mnemonics toggle on > press of `ALT` key. Menu mnemonics are hidden initially and