Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v5]

2024-06-04 Thread Abhishek Kumar
On Tue, 4 Jun 2024 15:21:30 GMT, Alexey Ivanov wrote: >> Updated. > > I can't see it in the PR. Didn't push? Oh my bad, I missed to add that changes. Pushed now. - PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1626228348

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v5]

2024-06-04 Thread Alexey Ivanov
On Tue, 4 Jun 2024 14:46:37 GMT, Abhishek Kumar wrote: >> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java >> line 1: >> >>> 1: /* >> >> You should update the copyright year. > > Updated. I can't see it in the PR. Didn't push? >>

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v5]

2024-06-04 Thread Abhishek Kumar
On Tue, 4 Jun 2024 13:45:44 GMT, Alexey Ivanov wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Code formatting update > > src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line > 1: > >>

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v5]

2024-06-04 Thread Alexey Ivanov
On Mon, 3 Jun 2024 05:52:31 GMT, Abhishek Kumar wrote: >> bug6492108.java test always fails in GTK L in single as well as dual >> screen linux machines. Since this test was not marked as "_headful_" in it's >> initial version, it never failed but after the fix of >>

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v5]

2024-06-03 Thread Abhishek Kumar
On Mon, 3 Jun 2024 05:52:31 GMT, Abhishek Kumar wrote: >> bug6492108.java test always fails in GTK L in single as well as dual >> screen linux machines. Since this test was not marked as "_headful_" in it's >> initial version, it never failed but after the fix of >>

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v5]

2024-06-02 Thread Abhishek Kumar
> bug6492108.java test always fails in GTK L in single as well as dual screen > linux machines. Since this test was not marked as "_headful_" in it's initial > version, it never failed but after the fix of > [JDK-8287051](https://bugs.openjdk.org/browse/JDK-8287051) this test was > problem