On Tue, 13 Sep 2022 22:03:44 GMT, Phil Race wrote:
>> I see now that Phil cryptically said:
>>
>>> Regarding changes in gif + freetype
>> diff --git a/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c
>> b/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c \
>> \
>> d
On Tue, 13 Sep 2022 22:03:44 GMT, Phil Race wrote:
>> I see now that Phil cryptically said:
>>
>>> Regarding changes in gif + freetype
>> diff --git a/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c
>> b/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c \
>> \
>> d
On Tue, 13 Sep 2022 21:23:00 GMT, Magnus Ihse Bursie wrote:
> I'd prefer to only fix typos.
Let us keep only the typos.
-
PR: https://git.openjdk.org/jdk/pull/8328
On Tue, 13 Sep 2022 21:32:44 GMT, Magnus Ihse Bursie wrote:
> I see now that Phil cryptically said:
>
> > Regarding changes in gif + freetype
> > diff --git
> > a/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c
> > b/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder
On Tue, 6 Sep 2022 12:42:05 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> I ignored typos in public methods and variables. Maybe they can be fixed
>> later on without much fanf
On Tue, 13 Sep 2022 20:04:17 GMT, Alexey Ivanov wrote:
> Is `src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c` a
> third-party code?
I don't think so. I find no comments in the source code, or any kind of
indication on this being so. If you say it is, I can revert the changes in
On Tue, 13 Sep 2022 19:48:47 GMT, Alexey Ivanov wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 46 commits:
>>
>> - Merge branch 'master' into typos-in-java.desktop
>> - Revert changes in libjpeg
>>
On Tue, 6 Sep 2022 12:42:05 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> I ignored typos in public methods and variables. Maybe they can be fixed
>> later on without much fanf
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
