Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-10-23 Thread Alexey Ivanov
On Fri, 21 Jul 2023 03:35:57 GMT, Sergey Bylokhov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disabled OLE1 from CoInit > > Marked as reviewed by serb (Reviewer). > @mrserb Could you take a look

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-10-12 Thread Alexey Ivanov
On Fri, 21 Jul 2023 03:35:57 GMT, Sergey Bylokhov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disabled OLE1 from CoInit > > Marked as reviewed by serb (Reviewer). @mrserb Could you take a look at

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-27 Thread Alexey Ivanov
On Thu, 27 Jul 2023 16:23:01 GMT, Alexey Ivanov wrote: >> is it possible that our "::CoInitialize(NULL);" prevents the >> ::CoInitializeEx(NULL, COINIT_MULTITHREADED); in the lib later? > >> is it possible that our "::CoInitialize(NULL);" prevents the >> ::CoInitializeEx(NULL, COINIT_MULTITHREA

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-27 Thread Alexey Ivanov
On Wed, 26 Jul 2023 23:35:25 GMT, Sergey Bylokhov wrote: > is it possible that our "::CoInitialize(NULL);" prevents the > ::CoInitializeEx(NULL, COINIT_MULTITHREADED); in the lib later? It is not only possible, it is explicitly stated. If the threading mode is different, the function fails wit

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-26 Thread Sergey Bylokhov
On Wed, 26 Jul 2023 23:29:41 GMT, Sergey Bylokhov wrote: >>> > > 3. Do another CoInitialize before call :- not a good approach >>> > >>> > Yet it does not break the rules: you can initialise COM, call an API and >>> > then call >>> > [`CoUninitialize`](https://learn.microsoft.com/en-us/window

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-26 Thread Sergey Bylokhov
On Wed, 26 Jul 2023 21:16:11 GMT, Alexey Ivanov wrote: >>> > Probably… But it is still incorrect. Initialising COM on a thread doesn't >>> > mean you can call COM object methods from any thread in your application. >>> >>> Note that "Objects created on a COM thread in a multithread apartment (M

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-26 Thread Alexey Ivanov
On Wed, 26 Jul 2023 21:14:07 GMT, Alexey Ivanov wrote: >>> Probably… But it is still incorrect. Initialising COM on a thread doesn't >>> mean you can call COM object methods from any thread in your application. >> >> Note that "Objects created on a COM thread in a multithread apartment (MTA) >

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-26 Thread Alexey Ivanov
On Wed, 26 Jul 2023 20:56:15 GMT, Sergey Bylokhov wrote: > > Probably… But it is still incorrect. Initialising COM on a thread doesn't > > mean you can call COM object methods from any thread in your application. > > Note that "Objects created on a COM thread in a multithread apartment (MTA) >

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-26 Thread Sergey Bylokhov
On Tue, 25 Jul 2023 11:34:03 GMT, Renjith Kannath Pariyangad wrote: >>> @aivanov-jdk, Thank you for your time and reviews, `CoInitializeEx(NULL, >>> 0)` also resolving this problem because as per document **The default is >>> COINIT_MULTITHREADED**. >> >> This is what I expected, however, the

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-25 Thread Renjith Kannath Pariyangad
On Tue, 25 Jul 2023 09:10:10 GMT, Alexey Ivanov wrote: > > @aivanov-jdk, Thank you for your time and reviews, `CoInitializeEx(NULL, > > 0)` also resolving this problem because as per document **The default is > > COINIT_MULTITHREADED**. > > This is what I expected, however, the documentation fo

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-25 Thread Alexey Ivanov
On Mon, 24 Jul 2023 09:58:09 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disabled OLE1 from CoInit > > src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.c

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-25 Thread Alexey Ivanov
On Thu, 20 Jul 2023 03:39:03 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Observations : >> 1. Without com initialize if we access Mixer for recording, library loaded >> invalid GUID and clipped description in windows(ID not found in registry). >> With com initialization libr

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-24 Thread Renjith Kannath Pariyangad
On Mon, 24 Jul 2023 09:58:09 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disabled OLE1 from CoInit > > src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.c

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-24 Thread Alexey Ivanov
On Thu, 20 Jul 2023 03:39:03 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Observations : >> 1. Without com initialize if we access Mixer for recording, library loaded >> invalid GUID and clipped description in windows(ID not found in registry). >> With com initialization libr

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-24 Thread Alexey Ivanov
On Thu, 20 Jul 2023 03:39:03 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Observations : >> 1. Without com initialize if we access Mixer for recording, library loaded >> invalid GUID and clipped description in windows(ID not found in registry). >> With com initialization libr

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-20 Thread Sergey Bylokhov
On Thu, 20 Jul 2023 03:39:03 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Observations : >> 1. Without com initialize if we access Mixer for recording, library loaded >> invalid GUID and clipped description in windows(ID not found in registry). >> With com initialization libr

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-19 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Observations : > 1. Without com initialize if we access Mixer for recording, library loaded > invalid GUID and clipped description in windows(ID not found in registry). > With com initialization library load proper GUID (same as registry). > 2. For Play back device always loa