On Wed, 13 Sep 2023 20:09:07 GMT, Alexey Ivanov wrote:
>Did you submit a follow-up bug for those files?
>Do you have a PR already?
I plan to work on new PR after merge of this.
-
PR Comment: https://git.openjdk.org/jdk/pull/14847#issuecomment-1718280444
On Tue, 12 Sep 2023 19:59:27 GMT, Andrey Turbanov wrote:
> Do we need a second reviewer or I can integrate?
It's a good question.
Overall, the changes are trivial: only comments are updated, some javadoc for
private classes which are comments, then a couple of method names and variable
names
On Wed, 30 Aug 2023 14:08:21 GMT, Alexey Ivanov wrote:
> I reverted changes in non-Swing parts to reduce amount of files to review.
Did you submit a follow-up bug for those files?
Do you have a PR already?
-
PR Comment: https://git.openjdk.org/jdk/pull/14847#issuecomment-17182508
On Fri, 1 Sep 2023 20:32:42 GMT, Andrey Turbanov wrote:
>> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8312165: Fix typos in java.desktop Sw
On Fri, 1 Sep 2023 12:52:43 GMT, Alexey Ivanov wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8312165: Fix typos in java.desktop Swing
>>
>> apply suggestions from review
>
> src/java.desktop/share/classes
On Fri, 1 Sep 2023 20:26:51 GMT, Andrey Turbanov wrote:
>> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8312165: Fix typos in java.desktop Sw
> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8312165: Fix typos in java.desktop Swing
last fixes
-
Changes:
- all: https://git.op
On Fri, 1 Sep 2023 12:26:26 GMT, Andrey Turbanov wrote:
>> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8312165: Fix typos in java.desktop Sw
On Fri, 1 Sep 2023 12:10:37 GMT, Alexey Ivanov wrote:
>even though you marked the comment as resolved.
Ooops. Sorry for that. Somehow I forgot to commit changes in this file.
-
PR Comment: https://git.openjdk.org/jdk/pull/14847#issuecomment-1702659396
> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8312165: Fix typos in java.desktop Swing
apply suggestions from review
-
Changes:
-
On Thu, 31 Aug 2023 20:11:42 GMT, Andrey Turbanov wrote:
>> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8312165: Fix typos in java.desktop S
> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8312165: Fix typos in java.desktop Swing
apply suggestions from review
-
Changes:
-
On Wed, 30 Aug 2023 14:09:20 GMT, Alexey Ivanov wrote:
>> Andrey Turbanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> comm
On Wed, 30 Aug 2023 08:43:40 GMT, Andrey Turbanov wrote:
>> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
>
> Andrey Turbanov has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> b
On Wed, 30 Aug 2023 08:33:47 GMT, Andrey Turbanov wrote:
> I reverted changes in non-Swing parts to reduce amount of files to review.
I'm unsure it's the right decision, I reviewed them already. On the other hand,
100 files is a smaller chunk, someone could also take a look.
Thanks for fixing
> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
Andrey Turbanov has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains six additi
On Tue, 29 Aug 2023 18:41:05 GMT, Alexey Ivanov wrote:
>> Andrey Turbanov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8312165: Fix typos in java.desktop Swing
>>
>>apply suggestions from review
>> - 8312165: Fix typos in j
> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
Andrey Turbanov has updated the pull request incrementally with two additional
commits since the last revision:
- 8312165: Fix typos in java.desktop Swing
apply suggestions from review
- 8312165: Fix typos in
On Wed, 12 Jul 2023 08:33:30 GMT, Andrey Turbanov wrote:
> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
I reverted changes in non-Swing parts to reduce amount of files to review.
-
PR Comment: https://git.openjdk.org/jdk/pull/14847#issuecomment-169873
19 matches
Mail list logo
