Re: RFR: 8313348: Fix typo in JFormattedTextField: 'it self' [v2]

2023-09-28 Thread Alexey Ivanov
On Thu, 7 Sep 2023 10:24:05 GMT, Alexey Ivanov wrote: > Anyway, I have updated `BasicTreeUI`; in addition to fixing the typo there, I > expanded the wildcard imports. > > Do you have any more comments? @mrserb @mrserb Have I addressed your concerns? Do you have any additional comments? --

Re: RFR: 8313348: Fix typo in JFormattedTextField: 'it self' [v2]

2023-09-07 Thread Alexey Ivanov
On Thu, 7 Sep 2023 10:22:07 GMT, Alexey Ivanov wrote: >> That is wrong suggestion, if the one bug found in one place it is part of >> the fixing process to check that it does not exists in another one. >> Especially for typo it is easy to check. We already discussed this for one >> issue in sc

Re: RFR: 8313348: Fix typo in JFormattedTextField: 'it self' [v2]

2023-09-07 Thread Alexey Ivanov
On Tue, 8 Aug 2023 00:42:36 GMT, Sergey Bylokhov wrote: > That is wrong suggestion, if the one bug found in one place it is part of the > fixing process to check that it does not exists in another one. Especially > for typo it is easy to check. I don't think it is wrong, especially for typos.

Re: RFR: 8313348: Fix typo in JFormattedTextField: 'it self' [v2]

2023-09-05 Thread Alexey Ivanov
> A trivial change: ‘it self’ → ‘itself’. > > In addition to it, I added a comma after ‘Similarly’ where it starts a > sentence. Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision: - Update the copyright and organise imports in BasicTr