On Thu, 7 Sep 2023 10:22:07 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> That is wrong suggestion, if the one bug found in one place it is part of >> the fixing process to check that it does not exists in another one. >> Especially for typo it is easy to check. We already discussed this for one >> issue in scrollbars on windows, where the same bug was missed in the similar >> place. > >> That is wrong suggestion, if the one bug found in one place it is part of >> the fixing process to check that it does not exists in another one. >> Especially for typo it is easy to check. > > I don't think it is wrong, especially for typos. As I said, fixing typos in > the entire code base, even if limited to the `java.desktop` module requires > *considerable* amount of time. Yet fixing a typo in a certain file is a > *trivial fix* which is easy to fix and is quick to review. > >> We already discussed this for one issue in scrollbars on windows, where the >> same bug was missed in the similar place. > > In that case, the problem could be more serious. As I > [explained](https://github.com/openjdk/jdk/pull/14338#issuecomment-1581491086) > in PR #14338, I missed this function was used in another component. At the > same time, no test case has been found where functionality of ScrollBar is > affected. > > I have submitted [the follow-up > issues](https://github.com/openjdk/jdk/pull/14338#issuecomment-1706567768) to > clean it up. Anyway, I have updated `BasicTreeUI`; in addition to fixing the typo there, I expanded the wildcard imports. Do you have any more comments? @mrserb ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15087#discussion_r1318405279
