Re: RFR: 8315883: Open source several Swing JToolbar tests [v4]

2023-09-19 Thread Alexey Ivanov
On Tue, 19 Sep 2023 17:04:59 GMT, Damon Nguyen wrote: >> These are the tests being converted: >> >> javax/swing/JToolBar/4138694/bug4138694.java >> javax/swing/JToolBar/4140421/bug4140421.java >> javax/swing/JToolBar/4196662/bug4196662.java >> javax/swing/JToolBar/4243930/bug4243930.java > > Dam

Re: RFR: 8315883: Open source several Swing JToolbar tests [v3]

2023-09-19 Thread Damon Nguyen
On Tue, 19 Sep 2023 10:18:32 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update constant name > > test/jdk/javax/swing/JToolBar/bug4243930.java line 47: > >> 45: >> 46: public static vo

Re: RFR: 8315883: Open source several Swing JToolbar tests [v3]

2023-09-19 Thread Damon Nguyen
On Tue, 19 Sep 2023 10:17:33 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update constant name > > test/jdk/javax/swing/JToolBar/bug4243930.java line 44: > >> 42: private static class Nul

Re: RFR: 8315883: Open source several Swing JToolbar tests [v4]

2023-09-19 Thread Damon Nguyen
> These are the tests being converted: > > javax/swing/JToolBar/4138694/bug4138694.java > javax/swing/JToolBar/4140421/bug4140421.java > javax/swing/JToolBar/4196662/bug4196662.java > javax/swing/JToolBar/4243930/bug4243930.java Damon Nguyen has updated the pull request incrementally with one add

Re: RFR: 8315883: Open source several Swing JToolbar tests [v3]

2023-09-19 Thread Alexey Ivanov
On Mon, 18 Sep 2023 23:30:26 GMT, Damon Nguyen wrote: >> These are the tests being converted: >> >> javax/swing/JToolBar/4138694/bug4138694.java >> javax/swing/JToolBar/4140421/bug4140421.java >> javax/swing/JToolBar/4196662/bug4196662.java >> javax/swing/JToolBar/4243930/bug4243930.java > > Dam

Re: RFR: 8315883: Open source several Swing JToolbar tests [v2]

2023-09-18 Thread Damon Nguyen
On Mon, 18 Sep 2023 19:02:33 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments update > > test/jdk/javax/swing/JToolBar/bug4138694.java line 41: > >> 39: >> 40: public class bug41

Re: RFR: 8315883: Open source several Swing JToolbar tests [v3]

2023-09-18 Thread Damon Nguyen
> These are the tests being converted: > > javax/swing/JToolBar/4138694/bug4138694.java > javax/swing/JToolBar/4140421/bug4140421.java > javax/swing/JToolBar/4196662/bug4196662.java > javax/swing/JToolBar/4243930/bug4243930.java Damon Nguyen has updated the pull request incrementally with one add

Re: RFR: 8315883: Open source several Swing JToolbar tests [v2]

2023-09-18 Thread Alexey Ivanov
On Mon, 18 Sep 2023 18:55:37 GMT, Damon Nguyen wrote: >> These are the tests being converted: >> >> javax/swing/JToolBar/4138694/bug4138694.java >> javax/swing/JToolBar/4140421/bug4140421.java >> javax/swing/JToolBar/4196662/bug4196662.java >> javax/swing/JToolBar/4243930/bug4243930.java > > Dam

Re: RFR: 8315883: Open source several Swing JToolbar tests [v2]

2023-09-18 Thread Damon Nguyen
On Mon, 18 Sep 2023 13:50:20 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments update > > test/jdk/javax/swing/JToolBar/bug4138694.java line 48: > >> 46: public static void mai

Re: RFR: 8315883: Open source several Swing JToolbar tests [v2]

2023-09-18 Thread Damon Nguyen
On Fri, 15 Sep 2023 23:03:49 GMT, Harshitha Onkar wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments update > > test/jdk/javax/swing/JToolBar/bug4138694.java line 47: > >> 45: >> 46: public stati

Re: RFR: 8315883: Open source several Swing JToolbar tests [v2]

2023-09-18 Thread Damon Nguyen
> These are the tests being converted: > > javax/swing/JToolBar/4138694/bug4138694.java > javax/swing/JToolBar/4140421/bug4140421.java > javax/swing/JToolBar/4196662/bug4196662.java > javax/swing/JToolBar/4243930/bug4243930.java Damon Nguyen has updated the pull request incrementally with one add

Re: RFR: 8315883: Open source several Swing JToolbar tests

2023-09-18 Thread Alexey Ivanov
On Thu, 14 Sep 2023 16:43:29 GMT, Damon Nguyen wrote: > These are the tests being converted: > > javax/swing/JToolBar/4138694/bug4138694.java > javax/swing/JToolBar/4140421/bug4140421.java > javax/swing/JToolBar/4196662/bug4196662.java > javax/swing/JToolBar/4243930/bug4243930.java test/jdk/jav

Re: RFR: 8315883: Open source several Swing JToolbar tests

2023-09-15 Thread Harshitha Onkar
On Thu, 14 Sep 2023 16:43:29 GMT, Damon Nguyen wrote: > These are the tests being converted: > > javax/swing/JToolBar/4138694/bug4138694.java > javax/swing/JToolBar/4140421/bug4140421.java > javax/swing/JToolBar/4196662/bug4196662.java > javax/swing/JToolBar/4243930/bug4243930.java LGTM. I supp

RFR: 8315883: Open source several Swing JToolbar tests

2023-09-14 Thread Damon Nguyen
These are the tests being converted: javax/swing/JToolBar/4138694/bug4138694.java javax/swing/JToolBar/4140421/bug4140421.java javax/swing/JToolBar/4196662/bug4196662.java javax/swing/JToolBar/4243930/bug4243930.java - Commit messages: - Initial test conversion to open Changes: htt