Re: RFR: 8322135: javax/swing/JTable/JTableScrollPrintTest.java & javax/swing/JTable/PrintAllPagesTest.java throws java.lang.InternalError: HTHEME is null [v4]

2024-04-23 Thread Tejesh R
On Tue, 23 Apr 2024 10:34:32 GMT, Alexey Ivanov wrote: >> Means only till openThemeImpl return value and not further up the hierarchy ? > > Yes, only the low-level methods until it's put into a map. Yeah, sounds good. Will do that. - PR Review Comment:

Re: RFR: 8322135: javax/swing/JTable/JTableScrollPrintTest.java & javax/swing/JTable/PrintAllPagesTest.java throws java.lang.InternalError: HTHEME is null [v4]

2024-04-23 Thread Alexey Ivanov
On Tue, 23 Apr 2024 10:30:49 GMT, Tejesh R wrote: >> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 110: >> >>> 108:// See documentation for SetWindowTheme on MSDN. >>> 109:setWindowTheme(widget.substring(0, i)); >>> 110:theme =

Re: RFR: 8322135: javax/swing/JTable/JTableScrollPrintTest.java & javax/swing/JTable/PrintAllPagesTest.java throws java.lang.InternalError: HTHEME is null [v4]

2024-04-23 Thread Tejesh R
On Tue, 23 Apr 2024 10:24:22 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review updates > > src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 110: > >> 108://

Re: RFR: 8322135: javax/swing/JTable/JTableScrollPrintTest.java & javax/swing/JTable/PrintAllPagesTest.java throws java.lang.InternalError: HTHEME is null [v4]

2024-04-23 Thread Alexey Ivanov
On Tue, 23 Apr 2024 10:19:40 GMT, Tejesh R wrote: >> Getting a theme for particular dpi failed in windows L during print test. >> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme >> was independent of DPI. After the fix >>

Re: RFR: 8322135: javax/swing/JTable/JTableScrollPrintTest.java & javax/swing/JTable/PrintAllPagesTest.java throws java.lang.InternalError: HTHEME is null [v4]

2024-04-23 Thread Tejesh R
> Getting a theme for particular dpi failed in windows L during print test. > Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme > was independent of DPI. After the fix > (https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd) > getting a