On Tue, 23 Apr 2024 10:24:22 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review updates > > src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 110: > >> 108: // See documentation for SetWindowTheme on MSDN. >> 109: setWindowTheme(widget.substring(0, i)); >> 110: theme = getOpenThemeValue(widget.substring(i + 2), dpi); > > I suggest changing the type of `theme` variable from `Long` to `long` as well > as the return value of `openThemeImpl`. Means only till openThemeImpl return value and not further up the hierarchy ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18706#discussion_r1576026977
