Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]

2024-03-29 Thread Alexey Ivanov
On Tue, 5 Mar 2024 13:15:04 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Updated instruction > > test/jdk/java/awt/print/PrinterJob/DrawImage.java line 93: > >> 91: if (

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]

2024-03-06 Thread Alexey Ivanov
On Wed, 6 Mar 2024 06:07:20 GMT, Renjith Kannath Pariyangad wrote: >> test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 74: >> >>> 72: if (pj.printDialog(prSet)) { >>> 73: pj.print(prSet); >>> 74: } >> >> In this case, the pr

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]

2024-03-05 Thread Renjith Kannath Pariyangad
On Tue, 5 Mar 2024 13:07:30 GMT, Alexey Ivanov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Updated instruction > > test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 74: > >> 72:

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]

2024-03-05 Thread Alexey Ivanov
On Mon, 4 Mar 2024 06:33:09 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know y

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]

2024-03-05 Thread Alexey Ivanov
On Mon, 4 Mar 2024 06:33:09 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know y

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]

2024-03-03 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has upda