Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v4]

2024-03-18 Thread Sergey Bylokhov
On Fri, 15 Mar 2024 14:50:12 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted bet

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v4]

2024-03-15 Thread Alexey Ivanov
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is > synchronized. > > Without synchronization, a thread checks if `filesLoader` is not null and > creates a new `FilesLoader` thread. If the thread is pre-empted between these > two operations, another thread or even several t

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-15 Thread Alexey Ivanov
On Thu, 14 Mar 2024 19:57:06 GMT, Sergey Bylokhov wrote: >> Alexey Ivanov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Store the size of fileCache inside synchronized block > > src/java.desktop/share/classes/javax/swing/plaf/basic/Bas

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-14 Thread Sergey Bylokhov
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted betw

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-14 Thread Sergey Bylokhov
On Tue, 5 Mar 2024 11:04:30 GMT, Alexey Ivanov wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java >> line 101: >> >>> 99: */ >>> 100: public synchronized void invalidateFileCache() { >>> 101: if (filesLoader != null) { >> >> This is a publ

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-13 Thread Andrey Turbanov
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted betw

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-13 Thread Alexey Ivanov
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted betw

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-13 Thread Alexey Ivanov
On Wed, 13 Mar 2024 15:57:55 GMT, Alexey Ivanov wrote: > > If this makes that CCME go away I'll be pleased. > > @prrace CCME is already gone, Tejesh and I resolved it under > [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) in #17462. The `BasicDirectoryModel/ConcurrentModification.

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-13 Thread Alexey Ivanov
On Tue, 12 Mar 2024 20:01:29 GMT, Phil Race wrote: > If this makes that CCME go away I'll be pleased. @prrace CCME is already gone, Tejesh and I resolved it under [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) in #17462. > I am assuming you've run the "full" battery of tests on thi

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-13 Thread Tejesh R
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted betw

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-12 Thread Phil Race
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted betw

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-06 Thread Alexey Ivanov
On Wed, 6 Mar 2024 10:43:16 GMT, Tejesh R wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Replace synchronized invalidateFileCache with synchronized block inside >> - Declare DoChangeContents constructor priva

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]

2024-03-06 Thread Alexey Ivanov
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is > synchronized. > > Without synchronization, a thread checks if `filesLoader` is not null and > creates a new `FilesLoader` thread. If the thread is pre-empted between these > two operations, another thread or even several t

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-06 Thread Tejesh R
On Tue, 5 Mar 2024 11:07:13 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted betw

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-05 Thread Alexey Ivanov
On Tue, 5 Mar 2024 11:07:13 GMT, Alexey Ivanov wrote: >> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is >> synchronized. >> >> Without synchronization, a thread checks if `filesLoader` is not null and >> creates a new `FilesLoader` thread. If the thread is pre-empted betw

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-05 Thread Alexey Ivanov
On Tue, 5 Mar 2024 09:24:52 GMT, Andrey Turbanov wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Replace synchronized invalidateFileCache with synchronized block inside >> - Declare DoChangeContents constructo

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-05 Thread Alexey Ivanov
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is > synchronized. > > Without synchronization, a thread checks if `filesLoader` is not null and > creates a new `FilesLoader` thread. If the thread is pre-empted between these > two operations, another thread or even several t

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]

2024-03-05 Thread Alexey Ivanov
On Tue, 5 Mar 2024 00:48:13 GMT, Sergey Bylokhov wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Replace synchronized invalidateFileCache with synchronized block inside >> - Declare DoChangeContents constructo

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache

2024-03-05 Thread Andrey Turbanov
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote: > Ensure access to the `filesLoader` field of `BasicDirectoryModel` is > synchronized. > > Without synchronization, a thread checks if `filesLoader` is not null and > creates a new `FilesLoader` thread. If the thread is pre-empted between t

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache

2024-03-05 Thread Andrey Turbanov
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote: > Ensure access to the `filesLoader` field of `BasicDirectoryModel` is > synchronized. > > Without synchronization, a thread checks if `filesLoader` is not null and > creates a new `FilesLoader` thread. If the thread is pre-empted between t

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache

2024-03-04 Thread Sergey Bylokhov
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote: > Ensure access to the `filesLoader` field of `BasicDirectoryModel` is > synchronized. > > Without synchronization, a thread checks if `filesLoader` is not null and > creates a new `FilesLoader` thread. If the thread is pre-empted between t

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache

2024-03-04 Thread Alexey Ivanov
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote: > Ensure access to the `filesLoader` field of `BasicDirectoryModel` is > synchronized. > > Without synchronization, a thread checks if `filesLoader` is not null and > creates a new `FilesLoader` thread. If the thread is pre-empted between t

Re: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache

2024-03-04 Thread Alexey Ivanov
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote: > Ensure access to the `filesLoader` field of `BasicDirectoryModel` is > synchronized. > > Without synchronization, a thread checks if `filesLoader` is not null and > creates a new `FilesLoader` thread. If the thread is pre-empted between t

RFR: 8325179: Race in BasicDirectoryModel.validateFileCache

2024-03-04 Thread Alexey Ivanov
Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized. Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can s