Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS [v2]

2024-03-11 Thread Alexey Ivanov
On Thu, 7 Mar 2024 12:36:05 GMT, Dmitry Markov wrote: >> Updated several tests to avoid potential failure with recent LCMS update and >> non-LCMS generated profile. > > Dmitry Markov has updated the pull request incrementally with one additional > commit since the last revision: > > Toleranc

Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS [v2]

2024-03-11 Thread Alexey Ivanov
On Thu, 7 Mar 2024 12:36:05 GMT, Dmitry Markov wrote: >> Updated several tests to avoid potential failure with recent LCMS update and >> non-LCMS generated profile. > > Dmitry Markov has updated the pull request incrementally with one additional > commit since the last revision: > > Toleranc

Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS [v2]

2024-03-08 Thread Sergey Bylokhov
On Thu, 7 Mar 2024 12:36:05 GMT, Dmitry Markov wrote: >> Updated several tests to avoid potential failure with recent LCMS update and >> non-LCMS generated profile. > > Dmitry Markov has updated the pull request incrementally with one additional > commit since the last revision: > > Toleranc

Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS [v2]

2024-03-08 Thread Dmitry Markov
On Fri, 8 Mar 2024 01:09:27 GMT, Sergey Bylokhov wrote: >> I agree, I reverted almost all changes except the ones in tolerance for >> non-LCMS profiles. That values need to be updated to make the test pass on >> JDKs (e.g. JDK 8u, etc) where non-LCMS profiles are used > > Could you please clari

Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS [v2]

2024-03-07 Thread Sergey Bylokhov
On Thu, 7 Mar 2024 12:32:09 GMT, Dmitry Markov wrote: >> Actually the purpose of these particular tests is validation of the quality >> of the built-in color profiles. > > I agree, I reverted almost all changes except the ones in tolerance for > non-LCMS profiles. That values need to be updated

Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS [v2]

2024-03-07 Thread Dmitry Markov
> Updated several tests to avoid potential failure with recent LCMS update and > non-LCMS generated profile. Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision: Tolerance update - Changes: - all: https://git.openjdk.org/

Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS [v2]

2024-03-07 Thread Dmitry Markov
On Tue, 5 Mar 2024 03:49:01 GMT, Sergey Bylokhov wrote: >> test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63: >> >>> 61: 10.5, // GRAY >>> 62: 215.0, // PYCC >>> 63: 56.0// CIEXYZ >> >> All this change will delete all information about

Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS

2024-03-04 Thread Sergey Bylokhov
On Tue, 5 Mar 2024 00:58:42 GMT, Sergey Bylokhov wrote: >> Updated several tests to avoid potential failure with recent LCMS update and >> non-LCMS generated profile. > > test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63: > >> 61: 10.5, // GRAY >> 62: 215.

Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS

2024-03-04 Thread Sergey Bylokhov
On Sun, 3 Mar 2024 09:01:49 GMT, Dmitry Markov wrote: > Updated several tests to avoid potential failure with recent LCMS update and > non-LCMS generated profile. test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63: > 61: 10.5, // GRAY > 62: 215.0, //

Re: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS

2024-03-04 Thread Alexey Ivanov
On Sun, 3 Mar 2024 09:01:49 GMT, Dmitry Markov wrote: > Updated several tests to avoid potential failure with recent LCMS update and > non-LCMS generated profile. The fix is to always use the accuracy which is used for the LCMS library, without trying to detect what colour profile is used. Rig

RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS

2024-03-03 Thread Dmitry Markov
Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile. - Commit messages: - 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS Changes: https://git.openjdk.org/jdk/pull/18097/files Webr