On Wed, 19 Jun 2024 19:35:54 GMT, Alexey Ivanov wrote:
> Would it be clearer if setDelay(50) was called in the constructor of
> bug6492108?
I am ok with the current placing of setDelay(50).
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1647193228
On Wed, 19 Jun 2024 19:20:24 GMT, Alexey Ivanov wrote:
>>> You should rather call
>>> [setDelay(50)](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294)
>>> to add the delay between method calls.
>>
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
Marked as reviewed by aivanov (Reviewer).
-
PR Review:
On Wed, 19 Jun 2024 15:38:10 GMT, Alexander Zvegintsev
wrote:
>>> How does it help? You're delaying EDT.
>>
>> I was unable to reproduce the failure scenario in my local machine but
>> didn't observe any failure in mach5 also. Will ask Vitaly or @azvegint to
>> verify as they are able to
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
Marked as reviewed by azvegint (Reviewer).
-
PR Review:
On Wed, 19 Jun 2024 11:15:54 GMT, Abhishek Kumar wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 113:
>>
>>> 111: }
>>> 112: setDelay(50);
>>> 113: return panel;
>>
>> How does it help? You're delaying EDT.
>>
>> You should rather call
>>
On Wed, 19 Jun 2024 11:01:26 GMT, Alexey Ivanov wrote:
> How does it help? You're delaying EDT.
I was unable to reproduce the failure scenario in my local machine but didn't
observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as
they are able to replicate the failure.
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
You should ask Vitaly to test your changeset in his environment to confirm the
Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a delay
to stable the test and multiple run in CI is Ok. Link is added in JBS.
-
Commit messages:
- delay added for stable test
Changes: https://git.openjdk.org/jdk/pull/19788/files
Webrev:
