Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-07-10 Thread Phil Race
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote: > This is somewhat a continuation for > [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and > [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509). > > The former removed the `doIt` flag in #18584, but it introduced a

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-28 Thread Alisen Chung
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote: > This is somewhat a continuation for > [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and > [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509). > > The former removed the `doIt` flag in #18584, but it introduced a

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-27 Thread Alexey Ivanov
On Thu, 27 Jun 2024 13:15:19 GMT, Julian Waters wrote: > It would be helpful if JNI had a jobject unique_ptr type for C++ But `std::unique_ptr` wasn't available when JNI had been conceived… It could be added… The declaration in your sample still looks cumbersome… or _unwieldy_ as you said.

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-27 Thread Julian Waters
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote: > This is somewhat a continuation for > [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and > [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509). > > The former removed the `doIt` flag in #18584, but it introduced a

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-27 Thread Alexey Ivanov
On Thu, 27 Jun 2024 12:54:55 GMT, Alexey Ivanov wrote: > > …I believe I was referring to the use of C++'s std::unique_ptr, which has > > the functionality for cleanup that we need. > > Yes, `std::unique_ptr` could be useful for handling automatic deallocation of > objects created with the

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-27 Thread Alexey Ivanov
On Thu, 27 Jun 2024 11:26:24 GMT, Julian Waters wrote: > …I believe I was referring to the use of C++'s std::unique_ptr, which has the > functionality for cleanup that we need. Yes, `std::unique_ptr` could be useful for handling automatic deallocation of objects created with the `new`

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-27 Thread Julian Waters
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote: > This is somewhat a continuation for > [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and > [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509). > > The former removed the `doIt` flag in #18584, but it introduced a

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-27 Thread Alexey Ivanov
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote: > This is somewhat a continuation for > [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and > [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509). > > The former removed the `doIt` flag in #18584, but it introduced a

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-27 Thread Alexey Ivanov
On Wed, 26 Jun 2024 23:42:16 GMT, Alisen Chung wrote: >> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 640: >> >>> 638: HGLOBAL oldG = AwtPrintControl::getPrintHDMode(env, self); >>> 639: if (setup.hDevMode != oldG) { >>> 640:

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-26 Thread Alisen Chung
On Wed, 26 Jun 2024 23:37:48 GMT, Alisen Chung wrote: >> This is somewhat a continuation for >> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and >> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509). >> >> The former removed the `doIt` flag in #18584, but it introduced a

Re: RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-26 Thread Alisen Chung
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote: > This is somewhat a continuation for > [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and > [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509). > > The former removed the `doIt` flag in #18584, but it introduced a

RFR: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-06-24 Thread Alexey Ivanov
This is somewhat a continuation for [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509). The former removed the `doIt` flag in #18584, but it introduced a regression. The regression is resolved by the latter in #19786, and