Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v4]

2025-05-21 Thread Sergey Bylokhov
On Wed, 21 May 2025 21:00:24 GMT, Phil Race wrote: > I really don't see that as being the right thing to do here. The goal of this change is to delete the usage of applet, but as a replacement the change uses the awt frame, while i think the right thing to use in our examples are "modern" swin

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v5]

2025-05-21 Thread Sergey Bylokhov
On Wed, 21 May 2025 20:21:54 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 Marked as rev

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v4]

2025-05-21 Thread Phil Race
On Wed, 21 May 2025 20:53:32 GMT, Sergey Bylokhov wrote: > > This is in the AWT package so I think AWT components is better. > > And the goal is just to get rid of the applet mentions and I've now done > > that (after the last one) > > But these layout classes are used for both awt and swing li

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v4]

2025-05-21 Thread Sergey Bylokhov
On Wed, 21 May 2025 20:15:43 GMT, Phil Race wrote: > This is in the AWT package so I think AWT components is better. > And the goal is just to get rid of the applet mentions and I've now done that > (after the last one) But these layout classes are used for both awt and swing libraries. And sin

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v5]

2025-05-21 Thread Alexey Ivanov
On Wed, 21 May 2025 20:18:13 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 Marked as rev

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v5]

2025-05-21 Thread Phil Race
> Update the some code examples and accompanying images to no longer mention or > display as applets. Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8357176 - Changes: - all: https://git.openjdk.org/jdk/pull/25278/files

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v4]

2025-05-21 Thread Phil Race
On Wed, 21 May 2025 17:34:22 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 > btw maybe i

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]

2025-05-21 Thread Phil Race
On Wed, 21 May 2025 18:56:51 GMT, Sergey Bylokhov wrote: > > > Ok .. here's uploaded javadoc to view > > > > > > > ``` > > > // The background image fills the frame so we > > > // don't need to clear the applet on repaints. > > > // Just call the paint method. > > > public void update(Graph

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v4]

2025-05-21 Thread Alexey Ivanov
On Wed, 21 May 2025 17:34:22 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 It looks good

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v4]

2025-05-21 Thread Sergey Bylokhov
On Wed, 21 May 2025 17:34:22 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 btw maybe it

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]

2025-05-21 Thread Sergey Bylokhov
On Tue, 20 May 2025 23:09:53 GMT, Sergey Bylokhov wrote: > > Ok .. here's uploaded javadoc to view > > > ``` > > // The background image fills the frame so we > > // don't need to clear the applet on repaints. > > // Just call the paint method. > > public void update(Graphics g) { > > p

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]

2025-05-21 Thread Phil Race
On Tue, 20 May 2025 22:09:37 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 I think I hav

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v4]

2025-05-21 Thread Phil Race
> Update the some code examples and accompanying images to no longer mention or > display as applets. Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8357176 - Changes: - all: https://git.openjdk.org/jdk/pull/25278/files

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]

2025-05-21 Thread Alexey Ivanov
On Tue, 20 May 2025 22:09:37 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 src/java.desk

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v2]

2025-05-21 Thread Alexey Ivanov
On Tue, 20 May 2025 21:56:28 GMT, Phil Race wrote: >> src/java.desktop/share/classes/java/awt/GridLayout.java line 50: >> >>> 48: * >>> 49: * EventQueue.invokeAndWait(() -> { >>> 50: *Frame frame = new Frame("GridLayout"); >> >> I would like to bring this to the discussion not ne

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]

2025-05-21 Thread Alexey Ivanov
On Tue, 20 May 2025 22:09:37 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 I still have

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]

2025-05-20 Thread Sergey Bylokhov
On Tue, 20 May 2025 22:09:37 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 > Ok .. here'

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]

2025-05-20 Thread Phil Race
On Tue, 20 May 2025 22:09:37 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 Ok .. here's

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]

2025-05-20 Thread Phil Race
On Tue, 20 May 2025 20:00:16 GMT, Alexey Ivanov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8357176 > > src/java.desktop/share/classes/java/awt/BorderLayout.java line 103: > >> 101: * >> 102: * >> 103: * impo

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]

2025-05-20 Thread Phil Race
> Update the some code examples and accompanying images to no longer mention or > display as applets. Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8357176 - Changes: - all: https://git.openjdk.org/jdk/pull/25278/files

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v2]

2025-05-20 Thread Phil Race
On Tue, 20 May 2025 21:17:22 GMT, Sergey Bylokhov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8357176 > > src/java.desktop/share/classes/java/awt/GridLayout.java line 50: > >> 48: * >> 49: * EventQueue.invo

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v2]

2025-05-20 Thread Sergey Bylokhov
On Tue, 20 May 2025 20:30:21 GMT, Phil Race wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8357176 src/java.desk

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API [v2]

2025-05-20 Thread Phil Race
> Update the some code examples and accompanying images to no longer mention or > display as applets. Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8357176 - Changes: - all: https://git.openjdk.org/jdk/pull/25278/files

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API

2025-05-20 Thread Phil Race
On Fri, 16 May 2025 23:04:28 GMT, Phil Race wrote: > Update the some code examples and accompanying images to no longer mention or > display as applets. > > It seems the new screenshots could be improved by capturing them on a HiDPI > > (Retina) display, as the current images appear blurry. An

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API

2025-05-20 Thread Alexey Ivanov
On Fri, 16 May 2025 23:04:28 GMT, Phil Race wrote: > Update the some code examples and accompanying images to no longer mention or > display as applets. src/java.desktop/share/classes/java/awt/BorderLayout.java line 103: > 101: * > 102: * > 103: * import java.awt.BorderLayout; Should we r

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API

2025-05-20 Thread Alexey Ivanov
On Tue, 20 May 2025 19:12:21 GMT, Phil Race wrote: > BTW I tried a couple of times to upload javadoc to cr.openjdk.org so I could > show the new rendered javadoc but uploads failed ... I experienced some issues with uploading files to cr.openjdk.org some time ago; recently it worked well, howe

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API

2025-05-20 Thread Phil Race
On Mon, 19 May 2025 12:44:35 GMT, Alexey Ivanov wrote: >> Update the some code examples and accompanying images to no longer mention >> or display as applets. > > src/java.desktop/share/classes/java/awt/GridBagLayout.java line 243: > >> 241: * right-to-left container. >> 242: * >> 243: * >

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API

2025-05-19 Thread Alexey Ivanov
On Fri, 16 May 2025 23:04:28 GMT, Phil Race wrote: > Update the some code examples and accompanying images to no longer mention or > display as applets. src/java.desktop/share/classes/java/awt/GridBagLayout.java line 243: > 241: * right-to-left container. > 242: * > 243: * Is it possible

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API

2025-05-19 Thread Alexey Ivanov
On Mon, 19 May 2025 00:04:33 GMT, Sergey Bylokhov wrote: > It seems the new screenshots could be improved by capturing them on a HiDPI > (Retina) display, as the current images appear blurry. And to eliminate > background elements in the corners, it might be better to capture screenshots > of

Re: RFR: 8357176: java.awt javadoc code examples still use Applet API

2025-05-18 Thread Sergey Bylokhov
On Fri, 16 May 2025 23:04:28 GMT, Phil Race wrote: > Update the some code examples and accompanying images to no longer mention or > display as applets. It seems the new screenshots could be improved by capturing them on a HiDPI (Retina) display, as the current images appear blurry. And to eli

RFR: 8357176: java.awt javadoc code examples still use Applet API

2025-05-16 Thread Phil Race
Update the some code examples and accompanying images to no longer mention or display as applets. - Commit messages: - 8357176 Changes: https://git.openjdk.org/jdk/pull/25278/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25278&range=00 Issue: https://bugs.openjdk.org/b