On Thu, 17 Jul 2025 21:25:08 GMT, Phil Race wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since th
On Thu, 17 Jul 2025 21:25:08 GMT, Phil Race wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since th
On Thu, 17 Jul 2025 21:25:08 GMT, Phil Race wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since th
On Thu, 17 Jul 2025 00:32:34 GMT, Brent Christian wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8362291
>
> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 98:
>
>> 96: /** Reference to t
> Remove a finalize() method in CGraphicsEnvironment, replacing it with
> Disposer.
>
> I don't see a way to add a test to verify this clean up.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8362291
-
Changes:
- all:
On Wed, 16 Jul 2025 22:34:02 GMT, Phil Race wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since th
On Wed, 16 Jul 2025 22:04:29 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8362291
>
> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 157:
>
>> 155:
>>
> Remove a finalize() method in CGraphicsEnvironment, replacing it with
> Disposer.
>
> I don't see a way to add a test to verify this clean up.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8362291
-
Changes:
- all:
On Wed, 16 Jul 2025 20:57:40 GMT, Phil Race wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since th
On Tue, 15 Jul 2025 22:40:02 GMT, Phil Race wrote:
>> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 154:
>>
>>> 152:
>>> 153: public synchronized void dispose() {
>>> 154: if (displayReconfigContext != 0L) {
>>
>> can it be 0 here? it seems we never
On Wed, 16 Jul 2025 00:09:51 GMT, Sergey Bylokhov wrote:
>> It doesn't have to be. Is it a problem that it is ?
>
> Yeah, if it does not need to be, we can skip it; otherwise, we can update all
> existing implementations to follow the same pattern.
I removed it
-
PR Review Comment
> Remove a finalize() method in CGraphicsEnvironment, replacing it with
> Disposer.
>
> I don't see a way to add a test to verify this clean up.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8362291
-
Changes:
- all:
On Tue, 15 Jul 2025 22:39:48 GMT, Phil Race wrote:
>> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 153:
>>
>>> 151: }
>>> 152:
>>> 153: public synchronized void dispose() {
>>
>> Why the method is synchronized? we can call it on a different threads via
On Tue, 15 Jul 2025 21:14:54 GMT, Sergey Bylokhov wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 153:
>
>> 151
On Tue, 15 Jul 2025 20:42:15 GMT, Phil Race wrote:
> Remove a finalize() method in CGraphicsEnvironment, replacing it with
> Disposer.
>
> I don't see a way to add a test to verify this clean up.
src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 153:
> 151: }
> 15
Remove a finalize() method in CGraphicsEnvironment, replacing it with Disposer.
I don't see a way to add a test to verify this clean up.
-
Commit messages:
- 8362291
Changes: https://git.openjdk.org/jdk/pull/26332/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26332&range
16 matches
Mail list logo
