Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]

2023-10-10 Thread Alexey Ivanov
On Tue, 10 Oct 2023 15:11:24 GMT, Andy Goryachev wrote: >>> would it make more sense to use a switch statement instead of a static map? >> >> I believe this was discussed somewhere… Looks like map provides better >> performance compared to `switch` statement. Fetching an element from a map >>

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]

2023-10-10 Thread Andy Goryachev
On Tue, 10 Oct 2023 15:04:51 GMT, Alexey Ivanov wrote: >> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1439: >> >>> 1437: >>> 1438: private static Map initColorNames() { >>> 1439: return Map.ofEntries( >> >> would it make more sense to use a switch statement i

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]

2023-10-10 Thread Alexey Ivanov
On Tue, 10 Oct 2023 14:44:04 GMT, Andy Goryachev wrote: > would it make more sense to use a switch statement instead of a static map? I believe this was discussed somewhere… Looks like map provides better performance compared to `switch` statement. Fetching an element from a map gives a consta

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]

2023-10-10 Thread Alexey Ivanov
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named c

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]

2023-10-10 Thread Andy Goryachev
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named c

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]

2023-10-09 Thread ScientificWare
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named c

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]

2023-10-09 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.openjdk.ja