Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v4]

2023-01-25 Thread Phil Race
On Wed, 28 Dec 2022 00:10:53 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8296661 : Typo Found In >> CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661) >> >> This is tracked in JBS as >> - [JDK-8296661 : Typo Found In >> CSSPars

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v4]

2023-01-25 Thread SWinxy
On Wed, 25 Jan 2023 16:13:00 GMT, Andy Goryachev wrote: > do we know why this test is failing? Doesn't matter; it's javadoc changes only. Pre-submit tests randomly fail sometimes for no good reason. - PR: https://git.openjdk.org/jdk/pull/10975

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v4]

2023-01-25 Thread Andy Goryachev
On Wed, 28 Dec 2022 00:10:53 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8296661 : Typo Found In >> CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661) >> >> This is tracked in JBS as >> - [JDK-8296661 : Typo Found In >> CSSPars

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v4]

2023-01-24 Thread SWinxy
On Mon, 12 Dec 2022 13:06:09 GMT, Alexey Ivanov wrote: >> Looks good to me. >> >> In the description above: “…invoked one per property…”, it shoud be “once”. >> >> I think there's room for improvement. However, this is an internal-only >> class. > >> I think there's room for improvement. Howev

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v4]

2023-01-24 Thread ScientificWare
On Wed, 28 Dec 2022 00:10:53 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8296661 : Typo Found In >> CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661) >> >> This is tracked in JBS as >> - [JDK-8296661 : Typo Found In >> CSSPars

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v4]

2022-12-27 Thread ScientificWare
On Mon, 12 Dec 2022 13:06:09 GMT, Alexey Ivanov wrote: >> Looks good to me. >> >> In the description above: “…invoked one per property…”, it shoud be “once”. >> >> I think there's room for improvement. However, this is an internal-only >> class. > >> I think there's room for improvement. Howev

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v4]

2022-12-27 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8296661 : Typo Found In > CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661) > > This is tracked in JBS as > - [JDK-8296661 : Typo Found In > CSSParser.java](https://bugs.openjdk.java.net/browse/JDK-8296661) > > I