On Mon, 3 Jul 2023 21:28:36 GMT, Alexey Ivanov wrote:
>> @aivanov-jdk Yeah, I wasn't sure of open brace placement in native - some
>> methods follow Java-style of having the open brace on the same line and few
>> others have it on the next line. Will revert it in the next commit.
>
> Follow the
On Mon, 3 Jul 2023 20:38:34 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> kCGEventFlagMaskSecondaryFn added
>
> test/jdk/java/awt/Robot/RobotModifierMaskTest.java line 67:
>
>> 65:
On Mon, 3 Jul 2023 21:26:13 GMT, Harshitha Onkar wrote:
>> I disagree: the common style throughout this file is to put the opening
>> brace on the following line. A few lines above, `GetCGKeyCode` follows the
>> same style.
>
> @aivanov-jdk Yeah, I wasn't sure of open brace placement in native
On Mon, 3 Jul 2023 20:28:35 GMT, Alexey Ivanov wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m line 426:
>>
>>> 424: }
>>> 425:
>>> 426: static inline int GetCGKeyMask(int cgKeyCode)
>>
>> Suggestion:
>>
>> static inline int GetCGKeyMask(int cgKeyCode) {
>
> I disagree: the
On Mon, 3 Jul 2023 04:45:38 GMT, Abhishek Kumar wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> kCGEventFlagMaskSecondaryFn added
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m line 426:
>
>> 424:
On Sat, 1 Jul 2023 00:29:11 GMT, Harshitha Onkar wrote:
>> **Problem:**
>>
>> Robot erroneously produces lowercase letter when mouse is moved (manually)
>> in unison with Robot's keyEvents on MacOS. This issue was originally logged
>> by a developer of an on-screen accessibility keyboard - To
