On Tue, 19 Mar 2024 12:13:43 GMT, Abhishek Kumar wrote:
>> I agree with @azvegint, since it has @requires check in jtreg and the test
>> will mainly be run using jtreg framework , the OS check is not strictly
>> required.
>
> Fair enough.
I agree. Adding an explicit OS check adds one more depe
On Mon, 18 Mar 2024 17:28:16 GMT, Harshitha Onkar wrote:
>> It can be added, but I see no reason to do so.
>>
>> It may be helpful for tests that can be run standalone (that don't respect
>> the jtreg tags and depend on some other jtreg libraries), but for this one
>> the only easy way to run
On Mon, 18 Mar 2024 15:39:52 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 55:
>>
>>> 53:
>>> 54: public static void main (String[] args) throws Exception {
>>> 55: PassFailJFrame.builder()
>>
>> OS check can be added.
>> htt
On Sat, 16 Mar 2024 22:34:10 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
On Mon, 18 Mar 2024 12:25:24 GMT, Abhishek Kumar wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> comm
On Sat, 16 Mar 2024 22:34:10 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://github.com/openjdk/jdk/pull/18319
Harshitha Onkar has updated the pull request
On Sat, 16 Mar 2024 09:36:57 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
