On Mon, 10 Jun 2024 20:33:05 GMT, Alexey Ivanov wrote:
> These improvements to the test can be combined with fixing
> [JDK-8333026](https://bugs.openjdk.org/browse/JDK-8333026), or the test can
> be updated separately.
>
> I'll submit a new bug to track this activity. Thank you for bringing
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
small typo and typing change, LGTM
-
Marked as reviewed
On Mon, 10 Jun 2024 20:15:55 GMT, Alisen Chung wrote:
> Maybe outside the scope of this issue, but could this test be automated?
I've been thinking about it, too.
No, it can't be automated completely: the tester has to click Print / OK button
in the Print dialog.
Yes, other aspects of the
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
Maybe outside the scope of this issue, but could this test be
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
Ran the updated test and looks good to me.
-
Marked as
On Wed, 5 Jun 2024 12:20:00 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
>>
>>> 170:
>>> 171: try {
>>> 172: g2d.drawString(emptyIterator, 20.0f, 180.0f);
>>
>> Does the line below also need to change ?
>>
On Wed, 5 Jun 2024 04:53:56 GMT, Abhishek Kumar wrote:
>> Hi Reviewers,
>> I have updated the test case with passing float value for evaluation and a
>> typo. Please review and let me know your suggestions if any.
>
> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
>
>> 170:
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
>
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
Marked as reviewed by aivanov (Reviewer).
-
PR Review:
Hi Reviewers,
I have updated the test case with passing float value for evaluation and a
typo. Please review and let me know your suggestions if any.
-
Commit messages:
- JDK-860 : PrintNullString.java doesn't use float arguments
Changes:
10 matches
Mail list logo
