Re: Possible Bug In clojure.zip/remove

2009-03-23 Thread Jason Sankey
Frantisek Sodomka wrote: On Mar 19, 12:58 pm, Jason Sankey ja...@zutubi.com wrote: Also, is there somewhere I can contribute test cases for this to prevent a future regression? Tests for clojure.zip can from now on go to test-clojure.clojure-zip:

Re: Possible Bug In clojure.zip/remove

2009-03-22 Thread Frantisek Sodomka
On Mar 19, 12:58 pm, Jason Sankey ja...@zutubi.com wrote: Also, is there somewhere I can contribute test cases for this to prevent a future regression? Tests for clojure.zip can from now on go to test-clojure.clojure-zip:

Re: Possible Bug In clojure.zip/remove

2009-03-20 Thread Frantisek Sodomka
On Mar 19, 11:37 pm, Jason Sankey ja...@zutubi.com wrote: I pretty much have it working for the test-clojure suite now, although I'm sure the code could use review by a more experienced eye.  I've been looking at adding the other two top-level suites (test-contrib and datalog) too, but their

Re: Possible Bug In clojure.zip/remove

2009-03-20 Thread Jason Sankey
Hi Frantisek, Frantisek Sodomka wrote: On Mar 19, 11:37 pm, Jason Sankey ja...@zutubi.com wrote: I pretty much have it working for the test-clojure suite now, although I'm sure the code could use review by a more experienced eye. I've been looking at adding the other two top-level suites

Possible Bug In clojure.zip/remove

2009-03-19 Thread Jason Sankey
Hi All, I've been teaching myself clojure and in the process am working on a small program to manipulate an XML file. I figured this was a good chance to try clojure.zip, but I'm having some difficulty. Being a newbie I strongly suspected myself - but when I posed the question on IRC the

Re: Possible Bug In clojure.zip/remove

2009-03-19 Thread Jason Sankey
Hi Christophe, On Mar 19, 11:22 am, Christophe Grand christo...@cgrand.net wrote: Jason Sankey a écrit : (if (and (branch? loc) (not (empty? (children loc   (recur (- loc down rightmost))   loc)) Being new to both clojure and zip I admit there's still a good chance that I have

Re: Possible Bug In clojure.zip/remove

2009-03-19 Thread Rich Hickey
On Mar 19, 7:22 am, Christophe Grand christo...@cgrand.net wrote: Jason Sankey a écrit : (if (and (branch? loc) (not (empty? (children loc (recur (- loc down rightmost)) loc)) Being new to both clojure and zip I admit there's still a good chance that I have no idea what I'm

Re: Possible Bug In clojure.zip/remove

2009-03-19 Thread Frantisek Sodomka
On Mar 19, 12:58 pm, Jason Sankey ja...@zutubi.com wrote: Also, is there somewhere I can contribute test cases for this to prevent a future regression? In order to contribute, you must fill-in and send The Contributor Agreement (CA) to Rich Hickey: http://clojure.org/contributing Tests for

Re: Possible Bug In clojure.zip/remove

2009-03-19 Thread Jason Sankey
Hi Frantisek, Frantisek Sodomka wrote: On Mar 19, 12:58 pm, Jason Sankey ja...@zutubi.com wrote: Also, is there somewhere I can contribute test cases for this to prevent a future regression? In order to contribute, you must fill-in and send The Contributor Agreement (CA) to Rich Hickey: